From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186]) by dpdk.org (Postfix) with ESMTP id DB1637E9F for ; Tue, 14 Oct 2014 18:05:02 +0200 (CEST) Received: from android-fb5fc4f6ed62fb42.attlocal.net (99-34-229-174.lightspeed.sntcca.sbcglobal.net [99.34.229.174]) by mail.mhcomputing.net (Postfix) with ESMTPSA id 1E27D80C3D9; Tue, 14 Oct 2014 09:11:58 -0700 (PDT) User-Agent: K-9 Mail for Android In-Reply-To: <3422655.1tIybTbukh@xps13> References: <1413273236-1873-1-git-send-email-mhall@mhcomputing.net> <20141014094415.GB8912@BRICHA3-MOBL> <1300A4C9-3CCF-48A9-8C33-901D700BAEB4@mhcomputing.net> <3422655.1tIybTbukh@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 From: Matthew Hall Date: Tue, 14 Oct 2014 09:12:35 -0700 To: Thomas Monjalon Message-ID: Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Oct 2014 16:05:03 -0000 In the virtio-net-pmd it is done in the same directory. Hence me submitting this to try to make it easier for others to use the product. Also the default DPDK doesn't ignore the build target directories... but I already had to fork that one to fix clang compile failures in the examples files. Matthew. -- Sent from my mobile device. On October 14, 2014 9:09:49 AM PDT, Thomas Monjalon wrote: >> >I thought our .gitignore could do with a few entries added alright, >I >> >just never expected this one to be top of the list! While I don't >think >> >it does any harm, I'm just curious why you think it needs to be >added? >> > >> >/Bruce >> >> I import all my DPDK dependencies as git submodules. When the >submodules >> contain unignored files, they get marked as dirty by git, and it >makes >> like difficult when it comes to updating my submodule pointers. >> >> Matthew. > >So you cannot update submodules without filling .gitignore? > >I'm not a big fan of .gitignore because I like seeing what has been >generated by looking at "git status". >And it's not really needed in DPDK because compilation is often done in >a separate directory.