From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AFA794CE4 for ; Sat, 16 Jul 2016 11:46:28 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 16 Jul 2016 02:46:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,372,1464678000"; d="scan'208";a="140245991" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga004.fm.intel.com with ESMTP; 16 Jul 2016 02:46:27 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.204]) by IRSMSX154.ger.corp.intel.com ([169.254.12.28]) with mapi id 14.03.0248.002; Sat, 16 Jul 2016 10:46:26 +0100 From: "Richardson, Bruce" To: Thomas Monjalon CC: Nikita Kozlov , "dev@dpdk.org" Thread-Topic: [PATCH v2 5/5] test: change lpm routes file from header to data file Thread-Index: AQHR3enIfGak5Hk6nUmyi9cdZOdXMqAaDioAgADD2Kc= Date: Sat, 16 Jul 2016 09:46:25 +0000 Message-ID: References: <1465909410-4668-1-git-send-email-nikita@elyzion.net> <1468512382-30412-1-git-send-email-bruce.richardson@intel.com> <1468512382-30412-6-git-send-email-bruce.richardson@intel.com>, <1599312.dUSpteANtl@xps13> In-Reply-To: <1599312.dUSpteANtl@xps13> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 5/5] test: change lpm routes file from header to data file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jul 2016 09:46:29 -0000 > On 16 Jul 2016, at 00:05, Thomas Monjalon wro= te: >=20 > 2016-07-14 17:06, Bruce Richardson: >> Change the file extension of the test_lpm_routes file from .h to .dat. >> This makes the lines-of-code counts for DPDK more realistic as they are = not >> affected by the huge counts from the lpm data. >>=20 >> Signed-off-by: Bruce Richardson >> --- >> app/test/Makefile | 2 +- >> app/test/{test_lpm_routes.h =3D> test_lpm_routes.dat} | 0 >=20 > The size of the git tree significantly increase after renaming this file: > git -c gc.reflogExpire=3D0 -c gc.reflogExpireUnreachable=3D0 > -c gc.rerereresolved=3D0 -c gc.rerereunresolved=3D0 -c gc.pruneExpire= =3Dnow gc > --aggressive && du -sk .git > 28272 .git > git am > git -c gc.reflogExpire=3D0 -c gc.reflogExpireUnreachable=3D0 > -c gc.rerereresolved=3D0 -c gc.rerereunresolved=3D0 -c gc.pruneExpire= =3Dnow gc > --aggressive && du -sk .git > 33188 .git >=20 > I think it would be better to replace this huge file by a script generati= ng > the test resource. >=20 Completely agree. This was a temporary fix anyway so if it causes git bloat= lets just wait for the permanent fix. Bruce =