From: Yongseok Koh <yskoh@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "dpdk stable" <stable@dpdk.org>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"Xueming(Steven) Li" <xuemingl@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix inlining segmented TSO packet
Date: Fri, 11 May 2018 03:34:56 +0000 [thread overview]
Message-ID: <DAFBEFE4-A3F5-414F-A110-03CAD6FB065B@mellanox.com> (raw)
In-Reply-To: <20180511005032.30646-1-yskoh@mellanox.com>
> On May 10, 2018, at 5:50 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
>
> When a multi-segmented packet is inlined, data can be further inlined even
> after the first segment. In case of TSO packet, extra inline data after TSO
> header should be carried by an inline DSEG which has 4B inline header
> recording the length of the inline data. If more than one segment is
> inlined, the length doesn't count from the second segment. This will cause
> a fault in HW and CQE will have an error, which is ignored by PMD.
>
> Fixes: f895536be4fa ("net/mlx5: enable inlining data from multiple segments")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Shahaf,
If you apply this patch, please amend the signed-off-by tag.
I should've added Xueming as he found it for the first time.
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Thanks,
Yongseok
next prev parent reply other threads:[~2018-05-11 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 0:50 Yongseok Koh
2018-05-11 3:34 ` Yongseok Koh [this message]
2018-05-11 17:39 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
2018-05-13 6:23 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAFBEFE4-A3F5-414F-A110-03CAD6FB065B@mellanox.com \
--to=yskoh@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).