From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00045.outbound.protection.outlook.com [40.107.0.45]) by dpdk.org (Postfix) with ESMTP id DEEBC1C157; Fri, 11 May 2018 05:34:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ITlQG5oEsyyZIxajgxZnl5wOvdGruHDk4mq8F6DUKTI=; b=A1cE6x1BwR5xl/j9o036lAxNCF7nCzXQvGXJrKwBUX1L66MhlDAeFzRYWP3Ap9h1bDy2xTHuzU7J2OwR+P0GtpEE19hcAg5O3qTO8drqPHSp/S1RzltmvjMTYttj/NLZhEHAQmhaI+3MlCbNTMswOQC0qVbha0YgKJ5EtooYesk= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2094.eurprd05.prod.outlook.com (10.167.196.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Fri, 11 May 2018 03:34:57 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d%13]) with mapi id 15.20.0755.012; Fri, 11 May 2018 03:34:57 +0000 From: Yongseok Koh To: Shahaf Shuler CC: "dev@dpdk.org" , dpdk stable , "Adrien Mazarguil" , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Xueming(Steven) Li" Thread-Topic: [PATCH] net/mlx5: fix inlining segmented TSO packet Thread-Index: AQHT6MIaIfn+JkZWaUGRl4EuI2RSO6Qp4J2A Date: Fri, 11 May 2018 03:34:56 +0000 Message-ID: References: <20180511005032.30646-1-yskoh@mellanox.com> In-Reply-To: <20180511005032.30646-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [73.222.116.174] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2094; 7:ir/PX1iYr8ZRkoMIMvwNA5+qKSK91RUvgeUlZHfmr5qLtzP7qA58MntkKNvaqwNflWpWXJhye/jjwddwIINVkiYcR4dB34VplZ5kgd/mrD5VTdqRUPI1yAlBMw49U8lwZuG+Tb/x9tfAfTermGuJ6ptBxa9iPhusqgiT7im2B8QLM212+tt0Gk1gowmzOWxtJoCnWeMHi1viFPO2KccIa2BAJ5WDJlsqNYdZLcSTCjD6AgQT8LZaE7EmiEGozvNR x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2094; x-ms-traffictypediagnostic: VI1PR0501MB2094: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR0501MB2094; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2094; x-forefront-prvs: 06691A4183 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(376002)(366004)(396003)(346002)(199004)(189003)(36756003)(4326008)(478600001)(33656002)(2900100001)(5660300001)(53936002)(8676002)(6246003)(8936002)(6862004)(81156014)(54906003)(81166006)(6512007)(107886003)(25786009)(97736004)(6116002)(82746002)(106356001)(3846002)(105586002)(7736002)(37006003)(6486002)(305945005)(68736007)(229853002)(6436002)(2616005)(3280700002)(3660700001)(2906002)(446003)(476003)(102836004)(316002)(6506007)(86362001)(486006)(66066001)(76176011)(14454004)(5250100002)(11346002)(53546011)(83716003)(6636002)(26005)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2094; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: GB/hPC/JDppi8I3IfD8auFyxWgsMQC1uh3MH7oP14kPan6OdfNzav4BX58gzxRUATZ84TrW5Asq3505ueA4WUPqNtobV2DDmtRz7wvRfokHfvz/z50DR3+fz1LPVSmYVliG7KmSUBEnR3po0fmRv7MZ5bOAYY5ot5fVYP8oTf7LOb1+dm4roff1swFYhkQJ8 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <7AEC11E05826544CB918A09563A0BDCF@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 909dce09-5186-49c3-cdc8-08d5b6f02ae6 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 909dce09-5186-49c3-cdc8-08d5b6f02ae6 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2018 03:34:56.9562 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2094 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix inlining segmented TSO packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 03:35:00 -0000 > On May 10, 2018, at 5:50 PM, Yongseok Koh wrote: >=20 > When a multi-segmented packet is inlined, data can be further inlined eve= n > after the first segment. In case of TSO packet, extra inline data after T= SO > header should be carried by an inline DSEG which has 4B inline header > recording the length of the inline data. If more than one segment is > inlined, the length doesn't count from the second segment. This will caus= e > a fault in HW and CQE will have an error, which is ignored by PMD. >=20 > Fixes: f895536be4fa ("net/mlx5: enable inlining data from multiple segmen= ts") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh Shahaf, If you apply this patch, please amend the signed-off-by tag. I should've added Xueming as he found it for the first time. > Signed-off-by: Xueming Li > Signed-off-by: Yongseok Koh Thanks, Yongseok=