From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0069.outbound.protection.outlook.com [104.47.1.69]) by dpdk.org (Postfix) with ESMTP id DB7B85F5D for ; Wed, 7 Mar 2018 00:33:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=da/slpG3rwCI3wUntUlWgtYyn04TANTet5b2rdiM5qU=; b=nMJZgFs5H6EayMIm0wMeAZ7lti5Wxn7Hud4n1gSmGwawUNn0EtXJaxOzPfM27hknS7xGpk+6fM/T373bKzxkTMUMOymYv07wC1Y8uNQYvt5VpyZjY9TxwEAB1bA+8uXq4pTOL3rqqzXDKpfrmXzyWfMGia1y1Sizp3Gd69rp8iU= Received: from DB3PR0402MB3852.eurprd04.prod.outlook.com (52.134.71.143) by DB3PR0402MB3754.eurprd04.prod.outlook.com (52.134.71.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Tue, 6 Mar 2018 23:33:18 +0000 Received: from DB3PR0402MB3852.eurprd04.prod.outlook.com ([fe80::8554:d533:15e:1376]) by DB3PR0402MB3852.eurprd04.prod.outlook.com ([fe80::8554:d533:15e:1376%13]) with mapi id 15.20.0548.016; Tue, 6 Mar 2018 23:33:17 +0000 From: Ahmed Mansour To: "Verma, Shally" , "Trahe, Fiona" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" , "Athreya, Narayana Prasad" , "Gupta, Ashish" , "Sahu, Sunila" , "Challa, Mahipal" , "Jain, Deepak K" , Hemant Agrawal , Roy Pledge , Youri Querry Thread-Topic: [dpdk-dev] [PATCH] compressdev: implement API Thread-Index: AQHTnFM5yhoAdd9nE0i9ZEIaZBO9+Q== Date: Tue, 6 Mar 2018 23:33:17 +0000 Message-ID: References: <1517595924-25963-1-git-send-email-fiona.trahe@intel.com> <12544144.czVLKRyaz4@xps> <348A99DA5F5B7549AA880327E580B43589325187@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B4358932983C@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B43589329F78@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B4358932A333@IRSMSX101.ger.corp.intel.com> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.88.168.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0402MB3754; 7:XCvfEIA1GlsRH6FdWNofHgYpHzHD5DaDttU4bBe/b7Oe50YDtSkdtOLX7m1XcQvZkI8geNx687TSaXDnGL96XN2SHIpD21Ot/Dr+wouXuyB/dxaqffUd76SsBq9Tv8hzrkJs3YnrOlVQeyRggjC/bSKF9BWQxsRtzWX5ZBMLqWDRRnf38JsUdyH9eovIQyIWvFjLLR0Vl/UxHDKUicN7jVsc5fQ2MaKas6G7meMTvo7+dqYm3KGlyqWgUGri9Wt8 x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(346002)(396003)(39850400004)(376002)(39380400002)(366004)(189003)(199004)(13464003)(316002)(3846002)(53936002)(97736004)(55016002)(5890100001)(9686003)(2501003)(66066001)(2900100001)(186003)(26005)(2906002)(6116002)(33656002)(6506007)(5660300001)(102836004)(5250100002)(93886005)(229853002)(53546011)(6246003)(6436002)(106356001)(6346003)(7696005)(4326008)(76176011)(8936002)(99286004)(478600001)(14454004)(25786009)(305945005)(74316002)(86362001)(54906003)(3660700001)(81156014)(7736002)(105586002)(3280700002)(68736007)(110136005)(81166006)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0402MB3754; H:DB3PR0402MB3852.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1793ae58-7c1a-497e-2014-08d583baa36d x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0402MB3754; x-ms-traffictypediagnostic: DB3PR0402MB3754: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231220)(944501244)(52105095)(6055026)(6041288)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:DB3PR0402MB3754; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0402MB3754; x-forefront-prvs: 06036BD506 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=ahmed.mansour@nxp.com; x-microsoft-antispam-message-info: xTdRQvDKCcF5nQlZQ5VFZLhWcnrVKLZIkKFouy4ewFaTbhFA1PN+NDKkA37tqTSRVN5JeWXxPnyTnzaS2mtaQi4gcY8XRGBZFhKGxWpU/WKR3MsQEqu/6aDqlKd+mIvmnG0u+tNVCPX1BJPvnNMSast60a+InGRvs10Ze3JcG3YfsBoIuIm4eNeLI0i7YGu1SlL/PktJgFyb9y3quPJsGBf2kcikpLlM8sRgI72IVXR/ZA3SAs0azFizs1L2s143PUuZYplmxc1gCi6R7AcPqrGur5DWchy36HzQz2Mxn/365n9+yICkgauHVU0UxE4eVnsiz09gY6FIdVfdGafkOQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1793ae58-7c1a-497e-2014-08d583baa36d X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2018 23:33:17.0536 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3754 Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 23:33:20 -0000 On 3/5/2018 9:32 AM, Verma, Shally wrote:=0A= >=0A= >> -----Original Message-----=0A= >> From: Ahmed Mansour [mailto:ahmed.mansour@nxp.com]=0A= >> Sent: 03 March 2018 01:19=0A= >> To: Trahe, Fiona ; Verma, Shally ; dev@dpdk.org=0A= >> Cc: De Lara Guarch, Pablo ; Athreya, Nar= ayana Prasad ;=0A= >> Gupta, Ashish ; Sahu, Sunila ; Challa, Mahipal=0A= >> ; Jain, Deepak K ; H= emant Agrawal ; Roy=0A= >> Pledge ; Youri Querry =0A= >> Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API=0A= >>=0A= >> On 3/2/2018 4:53 AM, Trahe, Fiona wrote:=0A= >>>> On 3/1/2018 9:41 AM, Trahe, Fiona wrote:=0A= >>>>> Hi Shally=0A= >>>>>=0A= >>>>> //snip//=0A= >>>>>> [Shally] This looks better to me. So it mean app would always call x= form_init() for stateless and attach=0A= >>>> an=0A= >>>>>> updated priv_xform to ops (depending upon if there's shareable or no= t). So it does not need to have=0A= >>>>>> NULL pointer on priv_xform. right?=0A= >>>>>>=0A= >>>>> [Fiona] yes. The PMD must return a valid priv_xform pointer.=0A= >>>> [Ahmed] What I understood is that the xform_init will be called once= =0A= >>>> initially. if the @flag returned is NONE_SHAREABLE then the applicatio= n=0A= >>>> must not attach two inflight ops to the same @priv_xform? Otherwise th= e=0A= >>>> application can attach many ops in flight to the @priv_xform?=0A= >>> [Fiona Yes. App calls the xform_init() once on a device where it plans = to send stateless ops.=0A= >>> If PMD returns shareable, then it doesn't need to call again and can at= tach this to every stateless op going to that device.=0A= >>> If PMD returns SINGLE_OP then it must call xform_init() before every ot= her=0A= >>> stateless op it wants to have inflight simultaneously. This does not me= an it must be called before every op,=0A= >>> but probably will set up a batch of priv_xforms - it can reuse each pr= iv_xform once the op finishes with it.=0A= >> [Ahmed] @Shally Can this complexity of managing the NONE_SHAREABLE mode= =0A= >> be pushed into the PMD? A flexible stockpile can be kept and maintained= =0A= >> by the PMD and it can be increased or decreased based on=0A= >> low-water/high-water thresholds=0A= > [Shally] It is doable to manage within PMD but need to do hands on to eva= luate effectiveness. So far, we have never exercised this way and left it t= o application to attach different session (or stream) to op for maximum per= formance gain. So, I would say, may it be ok to have flag feature in first = place and deprecate later, if it not required?! Or just have API without an= y flag option and add a feature flag to indicate PMD support for SHAREABLE/= NON-SHAREABLE xform_priv handle?!=0A= [Ahmed] Either way looks ok to me. I see your point about performance.=0A= If this is in the PMD it will have to constantly guess how much memory=0A= the user needs and accommodate dynamically. The user can implement a=0A= similar scheme or if the application is simple they can pre-allocate and=0A= reduce CPU allocation de-allocation overhead.=0A=