From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6C51A00E6 for ; Mon, 5 Aug 2019 14:59:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D83211BDFD; Mon, 5 Aug 2019 14:59:24 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by dpdk.org (Postfix) with ESMTP id 80FE61BDFC for ; Mon, 5 Aug 2019 14:59:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NksO9HBfBIV43Y3MNTbOxCn5Llfjog7URyG+Keqa9bonaw1KEbad8NTINr5fGrsUit8/QuHaWjyDtJIMfvPP4l46+BhRqQ3Aq12zYzRUtjzt/86r/dq+2nn42BTdEH1mSs6vPe3Fcigj0r66221ngkypihfRxXFBoiuA7R3bmTLTGof86tnMcxGfCqgnu4vgnMoz/xPHG1frktFSKaanFnr7IRkQ+Ddgu/zyKIdy9T+vgcVIGTkm9wKINpKjkmoiqPgcVozKUji+NibO2yVzYbZ6Df0D+aqXsrBWT6CDPJxdGEpMPfQLjIxaBTQhAbqNbF9uGMan1r+MKuIahj+fhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zxNuRPwb+ZBPAGFPawXZDFu1TXZ6DWf4cq4ntlPcXE8=; b=lfOkOmzgGu0Da8IFv4KMDFZ3ml+rB29yI3TuNG5lgbQWXAe3Jjcl0HFsts+PNiCMwBoxpzwgNanO+p6b8jO4K+D0rEo4b0Z3hxQUciJfUC/jHyRJoxFSupy2aF34Yw9bOSoXT59f8XlRdRzB2U142nFvumFdZY0RlH0HQxp9cdCv7jpkWpc7D0l5xTN2P/kJ03hpwpYFDu5MJGSE5tVuGy91WbGwQjYRKFb0k2jengT9GAvD49E4XLzZ5/j7+uz2fa8p3miW3FWxr4jgN+zf6h1lnE+iDsbxCnX6TC6ovRr0GLfLH+5VDwoAaBSFmPVyq3Q3eTOGaAdarLMxIEFGIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zxNuRPwb+ZBPAGFPawXZDFu1TXZ6DWf4cq4ntlPcXE8=; b=kw6Qz06Q0/O9M+FpyhRFCa3jmXdTDsOuC3dpOsnKR7CVD+cdVI7ti3eJReeVxmaFpprcqXaDlbwRRDwsJItW2lRRfH2vn/0Edt8FJtcW5kl6AwERapr9j8D7pdnto+oleohw9o5SaymIUTorjr16N5UpmMWXngesN5NlXngU0NM= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4075.eurprd05.prod.outlook.com (52.134.67.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.15; Mon, 5 Aug 2019 12:59:20 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3%5]) with mapi id 15.20.2136.018; Mon, 5 Aug 2019 12:59:20 +0000 From: Raslan Darawsheh To: Dekel Peled , Yongseok Koh , Slava Ovsiienko , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive Thread-Index: AQHVS1yvLUfAHtW5x0qMbonfZiIGO6bshFGw Date: Mon, 5 Aug 2019 12:59:20 +0000 Message-ID: References: <1f303dbfa3900b1d435ff323a05ab166684da8b9.1564988649.git.dekelp@mellanox.com> In-Reply-To: <1f303dbfa3900b1d435ff323a05ab166684da8b9.1564988649.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b17a9420-539d-4bcb-b91d-08d719a4bb59 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4075; x-ms-traffictypediagnostic: DB3PR0502MB4075: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(199004)(189003)(13464003)(9686003)(68736007)(6636002)(53936002)(446003)(11346002)(99286004)(6436002)(186003)(4326008)(55016002)(25786009)(486006)(476003)(54906003)(110136005)(316002)(52536014)(7696005)(102836004)(5660300002)(66066001)(71190400001)(256004)(71200400001)(478600001)(26005)(14454004)(74316002)(66446008)(76176011)(2906002)(6116002)(229853002)(86362001)(3846002)(66946007)(66476007)(66556008)(76116006)(64756008)(6246003)(8936002)(33656002)(7736002)(53546011)(6506007)(81166006)(8676002)(81156014)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4075; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: YFaCYL8hJ1Fsqr2dnGZWpRxGr7azJn35iNMduNNwKo6Qu5LFg2iVyooP62H+R8OiHgxlQqR4sbjoc6n5wvRhlo9lEbRxZGJC3Fzzfee+RXQWUme/E0GGhmFEbUa80NneoFqcxr4GFKHnMvbpskTytG8tH53ET9dYWNvlhvOv8dDydsm0HrMbml7WG0kiKwr9jqmOF1K+8/tBw8VQ0gTp5ziTKTszpnk65ryraXS4micI/QxxmsJ0NEgaO44yCB364ifc5GIuToIya0g4CPgIVZHcfaGgnPJ1q1u54LISczFI2dSriZPVrT8MVdvMbEK3bMkgnIE+18B51CRnnZedp6HbTCL78+rajY+fRj+4pZWcg3n2ZpVAWhFGB2emXTCKP/uxAntTZFqwuXnBJGbgKJtDJxEw9Fe22eWd+Xh/Qus= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b17a9420-539d-4bcb-b91d-08d719a4bb59 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2019 12:59:20.2786 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4075 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Monday, August 5, 2019 10:07 AM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive >=20 > Part of the code in function flow_dv_matcher_enable() is enclosed in '#if= def > HAVE_MLX5DV_DR' preprocessor directive. > Using this directive is not needed here, and prevents compilation of rele= vant > code. >=20 > This patch removes the redundant preprocessor directive. >=20 > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow_dv.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 9c0a261..582f644 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -4324,11 +4324,9 @@ struct field_modify_info modify_tcp[] =3D { > match_criteria_enable |=3D > (!HEADER_IS_ZERO(match_criteria, misc_parameters_2)) << > MLX5_MATCH_CRITERIA_ENABLE_MISC2_BIT; > -#ifdef HAVE_MLX5DV_DR > match_criteria_enable |=3D > (!HEADER_IS_ZERO(match_criteria, misc_parameters_3)) << > MLX5_MATCH_CRITERIA_ENABLE_MISC3_BIT; > -#endif > return match_criteria_enable; > } >=20 > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh