* [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive
@ 2019-08-05 7:07 Dekel Peled
2019-08-05 11:01 ` Slava Ovsiienko
2019-08-05 12:59 ` Raslan Darawsheh
0 siblings, 2 replies; 3+ messages in thread
From: Dekel Peled @ 2019-08-05 7:07 UTC (permalink / raw)
To: yskoh, viacheslavo, shahafs; +Cc: orika, dev
Part of the code in function flow_dv_matcher_enable() is enclosed in
'#ifdef HAVE_MLX5DV_DR' preprocessor directive.
Using this directive is not needed here, and prevents compilation of
relevant code.
This patch removes the redundant preprocessor directive.
Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 9c0a261..582f644 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -4324,11 +4324,9 @@ struct field_modify_info modify_tcp[] = {
match_criteria_enable |=
(!HEADER_IS_ZERO(match_criteria, misc_parameters_2)) <<
MLX5_MATCH_CRITERIA_ENABLE_MISC2_BIT;
-#ifdef HAVE_MLX5DV_DR
match_criteria_enable |=
(!HEADER_IS_ZERO(match_criteria, misc_parameters_3)) <<
MLX5_MATCH_CRITERIA_ENABLE_MISC3_BIT;
-#endif
return match_criteria_enable;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive
2019-08-05 7:07 [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive Dekel Peled
@ 2019-08-05 11:01 ` Slava Ovsiienko
2019-08-05 12:59 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Slava Ovsiienko @ 2019-08-05 11:01 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh, Shahaf Shuler; +Cc: Ori Kam, dev
> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Monday, August 5, 2019 10:07
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix redundant use of directive
>
> Part of the code in function flow_dv_matcher_enable() is enclosed in '#ifdef
> HAVE_MLX5DV_DR' preprocessor directive.
> Using this directive is not needed here, and prevents compilation of relevant
> code.
>
> This patch removes the redundant preprocessor directive.
>
> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index 9c0a261..582f644 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -4324,11 +4324,9 @@ struct field_modify_info modify_tcp[] = {
> match_criteria_enable |=
> (!HEADER_IS_ZERO(match_criteria, misc_parameters_2)) <<
> MLX5_MATCH_CRITERIA_ENABLE_MISC2_BIT;
> -#ifdef HAVE_MLX5DV_DR
> match_criteria_enable |=
> (!HEADER_IS_ZERO(match_criteria, misc_parameters_3)) <<
> MLX5_MATCH_CRITERIA_ENABLE_MISC3_BIT;
> -#endif
> return match_criteria_enable;
> }
>
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive
2019-08-05 7:07 [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive Dekel Peled
2019-08-05 11:01 ` Slava Ovsiienko
@ 2019-08-05 12:59 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2019-08-05 12:59 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh, Slava Ovsiienko, Shahaf Shuler; +Cc: Ori Kam, dev
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Monday, August 5, 2019 10:07 AM
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive
>
> Part of the code in function flow_dv_matcher_enable() is enclosed in '#ifdef
> HAVE_MLX5DV_DR' preprocessor directive.
> Using this directive is not needed here, and prevents compilation of relevant
> code.
>
> This patch removes the redundant preprocessor directive.
>
> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index 9c0a261..582f644 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -4324,11 +4324,9 @@ struct field_modify_info modify_tcp[] = {
> match_criteria_enable |=
> (!HEADER_IS_ZERO(match_criteria, misc_parameters_2)) <<
> MLX5_MATCH_CRITERIA_ENABLE_MISC2_BIT;
> -#ifdef HAVE_MLX5DV_DR
> match_criteria_enable |=
> (!HEADER_IS_ZERO(match_criteria, misc_parameters_3)) <<
> MLX5_MATCH_CRITERIA_ENABLE_MISC3_BIT;
> -#endif
> return match_criteria_enable;
> }
>
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-05 12:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 7:07 [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive Dekel Peled
2019-08-05 11:01 ` Slava Ovsiienko
2019-08-05 12:59 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).