From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F287A04B6; Tue, 12 Nov 2019 16:30:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B0EB2B9D; Tue, 12 Nov 2019 16:30:19 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10064.outbound.protection.outlook.com [40.107.1.64]) by dpdk.org (Postfix) with ESMTP id E94F22B9D; Tue, 12 Nov 2019 16:30:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P3WbC2OQtH5RuOk5R02qWfb69GMBcMobY6GWCauBOFz/SxkGY4MF0KNHpZD+VBhUE/4C4WuVdPSxcy6ZZekGNjb3Cemnfba+FZOZn2gFmPOqq/Y7PbhRCjiW+mgMm3eYLpdG1ZDk/Cn16IQHAhWN7Wfu/MOlqJ0kc18VUXXqvuh9ulm+x5fDknTC1TWmg5fimjrraZf2hSuaVBdV7Ym/WO51aS9EphMk6JKsK0wpqTw2j0Ss3rB+Grl1xhiNuUXxBAivkiHy7mOk0jXTCrmVqKHcJUiFMVMy3h0592da0AvkQa34W3HjCrvgBCy17pgQPLG9nmc3vhivdvh0jB5qcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6DT6r8IXASmuXSMy4qZ0BeopshISB7gzvjVqM4is1Ww=; b=ntzh95bUMJxLonU2jmuNpazcTh0NFWlf/kLBQpK3xZFFk2qs6ArsnTC0zM4BZUFaFLS7DTWyBpFaLgi7/YJ4QiDn+ptFslGZVnHe06Fa5/a5m5Lp10CX+ucqEj+gvRjG2u7vph4biw63tVvm98iZ0SZXde0iENu4fsuXr7Cc7N2/rjuhWkFMUJ2KEL9uqLzdostiDnxIDG/DUs4NZ/l5CK57tDdPEU5JBvqHLbZddgUee0UPnvZVW7A3eKhkix4HjVGlPueCpTdpAdIeaEMRflz26xCqbJH4WaHbgbWE5cz/bTo0TPDyewjzZl8Z5OGgYoBLhTLQ3k7yz59B3f+U9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6DT6r8IXASmuXSMy4qZ0BeopshISB7gzvjVqM4is1Ww=; b=FF9445pOL4WzX/LFOoJg2Gsnp6oXumntZ2zTATTOpgwBuHxZtinoi3BgyEGk1hGq9xTOQk7/GaGGEiTNezwGnxCx/pSqI/+hfiIAfui2pys81BzHtmE+AVUALclOrD2Ie+sbhOFfXbkASlG3EJH42zO6JG+kSVQNqoX17IG/VD8= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB3994.eurprd05.prod.outlook.com (52.134.67.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.24; Tue, 12 Nov 2019 15:30:16 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2430.027; Tue, 12 Nov 2019 15:30:16 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix RSS action validation of queue idx Thread-Index: AQHVmJzqR5lcDnZmbkSaWkwdiOyjh6eHqtpg Date: Tue, 12 Nov 2019 15:30:16 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 281b9bde-2063-4048-b0d9-08d767853809 x-ms-traffictypediagnostic: DB3PR0502MB3994:|DB3PR0502MB3994: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 021975AE46 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(13464003)(199004)(189003)(64756008)(66476007)(305945005)(14454004)(71190400001)(110136005)(99286004)(486006)(71200400001)(5660300002)(11346002)(76116006)(66946007)(54906003)(81166006)(81156014)(316002)(446003)(6636002)(7736002)(66446008)(14444005)(52536014)(256004)(186003)(8676002)(66556008)(74316002)(76176011)(7696005)(102836004)(26005)(476003)(6506007)(53546011)(66066001)(450100002)(33656002)(6436002)(9686003)(3846002)(229853002)(4326008)(55016002)(6246003)(2906002)(6116002)(8936002)(25786009)(86362001)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3994; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a4yrHITZRDOtHnjYnF3qQhipMDK9Pch9/jZPckVSom3uPUui7oTRhsiH2E38aEIjviR5BQTICFEWsDUmd40xVbm0m/yrF2x2ujGJxWkMOSstoELDwStCEsbIGB45a+K4cHuovJz5YXdaOC4VbRU9Lz5D0izHYm1TOMUkMy8jiNG2K7xnycOWSEkPEj+WcOewhkD4ySsdHBapbqR2XjnszKoTP71YOqYmhSJkNVKdisu35zxQJJuOzlAZC0lXKGAJwnfd/g+a8/q29rIlaQUfOLWTGbSPN/74avPGaF7dmxZX3kj+ET1Qyif25XLkaRCaROZtnzX8ivDE8TveTsK6hVD1kT/79H9BqvhX41Bn9N+aTqtqkMxYMMDCkLfa4mGTi1pre9XIm8kx1Nz1TNtF6/YRRX5ccLt7fpAzW/2CpMR4oor6J9rpPJUSdajyWIST Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 281b9bde-2063-4048-b0d9-08d767853809 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2019 15:30:16.3465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f+6ZKM1C0PZPAS3oBDSGMSmiLjgOS1S/fBAvzsH9irQpc4OUysgx7Xcw8Gawy4H5NpSdTgc2ZBAO8crD/uslYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3994 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS action validation of queue idx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Monday, November 11, 2019 4:33 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: Ori Kam ; dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS action validation of queue = idx >=20 > RSS action validation function checks the queues included in RSS > to make sure they are valid. > A Queue is considered valid if the pointer to the queue (item at > location queue-index of RxQ array) is not a null value. > The queue indices are not checked. If a large value is entered as > queue index, using it as an index in RxQ array will result in a > pointer to memory out of array bounds. If this memory contains a > value which is not null, this queue will be wrongly considered valid. >=20 > This patch updates function mlx5_flow_validate_action_rss() with > check of the input queue indices, as done in function > mlx5_flow_validate_action_queue(). >=20 > Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated functi= on") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh