From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68BD3A046B for ; Wed, 24 Jul 2019 09:54:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40A6A1C136; Wed, 24 Jul 2019 09:54:08 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70054.outbound.protection.outlook.com [40.107.7.54]) by dpdk.org (Postfix) with ESMTP id 2D2231C133 for ; Wed, 24 Jul 2019 09:54:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a9Y9M/456GKIF606/QgIV9Rg4dO/f42/CV5ziJJJWn1hriuNc741tFbCx240+HlEpNmGqSqNqgM59U+DOKbVE7ufiBmzGD/SpljARe/RSsRvPk40SqNs+pqpL6QRUWSYcjn7YHXcH7b3KBwCYYi0YemWvDTCm/pt9UqGrtszxtjsQti+L4vlwbzhK6SsMKIaIzjtm/832D7yTDpef8wXYT+oNXUQKk/TNP+tltVnEweZAQD43MF75B0BkzvZ5neC9lEm4+/iZpzZpUj4prnOzSHLn2Oe6Rw/ZkhdcirJvPmYG0D6EjXOjGtXIUSTdh3vvBZ9L8JzNhpOG8ZRk8Nkeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IbsICfFxGBDVfEsg5pnFc9eUa8zT/PWqZcQDmCfctKA=; b=cv/iJvQwLc7DI3I5wHOsBgza/AxRdwMVCchBHNPq0B9jAFcrk1vDJGDNK56yDJouJ8cVeRv4i6hBCPw+luFS12uDGMb/QZ6ywQ1aiLBvnmKxGAXyvtcWq6OSRvQsRZEqoCPmdOYjekvniCaQvAAynmxkDGfuRCUglfxD0b++gsglsmfDUFqUOpJUmcRk3FqC6adFEryQC6LwBPJVHnkZ4xj09VHKllvDvHH1Rrnrnky6RwiUqX5rBMXtq+IQb81JxVoPWovsFFdeVkSnDSX5d/Pxi5uQ9SlWc2N7Qia08A51vbSWHvTLspHi+rnLgykBQ6DKOcp5E3+rURPRqEJl0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IbsICfFxGBDVfEsg5pnFc9eUa8zT/PWqZcQDmCfctKA=; b=gzpgWV+tqeWatd/Cy8ZnqxdRDN+/sT3o3qzTl34u2d2Mbg68inNYuYIWKv6aEeX8iyLJMkccIyeO8P2P40wfGPF0QtvxtLP9cbx4R99YRhQ+m0uDrMW5nINsPMCWtqIz7VBQHXd9ntmABtjrRGhcEGB/oIq0y51YXKhJiQQSTMI= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4011.eurprd05.prod.outlook.com (52.134.68.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Wed, 24 Jul 2019 07:54:06 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360%7]) with mapi id 15.20.2094.013; Wed, 24 Jul 2019 07:54:05 +0000 From: Raslan Darawsheh To: Dekel Peled , Yongseok Koh , Slava Ovsiienko , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix doorbell release on Rx queue release Thread-Index: AQHVQWbV1i7PPhAUn0qqxE33I8G/oKbZZwjQ Date: Wed, 24 Jul 2019 07:54:05 +0000 Message-ID: References: <5e8f2b2e164caab06b4310629769c198ba9dc0d7.1563893499.git.dekelp@mellanox.com> In-Reply-To: <5e8f2b2e164caab06b4310629769c198ba9dc0d7.1563893499.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 451731f2-3029-453f-d874-08d7100c1a18 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4011; x-ms-traffictypediagnostic: DB3PR0502MB4011: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(39860400002)(346002)(366004)(396003)(13464003)(199004)(189003)(76176011)(14454004)(71200400001)(86362001)(55016002)(7696005)(66946007)(64756008)(66476007)(486006)(9686003)(25786009)(52536014)(66446008)(66556008)(74316002)(71190400001)(76116006)(99286004)(6436002)(6636002)(53936002)(33656002)(102836004)(26005)(53546011)(4326008)(6506007)(476003)(446003)(110136005)(81166006)(305945005)(6116002)(3846002)(11346002)(478600001)(186003)(256004)(2906002)(316002)(7736002)(66066001)(68736007)(8936002)(6246003)(54906003)(229853002)(81156014)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4011; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: fmEEQbx3zoQDBYfsuIk3pFaVZThzSuiTQYappzaPUQbaMJe4mk+ICgTDD6Dg0LN76kD+72wfW8V+2AzbfiENJcwAkWbipFZ3tK6eRZ/3f8SZrFFxcW4J96njFuaVyqNTqxubE6Dj4uz9cqaojj5Au8/qaJmEPwTzaIXBz3sJSCVcSZDUfV3T1iyhQwCbSoOzeaL140zaWAtetwo43VpKLpMCKbijGzQ/6jqAtGIgv3hQhIBM+hMxW0rrLHEIGgPZ+wPQ+ZaeAJt+2nRC7EExOp1R0R1q8SmXaUQShw9CYHJPUy3aMtF/+rtlviSjjkkYfz7FJJvVOwZ7mRxkQeLPo879PCbZsEGe33eiUz9MYtYs/i93XNBI+J2zqQPlG4W/evqPwou3kdhrpqatvnSg8ok+881PiNtq7w8TsqJQrtM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 451731f2-3029-453f-d874-08d7100c1a18 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 07:54:05.8103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4011 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix doorbell release on Rx queue release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dekel, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, July 23, 2019 5:55 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix doorbell release on Rx queue > release >=20 > Function mlx5_rxq_release() calls mlx5_release_dbr() to release the > doorbell allocated for this Rx queue. > This call is relevant only for Rx queue objects created using > DevX API. >=20 > This patch adds the required check, to call mlx5_release_dbr() > only when relevant. > It also updates mlx5_release_dbr() to use the input offset correctly. >=20 > Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API") > Wrong 'Fixes' reference: Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API") =20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5.c | 1 + > drivers/net/mlx5/mlx5_rxq.c | 6 ++++-- > drivers/net/mlx5/mlx5_rxtx.h | 1 + > 3 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 973c80a..8f9693c 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1460,6 +1460,7 @@ struct mlx5_dev_spawn_data { > rte_free(page); > } else { > /* Mark in bitmap that this door-bell is not in use. */ > + offset /=3D MLX5_DBR_SIZE; > int i =3D offset / 64; > int j =3D offset % 64; >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index b225055..c9df8b0 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1242,6 +1242,7 @@ struct mlx5_rxq_obj * > goto error; > rxq_ctrl->dbr_offset =3D dbr_offset; > rxq_ctrl->dbr_umem_id =3D dbr_page->umem->umem_id; > + rxq_ctrl->dbr_umem_id_valid =3D 1; > rxq_data->rq_db =3D (uint32_t *)((uintptr_t)dbr_page->dbrs + > (uintptr_t)rxq_ctrl->dbr_offset); > } > @@ -1829,8 +1830,9 @@ struct mlx5_rxq_ctrl * > if (rxq_ctrl->obj && !mlx5_rxq_obj_release(rxq_ctrl->obj)) > rxq_ctrl->obj =3D NULL; > if (rte_atomic32_dec_and_test(&rxq_ctrl->refcnt)) { > - claim_zero(mlx5_release_dbr(dev, rxq_ctrl->dbr_umem_id, > - rxq_ctrl->dbr_offset)); > + if (rxq_ctrl->dbr_umem_id_valid) > + claim_zero(mlx5_release_dbr(dev, rxq_ctrl- > >dbr_umem_id, > + rxq_ctrl->dbr_offset)); > mlx5_mr_btree_free(&rxq_ctrl->rxq.mr_ctrl.cache_bh); > LIST_REMOVE(rxq_ctrl, next); > rte_free(rxq_ctrl); > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > index 928d6c3..60d871c 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.h > +++ b/drivers/net/mlx5/mlx5_rxtx.h > @@ -184,6 +184,7 @@ struct mlx5_rxq_ctrl { > struct mlx5_priv *priv; /* Back pointer to private data. */ > unsigned int socket; /* CPU socket ID for allocations. */ > unsigned int irq:1; /* Whether IRQ is enabled. */ > + unsigned int dbr_umem_id_valid:1; /* dbr_umem_id holds a valid > value. */ > uint32_t flow_mark_n; /* Number of Mark/Flag flows using this > Queue. */ > uint32_t flow_tunnels_n[MLX5_FLOW_TUNNEL]; /* Tunnels > counters. */ > uint32_t wqn; /* WQ number. */ > -- > 1.8.3.1 Kindest regards, Raslan Darawsheh