From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18933A046B for ; Wed, 24 Jul 2019 13:26:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC1111C1C0; Wed, 24 Jul 2019 13:26:01 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50081.outbound.protection.outlook.com [40.107.5.81]) by dpdk.org (Postfix) with ESMTP id 90F7E1C1BA for ; Wed, 24 Jul 2019 13:26:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OOIU2KXY032g8Hse/LIZ48Dzo24IE2JYUYh+aEIbA1U3vb61jEwJWbiU0e9opqDc5Jh7GrstTdSCdPnSLazn2EWWP2OxjluueWDFj19tdcUOpPWoluakSCEu9Q4qYHxpgueDAc6IksaE/3Hl5siPvObn5pUBF3H3MQ1kx5HvrabLNsQaT/HzzumkceTCs2es+8xvkEmichR8LRkoPmT2BLLuvnfHytTB6QZum7DUsLbwxTQ2tWoTxg2Y0TtK5hHuhEeidUqrUgPy4mut3q8V+PPEuZcpVs8PTXXgTjUOvyTw20tX6ebDplDWrCjgSkjYwpwTn3v0VJ6uRVpNO+fvRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s8r0ySoAWwdfNLNXpSnySzP//YQqYQ/gzIbo67Kz3hw=; b=eSXehxFxqQkP+eQyC1CdB2/JOsl8kIOYtagQQkIsr0mjMrYrsgKnyb3fHRmDSEPc4Scnny6u3AdnRx4Q0mPFTgc2G9oLd4NZ6RrMxWD9bcJE4rQTwXAsf0Q4mke6OZMgtj8EZ3ZUa/yQLTWxb0RyQG8k0r8R1gdpe7PzAvxI1v1OFxWWZqdwYznq9uDOEaNWz2q0obeH8Siz12778oVmRpUZhSVqh3eLgO20JcSfb70T3kM0OEdCqyHoDh8o205fCW7nVJw2cYRSj0CfTNPpML2eLgQx0rRc9MuWDJItYN7r3bkW4EraImJqiNGInG/95iGH0paZY08Gba4hcxF1Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s8r0ySoAWwdfNLNXpSnySzP//YQqYQ/gzIbo67Kz3hw=; b=lo5CZ7l1/wSVzvCsD2MNihFC/8m4lZXIr8W3XralGQaTy0JOnJ0jpY2sLxZQOAKmgSuoPLK0FrxUG+koQtk+5CuQr3TA5Tw0ddw725FIEygu9aWdgW4UGBL1nwSvKK2nlNXH+XuooygacvK9DGzyNbd/M/v8vl1SR5fGxYGUBP0= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB3995.eurprd05.prod.outlook.com (52.134.72.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Wed, 24 Jul 2019 11:25:55 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360%7]) with mapi id 15.20.2094.013; Wed, 24 Jul 2019 11:25:55 +0000 From: Raslan Darawsheh To: Dekel Peled , Yongseok Koh , Slava Ovsiienko , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources Thread-Index: AQHVQf78M+FK8fYWo0q4lCU603DaxabZoP5w Date: Wed, 24 Jul 2019 11:25:55 +0000 Message-ID: References: <657215c5e0635b452d5245cd0bfbdcf8315baf6a.1563958238.git.dekelp@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6e4950fd-c6cb-4ffa-59a9-08d71029b166 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3995; x-ms-traffictypediagnostic: DB3PR0502MB3995: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(346002)(376002)(366004)(136003)(13464003)(189003)(199004)(74316002)(14444005)(7736002)(86362001)(2906002)(3846002)(52536014)(66946007)(305945005)(6506007)(66556008)(53546011)(14454004)(102836004)(68736007)(66476007)(6246003)(486006)(99286004)(76116006)(66446008)(6116002)(256004)(5660300002)(66066001)(9686003)(55016002)(316002)(7696005)(8676002)(76176011)(33656002)(6436002)(53936002)(478600001)(446003)(476003)(6636002)(229853002)(4326008)(71200400001)(71190400001)(11346002)(186003)(81166006)(81156014)(64756008)(8936002)(54906003)(25786009)(26005)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3995; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: W7WMzKXzWkrgywSB8ckD8itLgD6UKqzevk50GKPk6sAuvQuCvIWHcERIceaMjDqCjVfX7wl45XhNajG71S02j6jii24f9dgVZWyJanc36HD1pqUJo369bez/0dCxJbMrjOFN0O+Havno/IrUU09OeCL8CqAm8Rt6tYn72K2GfVO7vFXJY6u96+9zGKmIJALwHs8OoQGEEx6U6Zo491H7xj8ZXnGK1KPNQ5ZBuCu2exIJPomSItF8wlFQfItQ1oCfIkTSmmVrya+blTF/65yNmj4s9W6i9Y4jZN0+nW+Y/MH66HNWP7pFEnQcExF6RElnTYLoEB1TxUNxcTImcX5EfZleeWIqLrnj+uY0MsAnUuH8YU6bNMJVSWACkxOvFyDz9iyEi7ei+2brqvkSZcUgSDxlHSuqk7+QeJI5/g90hIc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e4950fd-c6cb-4ffa-59a9-08d71029b166 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 11:25:55.1123 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3995 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, July 24, 2019 12:05 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resource= s >=20 > Function rxq_release_rq_resources() releases resources of RQ object > created by DevX API. >=20 > This patch updates this function to properly clear the released resources= , to > avoid repeated release of the same resource. >=20 > Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API") >=20 > --- > v3: Use adequate 'Fixes' reference. > --- >=20 > Signed-off-by: Dekel Peled > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index c9df8b0..441f158 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -573,8 +573,10 @@ > rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes); > rxq_ctrl->rxq.wqes =3D NULL; > } > - if (rxq_ctrl->wq_umem) > + if (rxq_ctrl->wq_umem) { > mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem); > + rxq_ctrl->wq_umem =3D NULL; > + } > } >=20 > /** > -- > 1.8.3.1 Patch applied to dpdk-next-net-mlx, Kindest regards, Raslan Darawsheh