From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1E66A04C0; Wed, 13 Nov 2019 10:37:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA3A91BF12; Wed, 13 Nov 2019 10:37:13 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80078.outbound.protection.outlook.com [40.107.8.78]) by dpdk.org (Postfix) with ESMTP id 4F27B1BF0D for ; Wed, 13 Nov 2019 10:37:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XDMx3Djblic9MOYeEs7UnMXYINPhsZ/m9DBgzD2VnQIJJS6h89ezeyJKqC5hsMahheWs2JW/zlFTrvgsVhwpisqG5/6fl1JVYssCzyjKYpg/0Xwv0SRColS792N5qif/agb3c/x452U1lFxDjRww7JLgUQZnigg6lTc4Gh87ixDSHuoBiGxVHbaFIvxyzmtrK/AUKMvTtYfMT6JK+3pGCI3iUgp7mcs5Cw49KFOHs83u3OChqVZ4xaCd3s/8NB1ELBX2vWGZ/A9Ye6GPIvZnjWG85opZwF0jks1dd38oIwyStqVTwU9wbRyh2qy60Ro/ZFf4UKIWeqg9AsglLLDXoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+tnYIIrMmAWH5nPD6PFOYpEqWllp2+9OebfFy1nDCgc=; b=K/Nn6ng9Z3yT9D/S+70Tl1/vwxzXCeuQl5hfjDrA+9bIlihKnnQCoNx+HqroT2YGZrnAPWe+8xTApFMAZJrZx70+4VeFL/qNDs88Jsn+h4jwBn4mG0058jvuj/ze2LMJ34eFEYDm3KN1y/9gY6KeVKP/82z7bMaYXCwfNyZ5mhSsbly7OyetOhTzyzj8wquNF3zXnBvF3ctlx7fmynDIsP9rt50LVsJgthPRJt63ljfRQOnPg+KLQR4YMRJyMVi//ArBVtCMCzA1CEI/b5q1H3f91c46r2dQyfHHy8psM1LhbKMq2C1ihHJjIOGrAdWo4GWsbKHuALhGPkbS9mHL8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+tnYIIrMmAWH5nPD6PFOYpEqWllp2+9OebfFy1nDCgc=; b=QOY7+3cGaKHypVXbJE4cqB4OinRP2YQhqbKJCeF6yhDVX4QKI6RXO4kkS3tgZv0ZX/jL4zfOvKylY/wSts6aWoIx25mlLr1mVurZTRVmanCsxXpGuuMBFU5PVAzk9b3R4KWRvz2KeqjyNXpXCX1PWDxxgjFIHS5nEI+D24GGsQU= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4044.eurprd05.prod.outlook.com (52.134.72.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Wed, 13 Nov 2019 09:37:12 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2430.027; Wed, 13 Nov 2019 09:37:12 +0000 From: Raslan Darawsheh To: Matan Azrad , "dev@dpdk.org" CC: Slava Ovsiienko , Dekel Peled , Slava Ovsiienko Thread-Topic: [dpdk-dev] [PATCH v2] net/mlx5: revert default rules amount optimization Thread-Index: AQHVmaSX96khjGU9MUihwR7ExtxtoKeI2Gfg Date: Wed, 13 Nov 2019 09:37:12 +0000 Message-ID: References: <1573595231-7992-1-git-send-email-matan@mellanox.com> <1573596010-9467-1-git-send-email-matan@mellanox.com> In-Reply-To: <1573596010-9467-1-git-send-email-matan@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f5ee80bb-4ba4-4d59-3e2a-08d7681d0fe2 x-ms-traffictypediagnostic: DB3PR0502MB4044:|DB3PR0502MB4044: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:284; x-forefront-prvs: 0220D4B98D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(136003)(39860400002)(346002)(396003)(13464003)(189003)(199004)(54906003)(107886003)(6246003)(14454004)(76176011)(256004)(14444005)(71200400001)(6436002)(33656002)(71190400001)(52536014)(7696005)(229853002)(486006)(4326008)(55016002)(9686003)(5660300002)(74316002)(66946007)(66556008)(446003)(66476007)(64756008)(7736002)(76116006)(66446008)(476003)(8936002)(2906002)(2501003)(25786009)(86362001)(305945005)(53546011)(316002)(81156014)(26005)(66066001)(6506007)(478600001)(110136005)(6116002)(102836004)(81166006)(11346002)(3846002)(186003)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4044; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zGYTVyyNL5J19Ykjvg0PxpSQalPOkERROYOUPswn9w3Wfi4QdEUFHnlm5VQSh+5ypf3LAY+e53oYre1I8RcD0ZAtUD0DMeyDNucUh0HFhSwHQV5FA0tzOqxHB/symXJnZFGAoZTI8tkVoKy8q+Wc3Z2faq0E37NjindAp3OCkM8QjfbqtilR7j1sdSabmdlY29/KN5IBF+3u/Bs+TtD2jU4OyEpQqkBkR4Vl2NJtusrEXfRj9HMyrRcRn+wjS2m1C4TzUPqiUFKs5VWjyNc+FIqI1EOriAv+neB5wfM+DqkmQUtXS0UajzpKKQ0+eBlbzyMO6rV8+jFodq6G5bu4PM/t7utkZIjiNR/YJuyHsslBC426+91P7Hh3z4AtSzneJwncuCY+FTGWf3ScLVbAr5kz2Dx8nkAt5b/NEs0TBwHLfIQU+qJ+j+UoJXrjakwJ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5ee80bb-4ba4-4d59-3e2a-08d7681d0fe2 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2019 09:37:12.4820 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /sh4iebT2bZKP42BkRgRmVKEK4MoBifDwAmBNQlh4NacoG+DE7D4uYpE/2/zo2U4lsbh5KP8o9qdaCERW1M7lQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4044 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: revert default rules amount optimization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Matan Azrad > Sent: Wednesday, November 13, 2019 12:00 AM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Dekel Peled > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: revert default rules amount > optimization >=20 > This reverts commit 304ffe576f239e5405228c0feec04b6138d525b7. >=20 > It tried to optimize the amount of the default flow rules and created it = only > once on top of the PF representor. >=20 > For each FDB rule, the default port ID to match on is like of the port th= at > triggers the flow. >=20 > Hence, the single default rule will not be matched on the VF traffic. >=20 > As a result, all the traffic of the VFs will not match to the jump flow i= n the > root table and will always be forwarded to the representor port. >=20 > Revert the commit. >=20 > Fixes: 304ffe576f23 ("net/mlx5: fix condition to create default rule") > Cc: dekelp@mellanox.com >=20 > Signed-off-by: Matan Azrad > --- >=20 > V2: > Fix missing signed-off. >=20 > drivers/net/mlx5/mlx5_trigger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh