From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 141A9A0613 for ; Sun, 4 Aug 2019 12:53:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DEA6B1BEA4; Sun, 4 Aug 2019 12:53:49 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80048.outbound.protection.outlook.com [40.107.8.48]) by dpdk.org (Postfix) with ESMTP id 52EF61BEA1 for ; Sun, 4 Aug 2019 12:53:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L/ihbHsHgAiOQkIerkAZwuKkDQnIw8KfgumT/ceEGAqhUtCU+q4TrWe0wN3OWsMupKoIu5tcnDUvo7hKIF30AoJscArZiG2tT/5mIqix5VhpzjC9bdqaPAXTmEyXIWdXl33yPFeEPLnMqu/7kCcPVEoRKyesHyR6lZ8RqaaoCjLAiXcKS4sdGFlurKZSbJC4qjDsCyfISS4kXaoRu5RphaKrA0sJfVztVTQAq11aBuQ6q+4ZD+VceEuJS51pIAAYz2MukJvDysCWXKdQM5rbqfUl7NsCI3U0qsx77G4QwMSjBh2bmRC8w9tAlCtSGk4uM6YRbbvWB9w+XdgK3yUvLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z8IfdvsHRMGymyL2yUfcMaNxw9PejVlgmzLMfL/aRJU=; b=IbKYJXrFTAjkC+bbgVl5p52WAGzOaMdTxXrisexsk4fD67FbMBRKqcFkZTgD7PdgH1TsYM9+tjK57xogXtxzP/bOCb5XnovSICiOw+JaII4XZjkmK0kL+iPmRyxXP5giwRYEek6mRMt3mB5YN6jbzl1vYogXsDHeAwjqYtVXIrGapLRk7ZLxTUerQTQniQTQqToYWNtkIpv1IvS72NGHh9zsM11sZDKlhB0DMBFXVjW+XaPGe+KVnytYGY3es0/ZWIMQhiAlGoqdmoCrC7nsNE5KEgjz7vSgCbipRyxmgy9hVObAxZYqkA9GzEGa7NQUVxoyUVcSQ6dXciYZ0RbIHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z8IfdvsHRMGymyL2yUfcMaNxw9PejVlgmzLMfL/aRJU=; b=Ei3wxGmgNVSX40xluAW457lEklv5OFxNa3pYWOvoJLCeK173P0G94g9P/QyhzHrtQNCdXR8xNKFX9YmLnWllHo4alv4q0j5ld2U2JjA6jRruFM6O6s7HtnZTQi4jVsb5aGQK/kdrh4pE16UH+c07zF8M49sza8aBazTclPqikX8= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4059.eurprd05.prod.outlook.com (52.134.66.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Sun, 4 Aug 2019 10:53:46 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3%5]) with mapi id 15.20.2136.018; Sun, 4 Aug 2019 10:53:46 +0000 From: Raslan Darawsheh To: David Christensen , Slava Ovsiienko CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters Thread-Index: AQHVR/EdrGyIXYL3ikKHnc4t3pTfyKbqzopw Date: Sun, 4 Aug 2019 10:53:46 +0000 Message-ID: References: <1564612871-162495-1-git-send-email-drc@linux.vnet.ibm.com> In-Reply-To: <1564612871-162495-1-git-send-email-drc@linux.vnet.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dd2b7df5-ffc6-4729-b4e7-08d718ca0672 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4059; x-ms-traffictypediagnostic: DB3PR0502MB4059: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 0119DC3B5E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(13464003)(199004)(189003)(102836004)(53546011)(66066001)(14444005)(74316002)(6506007)(6636002)(7736002)(53936002)(305945005)(478600001)(486006)(476003)(7696005)(5660300002)(4326008)(446003)(11346002)(76176011)(6246003)(256004)(99286004)(6436002)(110136005)(9686003)(52536014)(66476007)(2906002)(81166006)(64756008)(68736007)(66946007)(71200400001)(81156014)(66556008)(66446008)(71190400001)(14454004)(86362001)(26005)(33656002)(316002)(229853002)(3846002)(6116002)(8936002)(76116006)(186003)(55016002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4059; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +D3efvXimfWrox+LPn8hF20AA3nXmW2reMY3OQNtJfuNVaNjuHG0pUUn2Qx4ytjX/SPcBQhf/vSR7wy/aTRuLqCkPwnoKedp6dq0tBRfDBRq+ystN65zgs39EVDSvcv1roRRZRz/Sud6RlLdoIdErjHRNTm/IKfSwAco5P2CGbHc6ASBr65NEtg+ukPXW5vK7AOmzMOsAMkG1Mqe5PYQXXqBvdmVe0m7a48ZR2TIUeZp+rxcbGPgLnmzRiSMJlOMzuwnCUlrw9PEGVoRGVPu9ygff5+srJUSDKynif5jEnxCp91kMBe1KsamuGL9LVBAl9iRJrZI/Ji8xrq/HmVTOAXrGovGbnRULTq1HDuOakFs+zOyVJtWpmbY1vc5I5EZpvpG7CmVsFL7jKtlepXiJz4sUO8vpdfrFiRNXGP/n8I= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd2b7df5-ffc6-4729-b4e7-08d718ca0672 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2019 10:53:46.6505 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4059 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of David Christensen > Sent: Thursday, August 1, 2019 1:41 AM > To: Slava Ovsiienko > Cc: dev@dpdk.org; David Christensen > Subject: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX= - > 5 adapters >=20 > The function mlx5_set_min_inline() includes a switch() that checks > various PCI device IDs in order to set the txq_inline_min value. No > value is set when the PCI device ID matches the ConnectX-5 adapters, > resulting in an assert() failure later in the function > mlx5_set_txlimit_params(). >=20 > This error was encountered on an IBM Power 9 system running RHEL 7.6 > w/o Mellanox OFED installed. >=20 > Fixes: 38b4b397a57d ("net/mlx5: add Tx configuration and setup") > Cc: viacheslavo@mellanox.com >=20 > Signed-off-by: David Christensen > --- > drivers/net/mlx5/mlx5.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 3a345c7..0f61dd5 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1341,6 +1341,7 @@ struct mlx5_dev_spawn_data { > * and PFC control may be broken, so disable feature. > */ > config->hw_vlan_insert =3D 0; > + config->txq_inline_min =3D MLX5_INLINE_HSIZE_NONE; > break; > default: > config->txq_inline_min =3D MLX5_INLINE_HSIZE_NONE; > -- > 1.8.3.1 Patch applied to next-net-mlx after fixing the wrong headline format Kindest regards, Raslan Darawsheh