From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7DE5A046B for ; Wed, 24 Jul 2019 09:53:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A9751C12E; Wed, 24 Jul 2019 09:53:44 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75]) by dpdk.org (Postfix) with ESMTP id 658C71C12B for ; Wed, 24 Jul 2019 09:53:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N1l6ueU8wgu8u+bCl3pR1Jdd64R4MGN+DxMXvCfcBVBvylByacWxMiP23DyZZXIUBdSg+t5kYZgSNdm6NYKd8ZsvADGFAHAp61/Ul2IUSoPt0joKjfA5F49aEQr3k2YbTEwfYTYlyJe7T78yQGFg2s3vd4ToOjFo4RW/a2LqHGOAiudKisWRcI0/hJHdz/+NkIGHhE32ZocjR7803TQhp315CNTLjUxpr1tLF0+YF9wY6rTDEyLygQwJXUey7xGFMDMvGV9mQKJKGuuRE+XyxfEntvBn9VS4aQCxZVXHKXCtQLZ7Q5lPmmuJhSEVZjXxWt7rbMNc2yHJ2M+mJ4QNeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AEgbFeKIl9O4f52hjOr/DZ62SvzuCPpSb0CWpTOTdE0=; b=Z3T/1jkR40RsaXGuwP5ysC+X15WSBep5QI+f0VjswWuY6rzsecyxImeHhauLWbmP3MElN18ywApqUjO/DXkriRVjhY+cy3x+km3WdH9AUKhHtE8IEp3qJ/JgWvPz4nJpopqtAk9L8r+Tvv0HVPJ1IJSJljLRK+/g/zaZ3Jlj2W9k0S3r4OHA2jd49q0tqxct3gSYUKNLWi2igAu3OONqq1kKIdNuIg3afbqpr2koOYicTKT6QbZjvlAaZVDyIbuJv5hgsqZ7GZ1T7ayLNnvQZ9QjK/mnk9zKz7esRN8LcT7X2B6b8anQ8sLRmaakaJyWGYnVe6MpopiJwZqSSzO9Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AEgbFeKIl9O4f52hjOr/DZ62SvzuCPpSb0CWpTOTdE0=; b=HBExqfrr6FurZMCaWe0lYKYS8ZDG9t9raDZEm/NHU6xXkCSZ69cXXhxw0KWDc2Jw5seF0ylqbvPNJ0pgssggmDY7TclC8QYuCQqLPgjOuxGHtsUKZ9Jp0CMM35RTcNaHgHnI4qXUaDneNwxJkr64IYPJ03d360Ck95TGYZxwmoE= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4011.eurprd05.prod.outlook.com (52.134.68.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Wed, 24 Jul 2019 07:53:41 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360%7]) with mapi id 15.20.2094.013; Wed, 24 Jul 2019 07:53:41 +0000 From: Raslan Darawsheh To: Dekel Peled , Yongseok Koh , Slava Ovsiienko , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources Thread-Index: AQHVQWwygc0KTmTNM02hQSs0tDE3IqbZZn/w Date: Wed, 24 Jul 2019 07:53:40 +0000 Message-ID: References: <0bf488cf0466b23710a4cf2cd68943a3354de6ef.1563896047.git.dekelp@mellanox.com> In-Reply-To: <0bf488cf0466b23710a4cf2cd68943a3354de6ef.1563896047.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0031a16-e561-4dac-f123-08d7100c0b52 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4011; x-ms-traffictypediagnostic: DB3PR0502MB4011: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(39860400002)(346002)(366004)(396003)(13464003)(199004)(189003)(76176011)(14454004)(71200400001)(86362001)(55016002)(7696005)(66946007)(64756008)(66476007)(486006)(9686003)(25786009)(52536014)(66446008)(66556008)(74316002)(71190400001)(76116006)(99286004)(6436002)(6636002)(53936002)(33656002)(102836004)(26005)(53546011)(4326008)(6506007)(476003)(446003)(110136005)(8676002)(81166006)(305945005)(6116002)(3846002)(11346002)(478600001)(186003)(256004)(14444005)(2906002)(316002)(7736002)(66066001)(68736007)(8936002)(6246003)(54906003)(229853002)(81156014)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4011; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 2O/mxcUcgYQzcyYhlz+tQupQCTuZV1++IrUwFh0bT1DcyKqilj5LngQ4846YiTGn8SqISLjAYQxkf4CLJf0O8S+AUSm//OrHQ6+dZOQ8hWoBSiAuN5MtQNAAWpmnrAMNFsdp6D/TTNyOLdWKX+I674bqX5iCCcJMUyAt4vtwCe0FgO9EeH59NHrWQWinjbueenxcAFP6tcqtn7XxWSrZhHFUvyGpNKd6tjOgxsgL8Ozl4HuoibrmLunTCviNaKdBUxGikNV2pU+0bcIhKVKHv+kMv4Fh6Xk4+svtE1Bp+i3LmyQvmM4ddpMWqLZnSkHPZ3JdQUJRKZa894nFHgE42pmrznwPfppDaJVHFmoLlApv3xjwmBuY1Rv3fnsgAUQFlW5vkIEJZzTf+AwD3rCf/QvRGiuIDMrq8sV+2B/T0GQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0031a16-e561-4dac-f123-08d7100c0b52 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 07:53:40.9982 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4011 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dekel, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, July 23, 2019 6:35 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources >=20 > Function rxq_release_rq_resources() releases resources of RQ object > created by DevX API. >=20 > This patch updates this function to properly clear the released resources= , to > avoid repeated release of the same resource. >=20 > Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API") >=20 Wrong 'Fixes' reference: Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API") > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_rxq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index c9df8b0..441f158 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -573,8 +573,10 @@ > rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes); > rxq_ctrl->rxq.wqes =3D NULL; > } > - if (rxq_ctrl->wq_umem) > + if (rxq_ctrl->wq_umem) { > mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem); > + rxq_ctrl->wq_umem =3D NULL; > + } > } >=20 > /** > -- > 1.8.3.1 Kindest regards, Raslan Darawsheh