From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB0CEA00E6 for ; Mon, 5 Aug 2019 16:41:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB5F51BDEE; Mon, 5 Aug 2019 16:41:48 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60055.outbound.protection.outlook.com [40.107.6.55]) by dpdk.org (Postfix) with ESMTP id 223521BDE8 for ; Mon, 5 Aug 2019 16:41:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=itWp0+gTr7+7J4YtkOGkP5XzYpigr+TTiXYvVSRcw+Cq6n75SaZlxfJvCdkEcCRFJ248GVttlyfieSCOfob2kPz2g/TcVEJLNeKPWps73kPI7rh1ybL6WpKrG7DWv9G9EcQLNozRAEMsHFYyJISNwi84L6cP20h61o71QEnmv+6C5JNzBdqNycKDlgDDwZnZl3pandr+//foUJaOVK9CRBF7vMzGjDrALcDXip9t/vxLDvQdBPcOa9Dx8vT/30/6tSuGzH0eb+SerqlfuI2UntRLjU1eKNC3aO6D3/O/tY0OvsC7XYJC8Svl89iYX+2gCpMLPuae/wD+FHtWw3xPzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1oi3eDAuhR4FpaHGW6QJh7DVUYY6iNymW7NHloL6m6I=; b=YJQ3mfjQV4mTPcmeyVHRXRArjTG/BZOkUXB9Ow3kgXzkuFryGsWaTYXqEWBjB2zOOnjNfK/q64z5X6cqiOQ7b4g4UPuE8IVTN4IriHQEowqQWMrtC3tbHVDY0gEK4Hz2OuYCdTKAOt+SxagPNCHTQyXnZgiPKI3E+7fMnH0fzDhoRskkg72gx1sOJ0maCW/Vzc6XsPvoyFGdNNYRzwhzbPA/pEfFy+9nAC0MtXMg216yeSsjkknn5SN41ejg5f8YKpjs0UvJmd81/41WgMCghhx5ViRr2AFwVm1AnKLLMM1FMmUD/yL9lk1WD0VUQWnvDpAtCgxfyarR1Kdrl0++/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1oi3eDAuhR4FpaHGW6QJh7DVUYY6iNymW7NHloL6m6I=; b=YnkkBegy9unaf+ZdnnapDk4fwKHX8JlMiVzXNu5gYlBs3SFHtW+ycwZEqKSIeF71TKvfsUNzR78aU7qoXYOsPbeMOIx3vuOWTu+O7/hBePL+n79qYRr1j3h6iqq7uyJhfklGY3kZvJjVbcLNcJAjetcMydrlNRxWrzBkxniwWy0= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4057.eurprd05.prod.outlook.com (52.134.67.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Mon, 5 Aug 2019 14:41:46 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3%5]) with mapi id 15.20.2136.018; Mon, 5 Aug 2019 14:41:46 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Yongseok Koh , Matan Azrad Thread-Topic: [dpdk-dev] [PATCH v2 1/6] net/mlx5: fix default minimal data inline Thread-Index: AQHVS45L/PU+VmvrlkGT5ng29B+coKbsoIuQ Date: Mon, 5 Aug 2019 14:41:46 +0000 Message-ID: References: <1565010234-21769-1-git-send-email-viacheslavo@mellanox.com> <1565010234-21769-2-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1565010234-21769-2-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3472bbc8-f461-4c88-6803-08d719b30a94 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4057; x-ms-traffictypediagnostic: DB3PR0502MB4057: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(136003)(376002)(366004)(346002)(199004)(189003)(13464003)(71190400001)(2906002)(486006)(71200400001)(53936002)(316002)(25786009)(102836004)(76116006)(446003)(11346002)(256004)(53546011)(7696005)(99286004)(14444005)(6506007)(74316002)(54906003)(110136005)(76176011)(476003)(86362001)(107886003)(305945005)(3846002)(6116002)(52536014)(4326008)(5660300002)(6436002)(7736002)(186003)(81156014)(81166006)(26005)(2501003)(8676002)(14454004)(66556008)(64756008)(66446008)(33656002)(9686003)(55016002)(8936002)(6246003)(66066001)(66476007)(68736007)(478600001)(229853002)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4057; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: tXVk2JwnsmOZVWSs2TJaKqoqRBXCW+jEm3QRgpHuV+/MyuVzunxkzsChpAkjkrWQy6atP+iDkFlGkEkvApQKs0pP39Pa34PO5x3OrhOOZn147bibGNMo81NN9t2iSjyRF7ZUk8O7fTS8vwqhbrmMOXMG2uBOQP73xuj/2WQ90tG3t6r7xZ5wnJIAgiwyqcSuWXUWB7M7jBo0BsFx43egsC5RhxWCgLl8kirkusgZ4VlrIOBEph6to6xILFTeq2BOZ7NbW5hoZHm3eT0nhM/AdA14SsUoDTa8g0QEo0BMder/Dz4FCo27NxaHKyKJuKjfntF/+6DFoWILBgJ8c5pRSqllxbvOlhK9pLgeUWmacC8cByg2aFi9y+arMMNC3GrUeOblDI0c8nqz0n3CiIyl8jZtPxAORHD7oCxlgkDH0rY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3472bbc8-f461-4c88-6803-08d719b30a94 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2019 14:41:46.2273 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4057 Subject: Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: fix default minimal data inline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Monday, August 5, 2019 4:04 PM > To: dev@dpdk.org > Cc: Yongseok Koh ; Matan Azrad > > Subject: [dpdk-dev] [PATCH v2 1/6] net/mlx5: fix default minimal data inl= ine >=20 > The patch [Fixes] sets the default value of required minimal inline data = to 0 > bytes. On some configurations (depends on switchdev/legacy settings and > FW version/settings) the ConnectX-4LX NIC requires minimal 18 bytes of Tx > descriptor inline data to operate correctly. >=20 > Wrongly set to 0 default value may prevent NIC from operating with out-of= - > the-box settings, this patch reverts default value for ConnectX-4LX back = to 18 > bytes (inline L2). >=20 > Fixes: 9f350504bb32 ("net/mlx5: fix ConnectX-4LX minimal inline data limi= t") >=20 > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 909c22e..a3eacdb 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1325,12 +1325,9 @@ struct mlx5_dev_spawn_data { > switch (spawn->pci_dev->id.device_id) { > case PCI_DEVICE_ID_MELLANOX_CONNECTX4: > case PCI_DEVICE_ID_MELLANOX_CONNECTX4VF: > - config->txq_inline_min =3D MLX5_INLINE_HSIZE_L2; > - config->hw_vlan_insert =3D 0; > - break; > case PCI_DEVICE_ID_MELLANOX_CONNECTX4LX: > case PCI_DEVICE_ID_MELLANOX_CONNECTX4LXVF: > - config->txq_inline_min =3D MLX5_INLINE_HSIZE_NONE; > + config->txq_inline_min =3D MLX5_INLINE_HSIZE_L2; > config->hw_vlan_insert =3D 0; > break; > case PCI_DEVICE_ID_MELLANOX_CONNECTX5: > -- > 1.8.3.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh