From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35549A034E; Tue, 19 Nov 2019 16:59:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0515E2B87; Tue, 19 Nov 2019 16:59:23 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130084.outbound.protection.outlook.com [40.107.13.84]) by dpdk.org (Postfix) with ESMTP id 531CBB62 for ; Tue, 19 Nov 2019 16:59:21 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kqc6bciQgo8PAdm0kAh7/OGvukSKiBm5wvnEXTKEeo3ri5CL4g4VnggyQL8boA2HqUFfgC4IjmvdKAHUXNkGryXjMMPnvy7hxOl1oTDjwEKLETgwEPpcNnxN4FJuprepcUct1pqQAO8Gle/zg9rUdmWuLs5vHfHIS6tw0cZBVX5XnZOq0BIZQSCGva/BH/MML9ySJwngwumBaxlVoFCs5ZORlvc8uemMmyOgSB6N5jK5ZDOqt5Fig/N4Rq+AoFMJzZvrXe06wXZo8KW6wNEn5wGHu2cMj481Z/S+/R9gNLpLPSuR9B6jBl7tM0krhbhoNfCivP1pNJUFn/iAixO0bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IOSk/F/qFKEfkF14Ng5ZPEWbCS6LGuosR/vObW8LYFU=; b=CxmQcJyoYRWWH/L/h9OhQPGYFFKMVSr1uWOPfAEwG+mIH+iDrDNUJdFO6cYxwg0+hK702UJruMwaqhREfX0jGQ8hemkoB3Ytz8YfE/2hso1JqlejbeS26IogomPmr3aSh6c+J9ARcGnUSAFhWdw1LCpA2lB3DzONQgqQfefcrnrflv7fVGXVIGc4P48hpXZ/1PIt7x5a3RGm3TIpWGk5Mahdy4/vdWeRwkAvbdx1EHW0vCzODMPyN3zhLM1oZm+OuBY0ln23IeRafmC9jU3+CPSeBrRDyoUttoJjkXWjasJZiFrQwDUO3apSL8KYm4+vrvjeXlXwIDF4ZWRcbm24+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IOSk/F/qFKEfkF14Ng5ZPEWbCS6LGuosR/vObW8LYFU=; b=pUq2fHksWRHqt9ECmC9Dn8zAYFRfIy3mdJOTeGAZoDo6nxy5NXaaKKDgE18cavlhynRxRWCpWYHuk7Kt6uO7RwmxYXOpaSF9Lc8X0CpsrXHeaYUglYsXEdqZHRV/fDrLv+bqFoCLwfGzjsevsA8nMEWPrUueq6Cjz09niFOqvnM= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4010.eurprd05.prod.outlook.com (52.134.66.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Tue, 19 Nov 2019 15:59:20 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2451.031; Tue, 19 Nov 2019 15:59:20 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Ori Kam Thread-Topic: [PATCH] net/mlx5: fix assert in tx inline settings ajustment Thread-Index: AQHVntsdTZq4OHKlGEel1DEMC9NqtaeSptlg Date: Tue, 19 Nov 2019 15:59:20 +0000 Message-ID: References: <1574169189-872-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1574169189-872-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b50dca37-46cb-4ffa-1bf8-08d76d09704d x-ms-traffictypediagnostic: DB3PR0502MB4010:|DB3PR0502MB4010: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 022649CC2C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(346002)(39860400002)(136003)(396003)(13464003)(199004)(189003)(6116002)(3846002)(26005)(2906002)(186003)(6246003)(107886003)(5660300002)(6436002)(486006)(476003)(66946007)(66556008)(66446008)(64756008)(7736002)(305945005)(9686003)(66476007)(14454004)(71200400001)(55016002)(71190400001)(478600001)(52536014)(4326008)(11346002)(74316002)(446003)(25786009)(76176011)(7696005)(8676002)(86362001)(316002)(81166006)(33656002)(99286004)(81156014)(229853002)(110136005)(54906003)(76116006)(66066001)(256004)(53546011)(6506007)(102836004)(2501003)(8936002)(14444005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4010; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zWYhP79GlIkyNUnG89VMNibeA2aOq9TTtIBVYGlwM2wrLEw31K3rYb5ZNJil6V+iRH8hECpuOVOSNX4EpUFWL1cNM9m/4pdyC65dXNNsRtHCYV72cH2hLVSfNoh7LrXKzzSM3oR116aUnHtEOln0kaXmngURPTKgb1m1khk/IJpTmmopI74WqztxRljTFm+Z1erAmxNIjc0FTP/octMmMEmykG/8DrYV40BOasNSRyU+4aqRfpnii1/ftxf+r8W8boXEfu7RoF3CEnKe8SAznZD5cnRUCWF3pb/jGgwfJIkgSp6k5IA7evDk889I9GKOYu7NQMulTbNDkYN/D9Lw679VT7AFIvUKSRk3ntEmdlJRfUAgQir6adeK8p95pY2JwKlrtjDpsTHjVvdJSPHQGkISECHSRiazx15OR9BqmsTOuDk1+7F54TnFn7ZKj/AR Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b50dca37-46cb-4ffa-1bf8-08d76d09704d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2019 15:59:20.0580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HEX0LnHgppFIZOScdaCRDN2S8MgZzq4Bvnc2b5g+h5diHItRLgB4aLD7esxfyTznJhMGYl094WGKipBklUY+lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4010 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix assert in tx inline settings ajustment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Tuesday, November 19, 2019 3:13 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix assert in tx inline settings ajustment >=20 > Assert condition is fixed to not alert for the case when multi-packet wri= te is > not supported/engaged at all. >=20 > Fixes: b53cd86965a1 ("net/mlx5: adjust inline setting for large Tx queue > sizes") >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_txq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > index a0d6164..47b1de8 100644 > --- a/drivers/net/mlx5/mlx5_txq.c > +++ b/drivers/net/mlx5/mlx5_txq.c > @@ -1210,7 +1210,8 @@ struct mlx5_txq_obj * > assert(txq_ctrl->max_inline_data <=3D max_inline); > assert(txq_ctrl->txq.inlen_mode <=3D max_inline); > assert(txq_ctrl->txq.inlen_mode <=3D txq_ctrl->txq.inlen_send); > - assert(txq_ctrl->txq.inlen_mode <=3D txq_ctrl->txq.inlen_empw); > + assert(txq_ctrl->txq.inlen_mode <=3D txq_ctrl->txq.inlen_empw || > + !txq_ctrl->txq.inlen_empw); > return 0; > error: > rte_errno =3D ENOMEM; > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh