From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70ABBA00E6 for ; Mon, 5 Aug 2019 10:23:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E989F1BE2A; Mon, 5 Aug 2019 10:23:27 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130087.outbound.protection.outlook.com [40.107.13.87]) by dpdk.org (Postfix) with ESMTP id D8CAA1BE09; Mon, 5 Aug 2019 10:23:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jpX8Ms2DQ90rOyihXogSXLbHqf8Z/dGxoo25tmNfxFDntflO3DbgZXAm1iDspteiNR0NypUz65qm8862Aj+LqOKETZqt350ZN4gnE3zS0939JXh0AVyj/qa/JDjFixRlKtoQ9xwbiHtRnAFz6zu3Lb3NSjwaSgxcRxaSbjnPTLUx9xVGzD3E77Dq8LhWYOICESldRrF7qn9Rsy1jyMJGgcp669Fr7Kug7RZchJDLwq80j3MeVQ1vsEJyVGbtapthgTQE9eS6Ly5EuRQ+pLxRfTFSuZGZQ0aRUJRkXmx+CP5VZgmyV8Jy/doAfXaPn9dY5XwA9tR8MIPXRKvygdU5yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fk6Xdx9BE5olQ6slFkl7FnbBMAad6brVA6OEYT2nD+Q=; b=b9HT5qd4IhMtoj46Yg/uke8ld7kpfowbu9eOZNFV9nPLY7to1p8gMGBs0b1YOk8EuB3OVh3V4wGMVgFrWNyMn2zETZRp3SThJILMa10ehsy4ATpaOfeTTfpF76rDY5/gjr8a/QutXw/q2RmT9ZdQVTF7jqnh9+yGiCE8Y6QCCbDCf3tsBKqfbvqlLpQV7k8Cpa4Xyy0TUDRtLQC8eoiqY30+npjiqdl4JNh+2sb0foTpbrefzqUTBQ3uRM8MNu/Q+w7a0Y7iNZugO1o1M8OPCA2jfWBADquiITNQWsx3otSDJSeN4uyWVpRAppBipb12nXbdYgSapxi7tZxiEfOTiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fk6Xdx9BE5olQ6slFkl7FnbBMAad6brVA6OEYT2nD+Q=; b=dXUBUyt/LEIBubHZm+1Ns8GPuOZ5T+fvglaYXVM2Gp+eZjcsxPCDu2eg5CJcqu5GdwJmnh7OxaoX6D2qwXEDiHfI4tCf8LCWGgwwRvURvlvM8BvnkharRhweBofBJ7LCxtmC3QI0uyOQ7kuB/+P3uYh//tHfIzq9fVqPziSMPco= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB3993.eurprd05.prod.outlook.com (52.134.70.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Mon, 5 Aug 2019 08:23:24 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::b4f2:f531:d3ff:b7e3%5]) with mapi id 15.20.2136.018; Mon, 5 Aug 2019 08:23:24 +0000 From: Raslan Darawsheh To: Dekel Peled , Yongseok Koh , Slava Ovsiienko , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix validation of VLAN pcp item Thread-Index: AQHVRiB3mgzAR56qi0+5e/fXMqlj3qbsQaLQ Date: Mon, 5 Aug 2019 08:23:24 +0000 Message-ID: References: <8a12820a10a6d485a24fa224601ba0a487363ca6.1564413233.git.dekelp@mellanox.com> In-Reply-To: <8a12820a10a6d485a24fa224601ba0a487363ca6.1564413233.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e6d36143-ef8f-47e7-09ca-08d7197e2f71 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3993; x-ms-traffictypediagnostic: DB3PR0502MB3993: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:826; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(189003)(199004)(13464003)(25786009)(86362001)(476003)(5660300002)(305945005)(7736002)(52536014)(33656002)(81166006)(8676002)(81156014)(76116006)(66446008)(64756008)(66946007)(66476007)(66556008)(6116002)(3846002)(68736007)(8936002)(76176011)(6636002)(316002)(110136005)(54906003)(6506007)(53546011)(102836004)(53936002)(6246003)(9686003)(55016002)(71190400001)(71200400001)(229853002)(99286004)(7696005)(6436002)(14444005)(446003)(11346002)(4326008)(450100002)(66066001)(486006)(2906002)(186003)(256004)(14454004)(478600001)(74316002)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3993; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 9KW+m+kFAap9vGivKpFaVbrSjmtP/glm/xRver7mF+MW4l7mZVt90Bb2dFD7ZYl5s8pApNBftCbMKROvaq1UpzdWMdy4W6XLrh7n4CGDnmXy8cTOzbnYS3UN5LlyDcQJ1DdDcxrVdVuwZIkq+PHjFmXZqeZFOm22WIgWEOpgoigqoNt0seEyf3gZTQvHrmK9JIxEjmZUn1oyNXI3GDYseqTPj4Ox4nkN1bhDw8DFatV1dCuVla4nsiNBRyycj7MQ/w6d3NUWBxnLgyuj6z94udW2QuBXCm1zbUHGoIsOaeM54pZcUMvfoAB81W9dsyDtl95+CSACeR0JcDDDXqvbWbY41U0NNxw1BK6Fb2Rp+Rg+jz/qw6cGmO2A1AFRZJ2cpjTWQ0yqmfvxLYs8csf/MZ3/a1rOWGq3Xpv6OniJA24= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6d36143-ef8f-47e7-09ca-08d7197e2f71 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2019 08:23:24.7406 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3993 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix validation of VLAN pcp item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Monday, July 29, 2019 6:15 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix validation of VLAN pcp item >=20 > Function mlx5_flow_validate_item_vlan() validates the user setting is > supported by NIC, using a mask with TCI mask 0x0fff. > This check will reject a flow rule specifying a vlan pcp item. >=20 > This patch updates mlx5_flow_validate_item_vlan() to use mask 0xffff, so > flow rules with vlan pcp item are accepted. >=20 > Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated functi= on") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 3d2d5fc..ec25fde 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1218,8 +1218,8 @@ uint32_t mlx5_flow_adjust_priority(struct > rte_eth_dev *dev, int32_t priority, > const struct rte_flow_item_vlan *spec =3D item->spec; > const struct rte_flow_item_vlan *mask =3D item->mask; > const struct rte_flow_item_vlan nic_mask =3D { > - .tci =3D RTE_BE16(0x0fff), > - .inner_type =3D RTE_BE16(0xffff), > + .tci =3D RTE_BE16(UINT16_MAX), > + .inner_type =3D RTE_BE16(UINT16_MAX), > }; > uint16_t vlan_tag =3D 0; > const int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh