From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1961A04C3; Wed, 13 Nov 2019 13:39:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB4272BBE; Wed, 13 Nov 2019 13:39:32 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40041.outbound.protection.outlook.com [40.107.4.41]) by dpdk.org (Postfix) with ESMTP id 26CD391 for ; Wed, 13 Nov 2019 13:39:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iwN4qmraUx5ssoQxePZhrHtiZCB+Vb73gNDjlo907XNTsRGRyAva8P/ZD7vUCKrDG0TRqEMD8QhhGydOgOOUWKbbLtuRpRQePo8k7hYDi1VjVCszR/UTtVGfxRT/BMdewqAgG7en1Qu5CkvHmBFr2r1rXtGudc/pdaaIYMKbDtCYPfeAwUQS/gOr4GK4H7d5O/YOLeSQkdOMxw4+GhLDKaq8oGucYWt47zRSaRyz0NIP1pPep629oh0uuiBFwu+UHgtKJgfWuc1boUQ2WVJBUB757SaIBtekAww8XQa+cJAaR6O4NQejr7SsIn92B917IPZAbhmCl5KMgrqBAeOqFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+2MSbX1kbJVxLmi1iULOl759B3JHgmqqJENDcnXQYB4=; b=SqhQzr/lhAD1CptW+/W00rTVueF0rsBeh6al32jr/bTF9kgVvLXZcFveh3rtBUQu/IBm1Ei9Bukez5MfHISv6Au69ZUDWqMfxq/6t03ty5ANHlSu2ClI0j8TtRh/vuXJ9nHd50wmDJAd6aUagSkfIJZI5BVzQhIMI3QW/++weeBO0O/mN/UAFZpZgX3tf0st0ephpDToStIZ6bsMzmB5M7yWkMzF4mQaQyOFVpbtv5eK25FohmugDTYJuvT6iSgkRZNdE5Mi23bzcjm5JC4muuLKXd0dUZMSE4gFOQX7+U0fNmf7vjYKn0PRV7yFIlzj3t5/UuNug8OqR03qedXYVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+2MSbX1kbJVxLmi1iULOl759B3JHgmqqJENDcnXQYB4=; b=j1pqvIEUltNO4/CAXvNLYTHb0J32dVoyQmU6LbA5WUSGMybQ9NQUkaCmQ6zkT0MaOQ1EOyz88LxYu4HsJcZdfr/43u5fwE6mKAqzkFTLIy3ekcDVOg0huJB6c0Z62GiJFAdqW0UkDmCaR94/54rEf+GQaC+pnqro/Wi/F+yUxtE= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4089.eurprd05.prod.outlook.com (52.134.68.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.25; Wed, 13 Nov 2019 12:39:30 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2430.027; Wed, 13 Nov 2019 12:39:30 +0000 From: Raslan Darawsheh To: Jack Min , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" , Ori Kam Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix layer bits not unique Thread-Index: AQHVmgTy6qip1XYsKUSa/F7LFfdcJqeJCq7A Date: Wed, 13 Nov 2019 12:39:29 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5f8f6286-ea8c-44a1-9f13-08d768368720 x-ms-traffictypediagnostic: DB3PR0502MB4089:|DB3PR0502MB4089: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:404; x-forefront-prvs: 0220D4B98D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(376002)(396003)(39860400002)(346002)(13464003)(189003)(199004)(6636002)(25786009)(55016002)(26005)(66476007)(186003)(446003)(64756008)(86362001)(76176011)(102836004)(7696005)(76116006)(33656002)(99286004)(6506007)(53546011)(66946007)(4326008)(6436002)(305945005)(107886003)(6246003)(9686003)(7736002)(66556008)(14454004)(478600001)(74316002)(52536014)(486006)(5660300002)(3846002)(6116002)(229853002)(71200400001)(81166006)(81156014)(2906002)(66446008)(71190400001)(256004)(11346002)(8936002)(54906003)(316002)(110136005)(66066001)(8676002)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4089; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AUm2Sn47S3uorbMiwPKZG5+lq28H8OXQiVKNjMkE5Q2Zidy6YHyYceamuM4q6PIK/1E8T0Z/gFvnn5Z79hO24nO+wKdgIsnyDpklOcFotfU6U5zWeAVhITxeQUCBD49ajL52NvMlxpycuNu+8ZGxT/Yzb/CRCtN5QYeSqdJOcW0nw/fucNus+qybwKiEr27aWLjz22DAB5ApWx5BR6tB8HzJmq0SBfmJC9CPfkVy5X+n7rdEKFlL1ojx9sXx7M/MVdUIvxhWiGEEq/iwNDmzEEaJYZ9zZnzo8ka3DzlBse0AtU0B8G+DOCeX1NKyRO1cI7f9oOoXcUroiDMJEpOwaNqsq+k3p9dVMOSbxLzBk6M3vFevJ9sEfzBmFppLzI2sSPP/13Hjy9zWTPQZPHIOZEEiB5WhncnwZGAcgJhxd7tk0nVjDTt6QsVvzn8rMTq/ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f8f6286-ea8c-44a1-9f13-08d768368720 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2019 12:39:29.9160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EHQIK7foyRmKOap/yt1QY7U2DFShdBwTgP46lGJvPa0nQVua6T2B0Cd9WPWC9RVJRFNvyNbz+8oQHr4sI8Wqhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4089 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix layer bits not unique X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Xiaoyu Min > Sent: Wednesday, November 13, 2019 11:30 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam > Subject: [dpdk-dev] [PATCH] net/mlx5: fix layer bits not unique >=20 > The layer bits should be unique otherwise layer info will be > interpreted wrongly. >=20 > Fixes: 70d84dc797b7 ("net/mlx5: add internal tag item and action") > Cc: orika@mellanox.com >=20 > Fixes: 55deee1715f0 ("net/mlx5: extend flow mark support") > Cc: viacheslavo@mellanox.com >=20 > Signed-off-by: Xiaoyu Min > --- > drivers/net/mlx5/mlx5_flow.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h > index 998da61490..3fff5dd7da 100644 > --- a/drivers/net/mlx5/mlx5_flow.h > +++ b/drivers/net/mlx5/mlx5_flow.h > @@ -109,18 +109,18 @@ enum mlx5_feature_name { > #define MLX5_FLOW_ITEM_MARK (1u << 19) >=20 > /* Pattern MISC bits. */ > -#define MLX5_FLOW_LAYER_ICMP (1u << 19) > -#define MLX5_FLOW_LAYER_ICMP6 (1u << 20) > -#define MLX5_FLOW_LAYER_GRE_KEY (1u << 21) > +#define MLX5_FLOW_LAYER_ICMP (1u << 20) > +#define MLX5_FLOW_LAYER_ICMP6 (1u << 21) > +#define MLX5_FLOW_LAYER_GRE_KEY (1u << 22) >=20 > /* Pattern tunnel Layer bits (continued). */ > -#define MLX5_FLOW_LAYER_IPIP (1u << 21) > -#define MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 22) > -#define MLX5_FLOW_LAYER_NVGRE (1u << 23) > -#define MLX5_FLOW_LAYER_GENEVE (1u << 24) > +#define MLX5_FLOW_LAYER_IPIP (1u << 23) > +#define MLX5_FLOW_LAYER_IPV6_ENCAP (1u << 24) > +#define MLX5_FLOW_LAYER_NVGRE (1u << 25) > +#define MLX5_FLOW_LAYER_GENEVE (1u << 26) >=20 > /* Queue items. */ > -#define MLX5_FLOW_ITEM_TX_QUEUE (1u << 25) > +#define MLX5_FLOW_ITEM_TX_QUEUE (1u << 27) >=20 > /* Outer Masks. */ > #define MLX5_FLOW_LAYER_OUTER_L3 \ > -- > 2.24.0.rc0.3.g12a4aeaad8 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh