From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0064.outbound.protection.outlook.com [104.47.0.64]) by dpdk.org (Postfix) with ESMTP id 39AF3568A for ; Wed, 10 Feb 2016 15:52:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ezchip.onmicrosoft.com; s=selector1-ezchip-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VTO/KXGYgtbdrEj3tlm3pqf57gBeeYCVR6Isx6nZgw0=; b=JctnssAkO+5vHvEQ2QxNJQACCx86hSg5wOMiDEMl6thhf565iYWBRMmJ+a1J3ymSgx/jToJsTQPcUVOUnL5AkrRQ8hhMMlbwNDZD/+8s3clpEgZoZ1HfuWYqqole1WWMuWFrI6oDHACUsRTlalGJOHKb4TM/N/nvsAb20PXLOrU= Received: from DB5PR02MB1015.eurprd02.prod.outlook.com (10.162.162.21) by DB5PR02MB1016.eurprd02.prod.outlook.com (10.162.162.22) with Microsoft SMTP Server (TLS) id 15.1.403.16; Wed, 10 Feb 2016 14:52:15 +0000 Received: from DB5PR02MB1015.eurprd02.prod.outlook.com ([10.162.162.21]) by DB5PR02MB1015.eurprd02.prod.outlook.com ([10.162.162.21]) with mapi id 15.01.0403.017; Wed, 10 Feb 2016 14:52:15 +0000 From: Liming Sun To: Bruce Richardson Thread-Topic: [dpdk-dev] [PATCH v2 1/2] driver/net/mpipe: add rte_vect.h and enable CONFIG_RTE_LIBRTE_LPM Thread-Index: AQHRY1JftZr8pYv8WkGofkFD75uU958lXhHA Date: Wed, 10 Feb 2016 14:52:15 +0000 Message-ID: References: <1450813790-11874-3-git-send-email-lsun@ezchip.com> <1452263948-22485-1-git-send-email-lsun@ezchip.com> <20160209155550.GB7248@bricha3-MOBL3> In-Reply-To: <20160209155550.GB7248@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=ezchip.com; x-originating-ip: [12.216.194.146] x-microsoft-exchange-diagnostics: 1; DB5PR02MB1016; 5:I6MADJnd6znwFX+1y+FwXrLczi7Q3Su80CRIDU27j3dA9ZSxN1orTQiLXLoYuHJ088O9HF3k5nIst7CzmlyIGHLv2s3XLS4AF+sfxjL2HtP+Nv347xbbxmBa9dejNoOfFy2hoMT2B9M67REIzzHkxA==; 24:92r1z4d8Nf7DT0hcWZnV+9/3J1lzcTjLIKhYm/6Dm4+yNJdVxiQCPKWxXrARsZPlZGhaQuOtj1W54wbXvFQXOiN0t4k292tSVdKPf2m9Y14= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB1016; x-ms-office365-filtering-correlation-id: a23ab517-c0eb-49b6-589a-08d33229c40e x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:DB5PR02MB1016; BCL:0; PCL:0; RULEID:; SRVR:DB5PR02MB1016; x-forefront-prvs: 0848C1A6AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(13464003)(377454003)(122556002)(2906002)(4326007)(3280700002)(5008740100001)(54356999)(189998001)(5001960100002)(110136002)(3660700001)(11100500001)(10400500002)(5002640100001)(5003600100002)(102836003)(76576001)(1096002)(2900100001)(87936001)(2950100001)(15975445007)(77096005)(6116002)(3846002)(106116001)(586003)(1220700001)(92566002)(74316001)(86362001)(19580395003)(33656002)(5004730100002)(76176999)(50986999)(15395725005)(66066001)(40100003)(19580405001)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR02MB1016; H:DB5PR02MB1015.eurprd02.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2016 14:52:15.2131 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR02MB1016 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/2] driver/net/mpipe: add rte_vect.h and enable CONFIG_RTE_LIBRTE_LPM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2016 14:52:16 -0000 Thanks Bruce. I split the changes as suggested and resubmitted as below. http://dpdk.org/dev/patchwork/patch/10454/ http://dpdk.org/dev/patchwork/patch/10455/ - Liming -----Original Message----- From: Bruce Richardson [mailto:bruce.richardson@intel.com]=20 Sent: Tuesday, February 09, 2016 10:56 AM To: Liming Sun Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] driver/net/mpipe: add rte_vect.h and= enable CONFIG_RTE_LIBRTE_LPM On Fri, Jan 08, 2016 at 09:39:07AM -0500, Liming Sun wrote: > rte_vect.h was missing earlier thus LPM was disabled and l3fwd is not=20 > able to compile. This commit implements the vector api and enable LPM=20 > in the tilegx configuration by default. It also includes a minor=20 > optimization to use __insn_fetchadd4() instead of > rte_atomic32_xxx() in mpipe_dp_enter/mpipe_dp_exit to avoid the=20 > unnecessary memory fence. This looks like it should be two patches to me. One patch to add the missin= g dependency and get lpm to work. The second patch should then contain the = driver optimization. Do you agree? /Bruce PS: the commit title prefix for the first patch should probably be "eal/til= e" rather than mpipe, since it's not directly affecting the mpipe driver. >=20 > Signed-off-by: Liming Sun > Acked-by: Zhigang Lu > --- > config/defconfig_tile-tilegx-linuxapp-gcc | 2 +- > drivers/net/mpipe/mpipe_tilegx.c | 18 +++-- > lib/librte_eal/common/include/arch/tile/rte_vect.h | 93=20 > ++++++++++++++++++++++ > 3 files changed, 107 insertions(+), 6 deletions(-) create mode=20 > 100644 lib/librte_eal/common/include/arch/tile/rte_vect.h >=20 [snip] >+ mbuf->next =3D NULL; > =20 > PMD_DEBUG_RX("%s: RX mbuf %p, buffer %p, buf_addr %p, size %d\n", > mpipe_name(priv), mbuf, va, mbuf->buf_addr, size); diff --git=20 > a/lib/librte_eal/common/include/arch/tile/rte_vect.h=20 > b/lib/librte_eal/common/include/arch/tile/rte_vect.h > new file mode 100644 > index 0000000..32d768a > --- /dev/null > +++ b/lib/librte_eal/common/include/arch/tile/rte_vect.h > @@ -0,0 +1,93 @@ > +/* > + * BSD LICENSE > + * > + * Copyright (C) EZchip Semiconductor Ltd. 2015. Maybe update the copyright year? > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions [snip]