From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3on0058.outbound.protection.outlook.com [157.55.234.58]) by dpdk.org (Postfix) with ESMTP id A5A0937A6 for ; Wed, 10 Feb 2016 15:50:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ezchip.onmicrosoft.com; s=selector1-ezchip-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CTEQ/KFYNNI30UKB8ctttqM3rFW8fxFTN9UKcl99ug8=; b=g9fBgr8pZYWtxN1tT5gczotddh3Ixo27rnGkz7N5g5cwiQ0FMVz1FfrUZpf5BMpn+hTZl8Wg9VFLMoL74ulpqC7ehUPzCLrijt5opOU8rLkUMTwj46xtBVLB2CjSPOWdVTm8wDbKgkfo3VqIyW6UZ4C6TnuK6UUzAY9pewATG84= Received: from DB5PR02MB1015.eurprd02.prod.outlook.com (10.162.162.21) by DB5PR02MB1016.eurprd02.prod.outlook.com (10.162.162.22) with Microsoft SMTP Server (TLS) id 15.1.403.16; Wed, 10 Feb 2016 14:50:10 +0000 Received: from DB5PR02MB1015.eurprd02.prod.outlook.com ([10.162.162.21]) by DB5PR02MB1015.eurprd02.prod.outlook.com ([10.162.162.21]) with mapi id 15.01.0403.017; Wed, 10 Feb 2016 14:50:10 +0000 From: Liming Sun To: Bruce Richardson Thread-Topic: [dpdk-dev] [PATCH v2 2/2] driver/net/mpipe: fix the crash/hung issue when testpmd quits Thread-Index: AQHRY1LdHoZ9t4ALdUm6G3zymY6GkJ8lXRsQ Date: Wed, 10 Feb 2016 14:50:09 +0000 Message-ID: References: <1450813790-11874-3-git-send-email-lsun@ezchip.com> <1452263948-22485-1-git-send-email-lsun@ezchip.com> <1452263948-22485-2-git-send-email-lsun@ezchip.com> <20160209155925.GC7248@bricha3-MOBL3> In-Reply-To: <20160209155925.GC7248@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=ezchip.com; x-originating-ip: [12.216.194.146] x-microsoft-exchange-diagnostics: 1; DB5PR02MB1016; 5:M7+WrZpss+jE1f+jUPevmD6U5SrskS0bCW6vpCgs1TBHXjPRBQTVx9Gt8uhIsQMH/Yy+lGWRxyzyZmeKs1dkBF0CtJnASpUvmx7k+l0zBLnHAYULvZgKFzY+cKwTHzVc26RYkJmlVvk6BhnE2jBTbA==; 24:CeHGXv13CIelh1h/FpZyhmkeVl2ZjRqFclERvXsM6Z2KaOqHnGLPFF3CYVIvKGbhOvM81k5ZOXYVxaXwctV3dZXhuQYFl0TiyluBE8HX9kc= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB1016; x-ms-office365-filtering-correlation-id: 8a25d587-25b2-4dc1-fda9-08d33229796a x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:DB5PR02MB1016; BCL:0; PCL:0; RULEID:; SRVR:DB5PR02MB1016; x-forefront-prvs: 0848C1A6AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(13464003)(164054003)(377454003)(24454002)(106116001)(3846002)(586003)(6116002)(1220700001)(102836003)(76576001)(1096002)(2950100001)(77096005)(15975445007)(2900100001)(92566002)(87936001)(76176999)(5004730100002)(19580405001)(40100003)(15395725005)(50986999)(66066001)(74316001)(86362001)(33656002)(19580395003)(93886004)(54356999)(4326007)(3280700002)(5008740100001)(122556002)(2906002)(5003600100002)(5002640100001)(3660700001)(11100500001)(5001960100002)(110136002)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR02MB1016; H:DB5PR02MB1015.eurprd02.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2016 14:50:09.7724 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR02MB1016 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 2/2] driver/net/mpipe: fix the crash/hung issue when testpmd quits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2016 14:50:11 -0000 I split the change and resubmitted it as v3 http://dpdk.org/dev/patchwork/p= atch/10456/ It includes one of the two fixes. The other one is optional for now and cou= ld be submitted separately later. Thanks, Liming -----Original Message----- From: Bruce Richardson [mailto:bruce.richardson@intel.com]=20 Sent: Tuesday, February 09, 2016 10:59 AM To: Liming Sun Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/2] driver/net/mpipe: fix the crash/hung= issue when testpmd quits On Fri, Jan 08, 2016 at 09:39:08AM -0500, Liming Sun wrote: > 1. Fixed the compiling issue of the ethtool example on tilegx > platform. > 2. Fixed the hung/crash issue when quitting testpmd under high > traffic rate. The buffer error bit needs to be checked before > processing the idesc and releasing the buffer. Code logic is > also simplified. >=20 Again, with two issues being solved, this looks like two patches. Can you a= lso describe exactly the causes of the individual issues in each patch and = how the patch fixes them.=20 Please also include a fixes line for each patch as described here: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body Thanks, /Bruce