From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40073.outbound.protection.outlook.com [40.107.4.73]) by dpdk.org (Postfix) with ESMTP id 48D1DA2F for ; Wed, 15 Feb 2017 15:28:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CtNaWF5JXtov5MzXkSoRYfInXfh+vHZkcwlFBcMiENo=; b=NHuVyzuxW8JBzh77k6m3ZxrlsEj0o6o6v/kUclu6m34OIucMI2g83UWXS0QsmezqneQgF1+WZofdf5rxqIsVBUTruEeCMLohIlvxwJvaUVWzH/YVwKkbY2gze5sJq9EUEcOjiageF+B0XhASy0q00KWAZsp9AwNDSQgR2wFogAc= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Wed, 15 Feb 2017 14:28:08 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0888.030; Wed, 15 Feb 2017 14:28:08 +0000 From: Shreyansh Jain To: "Wiles, Keith" , "jerin.jacob@caviumnetworks.com" CC: Jan Blunck , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 3/7] eal: move virtual device probing into a bus Thread-Index: AQHSh3Kdy4hg4XTbM0KWyLunQv767aFqH9Kg Date: Wed, 15 Feb 2017 14:27:47 +0000 Deferred-Delivery: Wed, 15 Feb 2017 14:27:27 +0000 Message-ID: References: <1487152929-23627-1-git-send-email-jblunck@infradead.org> <1487152929-23627-4-git-send-email-jblunck@infradead.org> <485202cf-3644-5ee9-45b5-d443569bf5b5@nxp.com> <7843A545-14B6-4CD9-9689-ABD123B85890@intel.com> In-Reply-To: <7843A545-14B6-4CD9-9689-ABD123B85890@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 003890d8-b8cd-4776-3c13-08d455aedc9d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:DB5PR0401MB2054; x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2054; 7:PeRt2OziU4BsdrvLrrOMIwMw823QULETnE+hxaL8d1p8fRvLeDQ1fOC/J0yvizWCaexfznBSFER9RPRKP7bVFwQA0iiVE+KcFafA478qve4cOJtGUNmlgjcGBNiLCqoOA4SVBBf9DoCH/2VBnakTddnYgHkCnRbVgdTHdWphIsa6L1/m6obY5Zhw97CnKNvza4dq3+wngo8h4J41O8i4XD9QU6tf58zrESBKJMxLoXDDL52fSZvcBS0KbyIDFGygy3hv4eIHbhRgRJN6U7M6qz6pvGieb9wZt36jJ+C4ODqlC5FIlwFjsfo3MaFLJfc1yo4tIxrGrcDpJXDB2DeimdbkOhugEq7WjxLKtLiUpybX4UhZ2iU5sprMS8mtHNR4nnCpOheIhv4T1U9DRGWCv8rAfdN2PvD1lOTP1Tedtn7bII8gfbXV+mq9mlVp5bxfL1UtyJzKZlMkUYJSoTbXfcIZu2/LXwdUIeQ7GzSBhnzZiuLdOKbk3uP0bFhLznai7f2QA2rWM0s9GmcqHa6UUA== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(155532106045638)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(20161123558025)(6072148); SRVR:DB5PR0401MB2054; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2054; x-forefront-prvs: 021975AE46 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39850400002)(39450400003)(39840400002)(39860400002)(39410400002)(24454002)(13464003)(199003)(189002)(377454003)(2900100001)(66066001)(6246003)(229853002)(74316002)(68736007)(6666003)(86362001)(6436002)(25786008)(101416001)(2501003)(8936002)(92566002)(389900002)(5660300001)(305945005)(7696004)(77096006)(53936002)(6506006)(7736002)(8676002)(189998001)(3660700001)(33656002)(99286003)(81156014)(81166006)(55016002)(6116002)(9686003)(102836003)(93886004)(105586002)(97736004)(106116001)(38730400002)(3846002)(76176999)(3280700002)(54356999)(50986999)(2950100002)(106356001)(54906002)(2906002)(4326007)(122556002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2054; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2017 14:28:07.9384 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2054 Subject: Re: [dpdk-dev] [PATCH 3/7] eal: move virtual device probing into a bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 14:28:09 -0000 > -----Original Message----- > From: Wiles, Keith [mailto:keith.wiles@intel.com] > Sent: Wednesday, February 15, 2017 7:53 PM > To: Shreyansh Jain > Cc: Jan Blunck ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 3/7] eal: move virtual device probing into= a > bus >=20 >=20 > > On Feb 15, 2017, at 8:15 AM, Shreyansh Jain wr= ote: > > > > On Wednesday 15 February 2017 07:41 PM, Shreyansh Jain wrote: > >> On Wednesday 15 February 2017 03:32 PM, Jan Blunck wrote: > >>> This is a refactoring of the virtual device probing which moves into = into > >>> a proper bus structure. > >>> > >>> Signed-off-by: Jan Blunck > >>> --- > >>> lib/librte_eal/common/eal_common_dev.c | 22 ----------------- > >>> lib/librte_eal/common/eal_common_vdev.c | 44 > >>> +++++++++++++++++++++++++++++++++ > >>> 2 files changed, 44 insertions(+), 22 deletions(-) > >>> > >> > >> [...] > >> > >>> > >>> diff --git a/lib/librte_eal/common/eal_common_vdev.c > >>> b/lib/librte_eal/common/eal_common_vdev.c > >>> index 7d6e54f..523a3d6 100644 > >>> --- a/lib/librte_eal/common/eal_common_vdev.c > >>> +++ b/lib/librte_eal/common/eal_common_vdev.c > >>> @@ -37,8 +37,10 @@ > >>> #include > >>> #include > >>> > >> [...] > >> > >>> + > >>> +static struct rte_bus rte_vdev_bus =3D { > >>> + .scan =3D vdev_scan, > >>> + .probe =3D vdev_probe, > >>> +}; > >>> + > >>> +RTE_REGISTER_BUS_LATE(virtual, rte_vdev_bus); > >>> > >> > >> Does it matter if VDEV buses are registered before or after other > >> buses? Either way, the callbacks would be called in the order specifie= d > >> in EAL. > >> > >> > > > > Just ignore this comment - I am misunderstood something. > > > > But another question: Is there specific reason VDEV should be > registered/scanned *after* other devices? Is there some specific problem = if > we do otherwise? (I think this is should be done, but I don't have a spec= ific > reason). >=20 > Does the bonding driver which uses physical devices need to be registered > after physical ones? In Pktgen I noticed the vdev after the physical port= s > and I could not blacklist them as the bonding driver needed them, which > caused the bonding ports to have a greater port number. In the case of pk= tgen > the bonding ports were up around 8 or 10 and caused the display to not sh= ow > the bonding ports. This is really just a usability problem for the develo= per > using Pktgen. I would like to see the vdev devices first, but as long as = the > drivers (like bonding) are fine with them being first. Ah, now I remember - there was a patch from Jerin for this. Probably he is the best person to comment here. (I don't have much insight here).=20 >=20 > Regards, > Keith