From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40084.outbound.protection.outlook.com [40.107.4.84]) by dpdk.org (Postfix) with ESMTP id DAB733990 for ; Sun, 9 Oct 2016 17:13:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=q7/ip97HVIQknqyZ7xKL5wF5QfiJl1mSGkLuFeBWNRg=; b=vgfBX32knJ3lAiC9FP5GEuiOwxEXzi5p6HLgr1ZwpzQbE6rR6AcFSXgQm3h2WdDj0z/byPzg8720MoMfLBSI+/tLAZoVpPpnNoZTtKqTytbISH1L80ZShjEIGEJGgve29nzbAlTnO54RysTGD3NouucLN92PoHLgsHdQ6RcfYjM= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.8; Sun, 9 Oct 2016 15:13:08 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0659.018; Sun, 9 Oct 2016 15:13:07 +0000 From: Shreyansh Jain To: Thomas Monjalon CC: "david.marchand@6wind.com" , "dev@dpdk.org" , "nhorman@tuxdriver.com" Thread-Topic: [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD Thread-Index: AQHSIY5poRG2aayWgU+mxC98UCGdN6CfAACAgAE6WoA= Date: Sun, 9 Oct 2016 15:12:47 +0000 Deferred-Delivery: Sun, 9 Oct 2016 15:12:30 +0000 Message-ID: References: <1475949668-26829-1-git-send-email-shreyansh.jain@nxp.com> <1475949911-27300-1-git-send-email-shreyansh.jain@nxp.com> <184506162.Hjg7Xy8FWv@xps13> In-Reply-To: <184506162.Hjg7Xy8FWv@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [122.177.210.6] x-ms-office365-filtering-correlation-id: 4485dbc9-eca4-42d7-d57a-08d3f056c6a5 x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2054; 6:wkhwkJGEF9FwFDmXZWsYDJa7Z09HsgYzniHgLqwyWS36yOotlY7OPWqSrTPTGhyqincqG3yK69j+IerxosTqYcCQfTyP89RHGsdil+Cu1wU08svQN1J3FG6F7cM3EyP+zfSKO5Ku0tLfywcK2eP56ZwXlHEXOsby+kwT6CGNPS2WarV1b2mDiw8s7Q5GcJ9wahHsmYsO/mPhNdn2VU4nrFv8EvrJC/2mERDqDn8Pvxrwo0FYSoSz1cmp0hmm+icJJ7fAG80oc/xJwogTvXdD1r+fZElFuYjtz4FADxGmbThGu1f+JB7QgLbt10YrC0TzfiVS61WdP0CVZmiBpQvqBUWiws9axMfTa3PRhcZfyNM=; 5:PkXarzEsbvsHkR+v8KcUgLkHo+hyy1QUVtY43Yc16ArzaLi45LHrPjDaPEc7m/qjmSgqEYBHCDdcC/6M6U87nvhC/FYlg58yf8NsIq3R03ixK8MHNzzSZzP+XILtbWr0OMQ1KAzWqNJGp/eGDbU6Mg==; 24:LhQRh7Q8SfINWUO4pXybCVFRXFJl+rrq7sBAhUzLOk7pcwSItvcelrCjNELy6wMLWdqxZrSHTq52LupOYYJFYlevwXUmJLOS7IsWSeh2u+Q=; 7:ONAD7EVnCJgRWPiKJ/EBAXIURaSRq/eqeeFAOgNkgV9TrV2SASrzbauf1Nb66MejOY2aMMvaeNv6iRuBu25e1zE9OHxEWGsu2RGWh+9MP5K8sgdpHHIqn97vrns1G2UFANwQQPswhvhAY6JwDMue+/e414Vvq6nGhEgfk6y69ysX0Yf6HS0YjBRR3zRtfxJHxox1gu+JlEWuhSgzcc2H6ylxQmSRU/uP+OezfnI4LBCOG0ohTLXT40eVtR1/QPFIjaVwzLVd92PZzIeF9MRfhvAgGyZT07qduK3YGj4xNDn4ucylq2RZuR1csMjoFWek x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0401MB2054; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:DB5PR0401MB2054; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2054; x-forefront-prvs: 00909363D5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(199003)(377424004)(377454003)(189002)(13464003)(2900100001)(74316002)(305945005)(2950100002)(101416001)(7696004)(7736002)(92566002)(7846002)(10400500002)(5002640100001)(6916009)(54356999)(5660300001)(50986999)(76176999)(6666003)(3660700001)(68736007)(9686002)(110136003)(66066001)(106116001)(106356001)(3280700002)(105586002)(8936002)(33656002)(19580395003)(77096005)(122556002)(19580405001)(97736004)(586003)(8676002)(102836003)(3846002)(87936001)(6116002)(76576001)(81156014)(81166006)(189998001)(86362001)(2906002)(4326007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2054; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2016 15:13:07.5678 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2054 Subject: Re: [dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Oct 2016 15:13:10 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Sunday, October 09, 2016 1:52 AM > To: Shreyansh Jain > Cc: david.marchand@6wind.com; dev@dpdk.org; nhorman@tuxdriver.com > Subject: Re: [PATCH v2] drivers: prefix driver REGISTER macro with RTE PM= D >=20 > 2016-10-08 23:35, Shreyansh Jain: > > --- a/mk/internal/rte.compile-pre.mk > > +++ b/mk/internal/rte.compile-pre.mk > > @@ -87,7 +87,8 @@ endif > > PMDINFO_GEN =3D $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c > > PMDINFO_CC =3D $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c > > PMDINFO_LD =3D $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@ > > -PMDINFO_TO_O =3D if grep -q 'DRIVER_REGISTER_.*(.*)' $<; then \ > > +PMDINFO_TO_O =3D if grep -E 'RTE_PMD_REGISTER_PCI\([0-9a-zA-Z,_\. > ]+\)|RTE_PMD_REGISTER_VDEV\([0-9a-zA-Z,_\. ]+\)' $<;\ > > + then \ >=20 > I don't understand why you don't simply grep 'RTE_PMD_REGISTER_.*(' ? Because I want to make sure that the grep matches only the DRIVER registrat= ion functions. In case a new macro (or driver type) is added in future, this macro can be = updated. This way we can reduce the probability of a faulty match. Is there a problem with closest possible match? - Shreyansh