From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0084.outbound.protection.outlook.com [104.47.1.84]) by dpdk.org (Postfix) with ESMTP id 86DAF532C for ; Sat, 8 Oct 2016 15:02:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/7uGn0wZYHXBSL4ZWMzqAZaMLQFHErC7xosDD1Q/pzQ=; b=icJLgoiUD08Ec4Xrw3CMfOLctqwhX6oqS3nzOAeRfeIUq00O4QaJ41XajoC/SWL3O7Tx6kK8vrsr8wHz9MKiQLwDXny62gRX1aw6uf/CILvxb28hUUkjghJgTDpasIwJSDTJuda4Jq24nN/GKHbKq3PjgdOdyH58phusqTAIjbE= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.8; Sat, 8 Oct 2016 13:02:02 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0659.015; Sat, 8 Oct 2016 13:02:02 +0000 From: Shreyansh Jain To: Neil Horman CC: "david.marchand@6wind.com" , "dev@dpdk.org" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL Thread-Index: AQHSIJ88D3UX3BkptEC3ZhNFM+xrL6CdAqcVgAAHZwCAAXrZsA== Date: Sat, 8 Oct 2016 13:01:57 +0000 Deferred-Delivery: Sat, 8 Oct 2016 13:01:32 +0000 Message-ID: References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> <1776769.u7sKE3cfDQ@xps13> <20161007141818.GA23455@hmsreliant.think-freely.org> In-Reply-To: <20161007141818.GA23455@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [122.177.131.255] x-ms-office365-filtering-correlation-id: 65871adc-fb73-4ad1-05ef-08d3ef7b4bd5 x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2054; 7:IKlcIjU6UtE2Z5cj0r+5yGinnuaINkP+kXkj7e/FV+YBQ3C9iGTtVAoOTd6ufXrG5i8GboQqWJXsZgyKp7fuQCoME8BYeQ3xFgsB3l7ubHzAek53zh5St/qHb2ofRgFCVY72Jtkjt8Le/gH6Ki4s5v0g32z+rsJGdOWM86CgYAzpyLkYsZ/vthMITg+a9PgDeNbnReFiqbTCIC4LD4EU1FS0cpqN2hBnR7OrrYbu5fv9JcH/miXOY486kZr121bWKl0s4JKZLVXSDTzq5BV9/gzoS2cSWyvMiAB5Gtd00g8ii1HquVYB692srGJ7gB5X x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0401MB2054; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(155532106045638); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:DB5PR0401MB2054; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2054; x-forefront-prvs: 008960E8EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377424004)(13464003)(377454003)(189002)(24454002)(199003)(5002640100001)(106116001)(66066001)(86362001)(7696004)(2950100002)(105586002)(6666003)(6916009)(7736002)(110136003)(3280700002)(305945005)(3660700001)(189998001)(87936001)(2906002)(3846002)(102836003)(586003)(5660300001)(76576001)(6116002)(4326007)(10400500002)(106356001)(11100500001)(93886004)(19580405001)(54356999)(81156014)(8676002)(50986999)(97736004)(77096005)(2900100001)(68736007)(92566002)(33656002)(9686002)(8936002)(19580395003)(76176999)(7846002)(101416001)(74316002)(122556002)(81166006)(7756004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2054; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2016 13:02:02.0478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2054 Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Oct 2016 13:02:03 -0000 Hi Neil, > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Friday, October 07, 2016 7:48 PM > To: Thomas Monjalon > Cc: Shreyansh Jain ; david.marchand@6wind.com; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER > macros with EAL >=20 > On Fri, Oct 07, 2016 at 03:51:44PM +0200, Thomas Monjalon wrote: > > 2016-10-07 19:11, Shreyansh Jain: > > > --- a/mk/internal/rte.compile-pre.mk > > > +++ b/mk/internal/rte.compile-pre.mk > > > @@ -87,7 +87,7 @@ endif > > > PMDINFO_GEN =3D $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c > > > PMDINFO_CC =3D $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c > > > PMDINFO_LD =3D $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@ > > > -PMDINFO_TO_O =3D if grep -q 'DRIVER_REGISTER_.*(.*)' $<; then \ > > > +PMDINFO_TO_O =3D if grep 'EAL_REGISTER_.*(.*)' $<; then \ > > > echo "$(if $V,$(PMDINFO_GEN), PMDINFO $@.pmd.c)" && \ > > > $(PMDINFO_GEN) && \ > > > echo "$(if $V,$(PMDINFO_CC), CC $@.pmd.o)" && \ > > > > > > --->8--- > > > CC eal_pci_vfio.o > > > PMDINFO eal_pci_vfio.o.pmd.c > > > /bin/sh: 1: > > > /home/shreyansh/build/DPDK/02_dpdk/x86_64-native-linuxapp-gcc/app/dpd= k- > pmdinfogen: > > > not found > > > /home/shreyansh/build/DPDK/02_dpdk/mk/internal/rte.compile-pre.mk:138= : > > > recipe for target 'eal_pci_vfio.o' failed > > > --->8--- > > > > > > I don't think PMDINFO should be running on eal_pci_vfio file. Isn't i= t? > > > > Every files are scanned for the pattern. > > > > > Is it because EAL_REGISTER_* is matching EAL_REGISTER_TAILQ like macr= o > > > as well? > > > > Probably. > > That's another argument in favor of good prefixes. > > I think you should use RTE_DRIVER_REGISTER_ or better, RTE_PMD_REGISTER= _ > Thats what we had, about 4 changes to this macro ago, and yes, that made = alot > more sense, to grep on a more complete version of the macro name to ensur= e a > unique match. You might just look for the regex > EAL_REGISTER_VDEV|EAL_REGISTER_PCI with grep -E =20 Thanks. I will use this grep. >=20 > Neil >=20 >=20 >=20 > > > > > > I am not very well versed with how PMDINFO is linking with the build > > > system so any hints/insight into this would be really helpful. > > > > > > One I get more clarity on this, I will push a new version of this pat= ch. > > > > Thanks > > - Shreyansh