From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0052.outbound.protection.outlook.com [104.47.1.52]) by dpdk.org (Postfix) with ESMTP id 18E37A10 for ; Sat, 8 Oct 2016 14:48:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OUCZpLTSvHxjJ9njmRveK4rtKaAOXYoN6tDh5Qlfbds=; b=slTPLUPAPj6MPCtqDqaKz7kPv9PEdA2Aqtba5L7DssQnqkqxj99bKmoUgY2vT0XvMES9m29ku+z3VUKr4PHjn8qQXJwPgmItcdAp4dIxXOGggRcbQtN+6GBut94uP0YeLCG9jBzH8qX+J7DcLOZJ+1Fnjv6NF9e1GSlGyt5uLPw= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by DB5PR0401MB2053.eurprd04.prod.outlook.com (10.166.11.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.8; Sat, 8 Oct 2016 12:48:01 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0659.015; Sat, 8 Oct 2016 12:48:02 +0000 From: Shreyansh Jain To: Thomas Monjalon CC: "david.marchand@6wind.com" , "dev@dpdk.org" Thread-Topic: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL Thread-Index: AQHSIJ88D3UX3BkptEC3ZhNFM+xrL6CdAMUAgAGAITA= Date: Sat, 8 Oct 2016 12:47:59 +0000 Deferred-Delivery: Sat, 8 Oct 2016 12:47:22 +0000 Message-ID: References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> <3500403.rczxDexAsB@xps13> In-Reply-To: <3500403.rczxDexAsB@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [122.177.131.255] x-ms-office365-filtering-correlation-id: 45d988de-16f2-40be-cd65-08d3ef79571d x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2053; 7:meKtPugaZrMs2TrYj8gYSGC4QBfTUhvZ0LTvOWvpoT8NuJzrouDLY95niAT0QCsDKirXORyy0f7Hcssx/F0GdeGPAAXWMDFsiSPMjxY/zlYv1sVuenuOdkMmigxO9RAhKwggMVZ8P9NLsiDR2ooLNixflrA20l8hgVge65DHGX8JThnmudKAx9i4m71DAZDH5L2ww4pAk0/WpciPW8DZ0HNlBzygkPev1BMbt9XVS2YLObqfw+5QK5H2A6Hh9qewTSHFg7OgviZZOsRcKntQmI9cvb7VNqE1A5Jhj3hniHHDkUFQBGOX4PAhgLRspx+L x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0401MB2053; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:DB5PR0401MB2053; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2053; x-forefront-prvs: 008960E8EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377454003)(13464003)(199003)(377424004)(189002)(33656002)(5002640100001)(10400500002)(3660700001)(74316002)(97736004)(9686002)(7696004)(76176999)(50986999)(54356999)(3280700002)(81156014)(101416001)(5660300001)(8676002)(81166006)(2900100001)(189998001)(87936001)(77096005)(122556002)(92566002)(106356001)(76576001)(6666003)(68736007)(6916009)(2950100002)(105586002)(7736002)(7846002)(66066001)(305945005)(106116001)(110136003)(4326007)(102836003)(3846002)(19580395003)(86362001)(2906002)(19580405001)(8936002)(586003)(6116002)(7756004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2053; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2016 12:48:01.9052 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2053 Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Oct 2016 12:48:03 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, October 07, 2016 7:15 PM > To: Shreyansh Jain > Cc: david.marchand@6wind.com; dev@dpdk.org > Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with = EAL >=20 > 2016-10-07 19:03, Shreyansh Jain: > > DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI > > DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE >=20 > Why not RTE_ prefix instead of EAL_? Because while searching for similar naming pattern I came across other macr= os like EAL_REGISTER_TAILQ which were within librte_eal/eal/* folders. > Why 3 patches? As there is no specific comment in each, I think you can > squash. Because each of the patch are common and tightly related changes. The repla= cement touches a large number of files, even though the change itself is sm= all. By splitting, it makes review (or minor misses) easier - at least for = me. Anyways, if as a maintainer you prefer having a single bulk, I have no issu= es. I will send next version with RTE_* and the 'grep -E' suggestion from Neil. - Shreyansh