From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10088.outbound.protection.outlook.com [40.107.1.88]) by dpdk.org (Postfix) with ESMTP id A239DF95C for ; Wed, 18 Jan 2017 11:53:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8DCY1JgGUAAbNbYmfiUfG4ZRHPkv/Rq8/c7ndwOYDR0=; b=Ija3Lmpl3xUaY2i5s3y2mtx7R+sdEcHK6NOPccolft6At1ovNYIvyubL8sIl1dyYxNn36VbJ3PcOoAzv4L+AhMqpg32KnXO7dphrwUyvWnzaHATEbRaQmGO3rlUOfhwE5ssMuCN/7B5vi/KrOiQY/QSrUyll5jM1OwzfvC1R2aI= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by DB5PR0401MB2055.eurprd04.prod.outlook.com (10.166.11.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Wed, 18 Jan 2017 10:53:40 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0845.014; Wed, 18 Jan 2017 10:53:40 +0000 From: Shreyansh Jain To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [PATCH v9 01/12] eal/bus: introduce bus abstraction Thread-Index: AQHScXaQveS/VtWHgE6Un0kv5mxS2qE+DU2AgAAAwAA= Date: Wed, 18 Jan 2017 10:52:19 +0000 Deferred-Delivery: Wed, 18 Jan 2017 10:51:58 +0000 Message-ID: References: <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com> <1484735880-17178-1-git-send-email-shreyansh.jain@nxp.com> <1484735880-17178-2-git-send-email-shreyansh.jain@nxp.com> <2101696.X900yayxyx@xps13> In-Reply-To: <2101696.X900yayxyx@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 4e594f7a-4794-432a-4277-08d43f904345 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DB5PR0401MB2055; x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2055; 7:J2u+MpjEAclQJxWCHPPv4R+AVBpE8ElI+zhut9ovpA1TlHJdhXhvlLsyFs9eLDkdTLjyb2ZJVbinQhBrtgng0I3idnbNEOkIIYWXBca4EjbN/tLwTwN9TlSIMmuocm2J+2j9j4R5knz7Hg/SLhzzf+TldOKas7fB5LfaJJZm/6w3wB+0mqUGDXWUgLrWiSVz98zOwRbRCLw/lKuKTQgh0LyrCdPGF0j7a9EJCMaQGBnoj4GyDnIks8tI4+dsKlQrnmR12rr1SQnvjZyIjLWRF4reebtpyYEEiLP9ot+pBFCi5kVPo7wTQ8yTNZCZ377M/x03GLT8uZWYluwfUSCaB5n0oREZnUwT49jX38tnbfaTPgrblPqdTnu27VcUBcMMtNo6hdFXrAefe7qTTjPsBJJZUVtzJQ0iPkEe9mGGnL7+C75mwb/FuJ6qOIml0+MtgJvBLGBZRUQCf22boBSgLQ== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(6072148)(6047074); SRVR:DB5PR0401MB2055; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2055; x-forefront-prvs: 01917B1794 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(39840400002)(39860400002)(39850400002)(39410400002)(377424004)(13464003)(189002)(199003)(377454003)(38730400001)(3280700002)(68736007)(50986999)(106116001)(9686003)(93886004)(54356999)(66066001)(105586002)(106356001)(101416001)(6436002)(229853002)(99286003)(55016002)(86362001)(25786008)(33656002)(6506006)(77096006)(76176999)(7736002)(7696004)(81156014)(110136003)(8676002)(3660700001)(5660300001)(305945005)(6666003)(8936002)(6916009)(53936002)(3846002)(81166006)(2950100002)(4326007)(122556002)(2906002)(97736004)(92566002)(74316002)(2900100001)(189998001)(102836003)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2055; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2017 10:53:40.1634 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2055 Subject: Re: [dpdk-dev] [PATCH v9 01/12] eal/bus: introduce bus abstraction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 10:53:43 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, January 18, 2017 4:16 PM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v9 01/12] eal/bus: introduce bus abstraction >=20 > 2017-01-18 16:07, Shreyansh Jain: > > +void > > +rte_bus_register(struct rte_bus *bus) > > +{ > > + RTE_VERIFY(bus); > > + RTE_VERIFY(bus->name && strlen(bus->name)); > > + > > + TAILQ_INSERT_TAIL(&rte_bus_list, bus, next); > > + RTE_LOG(DEBUG, EAL, "Registered [%s] bus.\n", bus->name); > > +} > > + > > +void > > +rte_bus_unregister(struct rte_bus *bus) > > +{ > > + TAILQ_REMOVE(&rte_bus_list, bus, next); > > + RTE_LOG(INFO, EAL, "Unregistered [%s] bus.\n", bus->name); > > +} >=20 > This log should be DEBUG, consistently with "register" one. =20 :( Obvious miss. I will change it. >=20 > > +DPDK_17.02 { > > + global: > > + > > + rte_bus_list; >=20 > So finally, is it an useful symbol? > Could it be removed from this patch? It is required until test_bus is re-written. I can move this to next patch (which introduces test_bus).