From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0079.outbound.protection.outlook.com [104.47.1.79]) by dpdk.org (Postfix) with ESMTP id 9A6B62B83 for ; Wed, 18 Jan 2017 06:12:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GOdcPh+n1dnjAM/cp6zNLpZHIsLFt64BFiHcQRcD9yU=; b=I6btcQIOP0aFVHiCw35GDisRB3F0QjW1F2u0kcWrYMl01SoduScEMiFXXe5LPyqopzdBrML+8U4+U/H+/oVu1RZ/sqYVD+ZfOHBGePo/H/e/FG0TbmT/EbhIRuESSTFuyfkJy8MSVFCM56zVgdMj9RshTTJHro32bCgojh9bJXk= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by DB5PR0401MB2053.eurprd04.prod.outlook.com (10.166.11.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Wed, 18 Jan 2017 05:12:36 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0845.014; Wed, 18 Jan 2017 05:12:36 +0000 From: Shreyansh Jain To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [PATCH v8 1/9] eal/bus: introduce bus abstraction Thread-Index: AQHScMZ/REgSGeb9+UC4p4h91hEUgqE9TtiAgABgXJA= Date: Wed, 18 Jan 2017 05:12:15 +0000 Deferred-Delivery: Wed, 18 Jan 2017 05:11:48 +0000 Message-ID: References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-2-git-send-email-shreyansh.jain@nxp.com> <4512536.CCfCtgmVzb@xps13> In-Reply-To: <4512536.CCfCtgmVzb@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 8b2764bb-f7c3-455e-66ed-08d43f609e13 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DB5PR0401MB2053; x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2053; 7:98UAi/u8zDDS7s/T7HGAYOTkibj43kn4nvzhD0YqPVCERFaGNvHJccBpywPdYoNNx6hyyAL7pH02DtDxBWSKwjtnnIbXMVSyfALRLyiLcqOO1GBFAi/DiA3Y4pj4V7GKCDrsKpeudf4NfNlD4DhvgWdBtggTKoCTC5gSqtY3e8ZR3K9b1RvC2K4izUPRJfzyKyLmcfugPlwrIbMuKcDCDAJddmAl6tfQyZO6i7Wfdnh05myzKOkozFTjh+JUs/70OqzYFPSLAdG1zuWWETgcOIHtJ9zJvRpBezfG0twIKkEcw/TUHSF9mH2hgsOEYAZGVQiXnKmJY2sDmjO0LXh3NShfwKqoHpb4lEXj5Oht2NJTMY2ZibLZNxEpGqS05wcSavHkxZS4xnCVIewhJeWUCotj1bcu77qZKKBP3wTk0pwsM0kKqKeH7jiKWwb8iTI7/PHpa47ORQ3gAZ9neayYQQ== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(6072148)(6047074); SRVR:DB5PR0401MB2053; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2053; x-forefront-prvs: 01917B1794 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39860400002)(39840400002)(39850400002)(39410400002)(39450400003)(377424004)(189002)(13464003)(377454003)(199003)(106116001)(92566002)(53936002)(105586002)(54356999)(2906002)(4326007)(106356001)(2900100001)(101416001)(3660700001)(81156014)(68736007)(86362001)(3846002)(6116002)(102836003)(122556002)(76176999)(8676002)(7736002)(8936002)(9686003)(81166006)(50986999)(33656002)(305945005)(6666003)(93886004)(97736004)(74316002)(189998001)(25786008)(2950100002)(6506006)(66066001)(6436002)(3280700002)(5660300001)(229853002)(55016002)(6916009)(110136003)(99286003)(38730400001)(77096006)(7696004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2053; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2017 05:12:36.5602 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2053 Subject: Re: [dpdk-dev] [PATCH v8 1/9] eal/bus: introduce bus abstraction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 05:12:37 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, January 18, 2017 4:50 AM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v8 1/9] eal/bus: introduce bus abstraction >=20 > 2017-01-17 19:07, Shreyansh Jain: > > +void > > +rte_bus_register(struct rte_bus *bus) > > +{ > > + RTE_VERIFY(bus); > > + RTE_VERIFY(bus->name && strlen(bus->name)); > > + > > + TAILQ_INSERT_TAIL(&rte_bus_list, bus, next); > > + RTE_LOG(INFO, EAL, "Registered [%s] bus.\n", bus->name); >=20 > I think it should be a debug log. I thought it should be visible to user/app which buses exists parallel to t= he information about the detected devices. But, no strong opinion on this - I will change in v9. >=20 > > +/* unregister a bus */ > > +void > > +rte_bus_unregister(struct rte_bus *bus) >=20 > I appreciate the effort for commenting, but I think the function name > is self describing. Ok. I will remove the comment. (as well as similar occurences.=20 >=20 > > +/** > > + * @file > > + * > > + * RTE PMD Bus Abstraction interfaces >=20 > RTE PMD? > I would say "DPDK device bus interface" Yes, that is an oversight. PMD is irrelevant here. >=20 > > +DPDK_17.02 { > > + global: > > + > > + rte_bus_list; >=20 > Why the bus list is exported? > If it is for testing purpose, I wonder wether it is worth to do it. I have modeled the test cases on the lines of test_pci and it worked on act= ual pci device lists. Though, it is very much possible to not even touch th= e actual lists (in either, bus or pci test cases). I can easily remove the usage of actual list in test_bus.