From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0074.outbound.protection.outlook.com [104.47.2.74]) by dpdk.org (Postfix) with ESMTP id AC4A298 for ; Wed, 15 Feb 2017 12:53:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Eq8vGqDjUY78n9hH6uO7UThZordj7qMf0fqwQImULnI=; b=bRdNVj92xcosk1ulOD7Pk70Jq5kwBEITkYB59a+KMOhI1tydSfvucDWCcDmSSMJ0J/5s7GquYT77MjqSrTASt9KMccr1STgyb91TxUbkkfvUMWThM85sxm5wx1uIN0EsfV4pkVFbR/qgx/VR2hDHuOY1WWai1K7HHiiYzWS2ttU= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by DB5PR0401MB2055.eurprd04.prod.outlook.com (10.166.11.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Wed, 15 Feb 2017 11:53:05 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0888.030; Wed, 15 Feb 2017 11:53:05 +0000 From: Shreyansh Jain To: Thomas Monjalon , Jan Blunck CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v11 07/13] pci: split match and probe Thread-Index: AQHScg7euxxK7ANj9UqzffZ/dJk++aFqDSGAgAAKeICAAAcV8A== Date: Wed, 15 Feb 2017 11:52:55 +0000 Deferred-Delivery: Wed, 15 Feb 2017 11:51:55 +0000 Message-ID: References: <1484748329-5418-1-git-send-email-shreyansh.jain@nxp.com> <1484801117-779-8-git-send-email-thomas.monjalon@6wind.com> <2268750.t8Q9V8CvVb@xps13> In-Reply-To: <2268750.t8Q9V8CvVb@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 572830ac-f490-412e-1093-08d4559933fe x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:DB5PR0401MB2055; x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2055; 7:jfAjYbvtP3IQz6yQPts/sed8Uq00VAhAjGVctlOsWmRcJJdV69FVgIvEV9uGU001XaYGtPkZrdk+M8r5I8BzyqV5io6DXCwVjJ318YmMG4Yl/lRwyWWZzZt5+jL6C6sqEBqvoPjJ3nbmxTRir4i89DsnkV52rXUvkQLU/k0Q2QZFWFZVsnvSXNwL5PXAfh9u+zrgS4WhCIDojzdsIn4WM1lkIxaPa6PS9Zj7kHKFsxqn07ptlHLvcY+FCpDvsQnQ/SaKV+F4hb6FdoKtPiIo9RaAXbty8dCYV5MVsnv6PICGwdIFtHhNP4OVbKdXPMpHSIfOY6yPmDDWHhGxrDDNb2wkmDkNW7dzzIiWIXN/q/XNAPWlxNjuuWStDNe24MsePO72J2K2POwIGBdZgn/WPVQuF7vTqyQEP66pXGee5920V/XHs/i02EJCevrDrhHLciVZhlowYfY7HPn0U5j9+jcZF65WsXdOVqj3o4pUjIT9CHOVqcwQcTsTROCsz3RNXmwJqiCYElQgQv98fBcJYw== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123558025)(20161123560025)(6072148); SRVR:DB5PR0401MB2055; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2055; x-forefront-prvs: 021975AE46 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39860400002)(39410400002)(39450400003)(39850400002)(39840400002)(13464003)(377424004)(377454003)(199003)(189002)(2906002)(7696004)(6666003)(53936002)(2950100002)(101416001)(3660700001)(2900100001)(106116001)(76176999)(6246003)(81156014)(105586002)(81166006)(50986999)(5660300001)(106356001)(8676002)(54356999)(122556002)(229853002)(389900002)(6436002)(6506006)(77096006)(68736007)(4326007)(9686003)(55016002)(99286003)(33656002)(25786008)(189998001)(7736002)(8936002)(38730400002)(92566002)(86362001)(93886004)(74316002)(66066001)(97736004)(3846002)(102836003)(6116002)(3280700002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2055; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2017 11:53:05.6367 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2055 Subject: Re: [dpdk-dev] [PATCH v11 07/13] pci: split match and probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 11:53:06 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, February 15, 2017 4:53 PM > To: Jan Blunck ; Shreyansh Jain > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v11 07/13] pci: split match and probe >=20 > 2017-02-15 11:45, Jan Blunck: > > > /** > > > + * Match the PCI Driver and Device using the ID Table > > > + * > > > + * @param pci_drv > > > + * PCI driver from which ID table would be extracted > > > + * @param pci_dev > > > + * PCI device to match against the driver > > > + * @return > > > + * 0 for successful match > > > + * !0 for unsuccessful match > > > + */ > > > +int > > > +rte_pci_match(const struct rte_pci_driver *pci_drv, > > > + const struct rte_pci_device *pci_dev); > > > > I don't think this symbol needs to be exported and visible outside of E= AL. >=20 > If I remember well, Shreyansh wants to re-use it for its own bus which > is closed to PCI. > I think it is weird and we could look for another way to re-use some code= . > Shreyansh? >>From what I recall pci_match _was_ exported was because: 1. earlier match was a callback for bus. Which is not the case now 2. idea was that some other Buses might be able to re-use this. NXP DPAA2 i= mplementation (in early stages). I don't think this is needed anymore.