From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0051.outbound.protection.outlook.com [104.47.2.51]) by dpdk.org (Postfix) with ESMTP id CD3222C23 for ; Tue, 28 Feb 2017 06:28:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wZiVAbulCrqKt7X3ZPXBqvZOcLycVLY0oP5+AZ5wIn0=; b=xNlTUlkBcm9MZdNAO1Y523LsMo3k2Va6Pmu4L5Eesdl7XHjqSS68JE3RlfYd0egx6YJAeffXAvR5hqaVaTgad04ZCrx4BSicP5EnB5btwBwk3P4Qbe7SSvxlSSWyLF5E2yPNNnHD5xHYY/q+iyGx/+rena1Rddx+RRfxO8aFgj4= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by VI1PR04MB1614.eurprd04.prod.outlook.com (10.164.84.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13; Tue, 28 Feb 2017 05:28:02 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([fe80::fc66:cf0:feaa:1ec5]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([fe80::fc66:cf0:feaa:1ec5%14]) with mapi id 15.01.0933.019; Tue, 28 Feb 2017 05:28:01 +0000 From: Shreyansh Jain To: Ferruh Yigit CC: "dev@dpdk.org" , "nhorman@tuxdriver.com" , Hemant Agrawal Thread-Topic: [PATCHv7 03/47] common/dpaa2: adding qbman driver Thread-Index: AQHSjoScYe4aTsVhwkmt40pnYxCNLKF9AU5ogADleAA= Date: Tue, 28 Feb 2017 05:27:35 +0000 Deferred-Delivery: Tue, 28 Feb 2017 05:27:05 +0000 Message-ID: References: <1487684578-28656-1-git-send-email-shreyansh.jain@nxp.com> <8958b9ca-0a7d-3df0-3b62-4b9c610d301c@intel.com> <16fa9e1e-556e-a1b0-68ea-2feba58474d3@intel.com> <7397b7ef-a5c9-9d17-6919-714522f49082@nxp.com> <23fc7ab5-1d1b-183e-7997-6e078d49a499@intel.com> In-Reply-To: <23fc7ab5-1d1b-183e-7997-6e078d49a499@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [192.88.169.1] x-microsoft-exchange-diagnostics: 1; VI1PR04MB1614; 7:f7F/QAeJIB8wB1uLFLtWXD7ZVv02zIjN84lurYpMUmNgFBMLpoSAs9o61YrH/yZxdfXWhXdzE71q+oQDQafp4kObB/I96YRRkP+nozDBRM4wi/LDYhGCBRzYd/jqq8QLMYtqQDBUPrIDLOeFJ4x1GxA5PjzcbPZ0NPufDjGR0xdEGxOexVBZ0bDgJy9mctzbpYX8z6kBVKpNjTaJWiYhXkeiD4Q6ND995azpyiw1WpYVS1Dh+Mv4q1KgSb5/7D0hnTV4PIFplpj3F9hvIsVa3DHhhHoKBDnVOZBL9mkqPkwNc8So6baShjUxy5fCXjJrz9vhpyCHVi15FAqOBoq7zg== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39850400002)(39840400002)(39450400003)(39410400002)(39860400002)(189002)(24454002)(199003)(377454003)(13464003)(8936002)(106116001)(53936002)(106356001)(6246003)(2900100001)(105586002)(68736007)(229853002)(50986999)(8676002)(305945005)(3280700002)(7736002)(81156014)(101416001)(81166006)(54356999)(38730400002)(74316002)(110136004)(76176999)(53546006)(93886004)(102836003)(66066001)(2950100002)(4326007)(6116002)(5660300001)(5250100002)(54906002)(7696004)(3846002)(55016002)(6916009)(189998001)(92566002)(345774005)(33656002)(97736004)(3660700001)(6506006)(86362001)(6436002)(6666003)(2906002)(99286003)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1614; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-correlation-id: b197f532-27c2-44ab-7151-08d45f9a8ff4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:VI1PR04MB1614; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(155532106045638)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148); SRVR:VI1PR04MB1614; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB1614; x-forefront-prvs: 0232B30BBC received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2017 05:28:00.9440 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1614 Subject: Re: [dpdk-dev] [PATCHv7 03/47] common/dpaa2: adding qbman driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 05:28:04 -0000 > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Monday, February 27, 2017 9:06 PM > To: Shreyansh Jain > Cc: dev@dpdk.org; nhorman@tuxdriver.com; Hemant Agrawal > > Subject: Re: [PATCHv7 03/47] common/dpaa2: adding qbman driver >=20 > On 2/27/2017 10:01 AM, Shreyansh Jain wrote: > > Hello Ferruh, > > > > On Friday 24 February 2017 03:28 PM, Ferruh Yigit wrote: > > > > [snip] > > > >>> > >>> Now, we have these possibility: > >>> 1. Have a shared library with non rte_* symbols > >>> 2. We have shared library with rte_* symbols > >>> 3. We have non-net devices (crypto, eventdev, ..) depend on net for > >>> these hardware interfaces > >>> > >>> (2) is hitting performance significantly. > >>> (3) it not a clean solution, having driver/crypto depend on driver/ne= t. > >>> When new devices are there, more dependencies will occur. > >>> > >>> In crux, probably we need to have a discussion on (1) and how strongl= y > >>> we feel about that (specially in context of drivers). > >> > >> Insight of above information, I would be OK with (1). > > > > Great. Thank you for understanding. > > > >> > >> We can go with option (1) now, since these are not real APIs to user > >> application, it can be possible to change them if better solution foun= d. > >> > >> Do you think is it good idea to have different naming syntax for those > >> libraries to clarify they are for PMD internal usage? > >> > > > > Indeed. Current name is librte_common_dpaa2_*. > > Do you think librte_drvlib_dpaa2 or librte_drvlib_dpaa2_pmd is better? >=20 > common vs drvlib may not be different for who don't know about these > libraries, what about using "internal" or "private" kind of keyword? I am ok with librte_pvtlib_dpaa2_pmd or librte_pvtlib_dpaa2. Sounds fine? ('internal' is too long and its abbreviation 'int' doesn't make it easier to read. :D ) - Shreyansh