From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0082.outbound.protection.outlook.com [104.47.1.82]) by dpdk.org (Postfix) with ESMTP id F3FD5388F for ; Wed, 18 Jan 2017 07:56:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3oanc9E0uta/r+1iAaBfKabvXvQdBEXq7w61p4weY24=; b=WHyC1IVGjl0F4GNqjOxQD2nc0LLCCRJxE6/UFhLq6rummgAz/0d6Ny5SUA0LaBfnhBUJaLvInAhcbuMSQ1DgCF8AImBur4OQJzCr3wM57IqVUmp+yZkedY8astvMMFiBxNqTC6Qh03ctJaQjPeJpBccelmiy28MjuYBorfcfv5w= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by DB5PR0401MB2053.eurprd04.prod.outlook.com (10.166.11.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Wed, 18 Jan 2017 06:56:37 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0845.014; Wed, 18 Jan 2017 06:56:37 +0000 From: Shreyansh Jain To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [PATCH v8 2/9] test: add basic bus infrastructure tests Thread-Index: AQHScMaBmSVK0WbU8UOt1zF+6/H+Y6E9UAEAgABg9bCAABuLYA== Date: Wed, 18 Jan 2017 06:56:21 +0000 Deferred-Delivery: Wed, 18 Jan 2017 06:55:29 +0000 Message-ID: References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-3-git-send-email-shreyansh.jain@nxp.com> <9781193.ROD7azHmSd@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 69c2601f-e420-4df1-2bae-08d43f6f25f0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DB5PR0401MB2053; x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2053; 7:JVX+nxGpwye5S7uTzAWY60QGDE3kyPcXEx1X7qHXq25hbV0ZqhsU6Pv9scfbMCPudeorHlSt9Hqja+cYJ+xrhs/VB56dARrODtvDpbCovfyMVZqAKJH6W8xYZ5hh/OijHxCyNONgPAuNDQTDlY3Gfyc7MfcTyiJMOAF9SHHZIfCnRhhzs64E0R21siCQJm9xYVE2LmUX0gXpFqjA6l1OOprAwQz0Lldx+hqVAJp7pPXJGxsWp2ARKrPci8BKj7ssn1BkO833UPbH7Nkiqhd1kPPQezMoqMpF7NNdocSZorClF42RDAvpaFnCm2efW1KCUrNpg3MGPhzXfjj7TYxnlieWk1z7ALSr2LbFJ4GBQbv1hLgoanRmrZ+QlX4zDEKDc/3MYwakQc5KM/wVuYrNThzDpmo10Ufcz2TDiXF12mRjN5Oz8UP0yqjqpPGrMylz8XrcaO1yneizw0UlXdZ7Jg== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(6072148)(6047074); SRVR:DB5PR0401MB2053; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2053; x-forefront-prvs: 01917B1794 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39850400002)(39450400003)(39410400002)(39840400002)(39860400002)(199003)(377454003)(377424004)(189002)(13464003)(93886004)(97736004)(189998001)(74316002)(6666003)(38730400001)(99286003)(6916009)(110136003)(77096006)(7696004)(66066001)(25786008)(6506006)(2950100002)(55016002)(3280700002)(6436002)(229853002)(5660300001)(2906002)(4326007)(54356999)(3900700001)(3660700001)(106356001)(2900100001)(92566002)(105586002)(106116001)(101416001)(53936002)(81166006)(9686003)(8936002)(33656002)(305945005)(50986999)(86362001)(68736007)(81156014)(3846002)(7736002)(8676002)(76176999)(102836003)(6116002)(122556002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2053; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2017 06:56:37.5648 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2053 Subject: Re: [dpdk-dev] [PATCH v8 2/9] test: add basic bus infrastructure tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 06:56:39 -0000 > -----Original Message----- > From: Shreyansh Jain > Sent: Wednesday, January 18, 2017 10:42 AM > To: 'Thomas Monjalon' > Cc: dev@dpdk.org > Subject: RE: [PATCH v8 2/9] test: add basic bus infrastructure tests >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Wednesday, January 18, 2017 4:54 AM > > To: Shreyansh Jain > > Cc: dev@dpdk.org > > Subject: Re: [PATCH v8 2/9] test: add basic bus infrastructure tests > > > > 2017-01-17 19:07, Shreyansh Jain: > > > +REGISTER_TEST_COMMAND(bus_autotest, test_bus); > > > > You should add it to app/test/autotest_data.py >=20 > Ok. I will do that. >=20 > > > > > +/* Bus list exposed */ > > > +extern struct rte_bus_list rte_bus_list; > > > > I think it should be possible to write a test without the real list > > of registered bus. >=20 > Yes, it is possible. I just modeled it on test_pci assuming that is a kin= d of > expected/standard. But, it seems probably it is not. I will change the te= sts. After sending out this mail I realized the real reason for using the actual= lists. Functions like rte_eal_pci_register (for PCI) or rte_bus_register (= for Bus), use global lists for registration. Test cases calls these functio= ns for registering dummy device/bus. One way is to not worry about adding these test/dummy devices/buses to orig= inal list as they would be unregistered anyway. But, risk is of impacting r= unning list assuming multiple cases need to be run from same application/bi= nary context. Another way is to rewrite these functions locally in test case, but that al= so means not testing these global registration/de-registration functions. Former method would continue to have symbols exported. Later is not testing= some entry/exit functions of a sub-system. You still interested in this change?