From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0083.outbound.protection.outlook.com [104.47.2.83]) by dpdk.org (Postfix) with ESMTP id E3CE7532C for ; Sat, 8 Oct 2016 15:01:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=v72ijtBLKLP/RBWRpoCTvys5h4K67EOK5m1OVOTVvuE=; b=dzwbnnpcMkwAmN+Dsk3In9BSjy4ETS5ylrYKVjI4HAQn8k2hGFVa7gHt7DcOb24acOeSO73koP1n1pWL6opTEG8PI7v8gJZ/IpAFlbF5VUY2fqDSFD57lZbjxhXhdpBZneUlZ6amJ4VlJFih+esyaB5Tmxkhhal3p/OaUy/TDOY= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by DB5PR0401MB2056.eurprd04.prod.outlook.com (10.166.11.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.8; Sat, 8 Oct 2016 13:01:02 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0659.015; Sat, 8 Oct 2016 13:01:02 +0000 From: Shreyansh Jain To: Thomas Monjalon CC: "david.marchand@6wind.com" , "dev@dpdk.org" Thread-Topic: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL Thread-Index: AQHSIJ88D3UX3BkptEC3ZhNFM+xrL6CdAqcVgAGC5LA= Date: Sat, 8 Oct 2016 13:00:59 +0000 Deferred-Delivery: Sat, 8 Oct 2016 13:00:51 +0000 Message-ID: References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> <1776769.u7sKE3cfDQ@xps13> In-Reply-To: <1776769.u7sKE3cfDQ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [122.177.131.255] x-ms-office365-filtering-correlation-id: a31acad2-fecd-4ac1-0820-08d3ef7b2809 x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2056; 7:h4nqKUAVLK8AKscKwzN2RoxzJuGiIm3WvsPhjhy0MKHMhg605f1ugWY0GvGZFX0D3pRVkq7G5idzP8nyxuIudom5+QCGSpWmTWZ3L8Fofxk0fp4hAtUtZqQDyomZ+qfI5ua38Tkyn+ujaXiPu4V5OAS25uRKRGciDG+4BGjldZBp6MlReWZhEBH7O/lJp/WycK/3vZD4ETC3+kSoQFkelR98BaImRmOE6EL743DlrgHmCq98AUk75dtRfJSmGOq7GgBDevaM1kyCnEiJtNmsY+EbdMuSKnjl1G8rtmfJ5gwBx4m23LTptKjso4FHt9yr x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0401MB2056; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(155532106045638); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:DB5PR0401MB2056; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2056; x-forefront-prvs: 008960E8EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(13464003)(199003)(377454003)(189002)(377424004)(586003)(102836003)(3846002)(86362001)(6116002)(97736004)(8676002)(50986999)(54356999)(3660700001)(122556002)(76176999)(68736007)(11100500001)(101416001)(3280700002)(4326007)(92566002)(74316002)(66066001)(33656002)(5660300001)(5002640100001)(105586002)(305945005)(6916009)(7846002)(2900100001)(2950100002)(7736002)(87936001)(77096005)(106116001)(106356001)(76576001)(19580405001)(6666003)(10400500002)(110136003)(189998001)(19580395003)(8936002)(7696004)(2906002)(81156014)(9686002)(81166006)(7756004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2056; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2016 13:01:02.0337 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2056 Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Oct 2016 13:01:03 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, October 07, 2016 7:22 PM > To: Shreyansh Jain > Cc: david.marchand@6wind.com; dev@dpdk.org > Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with = EAL >=20 > 2016-10-07 19:11, Shreyansh Jain: > > --- a/mk/internal/rte.compile-pre.mk > > +++ b/mk/internal/rte.compile-pre.mk > > @@ -87,7 +87,7 @@ endif > > PMDINFO_GEN =3D $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c > > PMDINFO_CC =3D $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c > > PMDINFO_LD =3D $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@ > > -PMDINFO_TO_O =3D if grep -q 'DRIVER_REGISTER_.*(.*)' $<; then \ > > +PMDINFO_TO_O =3D if grep 'EAL_REGISTER_.*(.*)' $<; then \ > > echo "$(if $V,$(PMDINFO_GEN), PMDINFO $@.pmd.c)" && \ > > $(PMDINFO_GEN) && \ > > echo "$(if $V,$(PMDINFO_CC), CC $@.pmd.o)" && \ > > > > --->8--- > > CC eal_pci_vfio.o > > PMDINFO eal_pci_vfio.o.pmd.c > > /bin/sh: 1: > > /home/shreyansh/build/DPDK/02_dpdk/x86_64-native-linuxapp-gcc/app/dpdk- > pmdinfogen: > > not found > > /home/shreyansh/build/DPDK/02_dpdk/mk/internal/rte.compile-pre.mk:138: > > recipe for target 'eal_pci_vfio.o' failed > > --->8--- > > > > I don't think PMDINFO should be running on eal_pci_vfio file. Isn't it? >=20 > Every files are scanned for the pattern. =20 Sorry, I should have been clearer in my statement. I meant, I didn't think eal_pci_vfio.o had anything of interest for the PMD= tool and hence the mk files would have skipped over it in absence of a mat= ch. I understand that PMDINFO would run on all files. >=20 > > Is it because EAL_REGISTER_* is matching EAL_REGISTER_TAILQ like macro > > as well? >=20 > Probably. > That's another argument in favor of good prefixes. > I think you should use RTE_DRIVER_REGISTER_ or better, RTE_PMD_REGISTER_ =20 I thought of EAL_PMD_REGISTER_* but dropped it because for PCI_TABLE like m= acros, the name got really long (EAL_PMD_REGISTER_PCI_TABLE()). Anyways, I will use RTE_PMD_REGISTER_* now and send another version. > > > > I am not very well versed with how PMDINFO is linking with the build > > system so any hints/insight into this would be really helpful. > > > > One I get more clarity on this, I will push a new version of this patch= . >=20 > Thanks - Shreyansh