From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0067.outbound.protection.outlook.com [104.47.0.67]) by dpdk.org (Postfix) with ESMTP id 763292BD9 for ; Wed, 27 Jul 2016 15:23:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dINwBtdyRgF7VHbCcloeaDgqzwtUlfqD+xItPW5Yeqg=; b=Ti16AdA+F5xwGF10icDoIgG15ID0xf1gx0w01TG/bmc8dwqnm03guaWcPDqtD5FW9sIp1jD4+KmUCNI6tGF4hvaBvQZirYimKQbRwYR3HZGsSgYAS8f/Law9al8dU5Dp/fPPbQZ5Ry1aZkO+/EmFPpknCsvJpxnDsYN5pjsloEU= Received: from DB5PR04MB1605.eurprd04.prod.outlook.com (10.164.38.147) by AM4PR0401MB2049.eurprd04.prod.outlook.com (10.166.131.135) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.557.8; Wed, 27 Jul 2016 13:23:55 +0000 Received: from DB5PR04MB1605.eurprd04.prod.outlook.com ([10.164.38.147]) by DB5PR04MB1605.eurprd04.prod.outlook.com ([10.164.38.147]) with mapi id 15.01.0557.009; Wed, 27 Jul 2016 13:23:54 +0000 From: Hemant Agrawal To: Thomas Monjalon , Jerin Jacob CC: David Hunt , "dev@dpdk.org" , "olivier.matz@6wind.com" , "viktorin@rehivetech.com" , Shreyansh Jain Thread-Topic: usages issue with external mempool Thread-Index: AdHnATWfB11qtF4jQMWZheRENVyKLAA6zzmAAABRNgAABqDnkA== Date: Wed, 27 Jul 2016 13:23:54 +0000 Message-ID: References: <20160727095128.GA11679@localhost.localdomain> <1626416.VyKLPpZHgH@xps13> In-Reply-To: <1626416.VyKLPpZHgH@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: c5a115eb-43b3-4667-bdd8-08d3b621420f x-microsoft-exchange-diagnostics: 1; AM4PR0401MB2049; 6:7WAkGLpyuS+u2fQG8P180t+AGESmlh57IUDcfHAQZZXCFHW5QbDhhKQ4mqCQp9rngIHBVfC1dF1xBbo+verFTaEdNJ1ncFUfxjICGv0wVvxBOGwHImJpzKQQtHl7D5yvYto7mZKu411yrJ9UqNIV/n8YJYYH3RioAxn889BFaEUxFAgGCICYdQHg5FOah91CsdQKlYmR0/lGpFkPubjXuJWXgTna/G8Mdcb7jGg6u7dMcsiXM/pdI6fDgYxayAsFCFWLry5H1pDylamTqz0DHhffoL1pHBKoN2b9D5WWlQModDo8gZV3J9HFzePxMhaP3U/ATrPLL+CC5Ink1n/iyA==; 5:B45qX+ALdT5F5U+p0pzfuA42LYuoNp92D/lGDfs3bnNaYw2LsHSRzbjWDBau4IkbPleskUH2ViSKUt4klRJexoxGz00EhLMwtlz3oj05HvnnblQLTDjJ3EE3SlLoy8DChqKYFo3SEST4/KV7A0VxnQ==; 24:i+HssI8WvM5sbhLZUlxjHUT9SeoCEpoFPZasSc8TScGpG8qLQCeU35CLvWnsYrfB2IN+hnzl8yOgI1WvrAk/EIs9zz32MCpxgsw/FoLw+vg=; 7:MTPASGdJs9+bU5mwtLT1tNQgZDGTeUVlxJyyH/coR9rVFjxwjnZXpZPmFsOCTYysGaZBYzYFiUDSamHAH9K7Xs5LOp5bTyqXTAYluc2+akzCwWLGw/241shTs4qIetyI9MiKUVTQOnArW4ztyzQ1NmTSb7maig4lz8DswlWGAmiUJwYvP+1NXK9vMo0vMCD38Ob1FTiTMhcs3qSJOhrughpDIo+AKiagcwI/3URBirOXdRVLXScS+yYTmL9osWiA x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0401MB2049; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:AM4PR0401MB2049; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0401MB2049; x-forefront-prvs: 0016DEFF96 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(189002)(13464003)(24454002)(377424004)(199003)(189998001)(2900100001)(105586002)(10400500002)(106356001)(122556002)(2950100001)(92566002)(305945005)(76576001)(74316002)(5003600100003)(7736002)(4326007)(7846002)(19580395003)(87936001)(2906002)(7696003)(76176999)(33656002)(54356999)(50986999)(19580405001)(3846002)(86362001)(5002640100001)(81166006)(101416001)(586003)(5001770100001)(97736004)(102836003)(8676002)(8936002)(6116002)(77096005)(3280700002)(68736007)(3660700001)(9686002)(81156014)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0401MB2049; H:DB5PR04MB1605.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2016 13:23:54.5603 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB2049 Subject: Re: [dpdk-dev] usages issue with external mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2016 13:23:58 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > 2016-07-27 15:21, Jerin Jacob: > > On Tue, Jul 26, 2016 at 10:11:13AM +0000, Hemant Agrawal wrote: > > > This is not a user friendly approach to ask for changing 1 API to 6 n= ew APIs. > Or, am I missing something? > > > > I agree, To me, this is very bad. I have raised this concern earlier > > also > > > > Since applications like OVS goes through "rte_mempool_create" for even > > packet buffer pool creation. IMO it make senses to extend > > "rte_mempool_create" to take one more argument to provide external > > pool handler name(NULL for default). I don't see any valid technical > > reason to treat external pool handler based mempool creation API > > different from default handler. [Hemant] It is better.=20 However, I will also suggest to upgrade "rte_pktmbuf_pool_create" with obj_= init, this will create consistency in applications to use it instead of usi= ng rte_mempool_create. > > > > Oliver, David > > > > Thoughts ? > > > > If we agree on this then may be I can send the API deprecation notices > > for rte_mempool_create for v16.11 >=20 > It would have been a lot better to send a patch during the 16.07 cycle to= avoid > breaking again the API. > I'm afraid it will even be too late for the deprecation notice. [Hemant] Yes! It is late.=20 we can make these changes immediately after 16.07.