From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0063.outbound.protection.outlook.com [104.47.2.63]) by dpdk.org (Postfix) with ESMTP id 9E08E58D8 for ; Fri, 16 Sep 2016 11:34:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SS7oNOietCdAeyN/PUO1xCqkCMS/PcvhCrOZo2SGZCw=; b=kvmxpdekaAGEG4po00NJp0dKUpryNqfFWFgV485XDwnmFB1boIcXdmqJV6m6BN8i1yAUNy8xgKu586NU81fq7yeHRlUZGyeRNX4NKHD0ba6ntqV3bnyDORfqE2vP3ZfuLzZunY4FHEpaJeXH7QDY7DDoXNUj6IgFubjB+n74cOs= Received: from DB5PR04MB1605.eurprd04.prod.outlook.com (10.164.38.147) by DB5PR04MB1608.eurprd04.prod.outlook.com (10.164.38.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.629.6; Fri, 16 Sep 2016 09:34:21 +0000 Received: from DB5PR04MB1605.eurprd04.prod.outlook.com ([10.164.38.147]) by DB5PR04MB1605.eurprd04.prod.outlook.com ([10.164.38.147]) with mapi id 15.01.0629.006; Fri, 16 Sep 2016 09:34:21 +0000 From: Hemant Agrawal To: "Hunt, David" , "olivier.matz@6wind.com" CC: "dev@dpdk.org" , "jerin.jacob@caviumnetworks.com" Thread-Topic: [PATCH v2 2/2] mempool:pktmbuf pool default fallback for mempool ops error Thread-Index: AQHSD0XbA+aiPoYut06zcWlCFrxyHaB7ylkAgAASBjA= Date: Fri, 16 Sep 2016 09:34:21 +0000 Message-ID: References: <1473346213-6038-1-git-send-email-hemant.agrawal@nxp.com> <1473959607-1951-1-git-send-email-hemant.agrawal@nxp.com> <1473959607-1951-2-git-send-email-hemant.agrawal@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 9f4927d5-c5b0-4580-7b07-08d3de14a3d1 x-microsoft-exchange-diagnostics: 1; DB5PR04MB1608; 6:4BKdWAGTG31vTFxf4oonQO1esL8amDdsJYzFs+Hs9alFJ2B0mNhZrmWstezUIXHlGEtY6wCiK92S3OrLuCahqXSybxW0PoJd/F7nlrFN0BB3Eh33uJDuzYoBh5yWtMu7G+X2DKIGdezmGTtL1Rd8mZm0jUCViJf8tNcgqaBy+xe1rUDc3uX229L3rCg0vqQ21WMZ0Vm33m1B/kMBt2ulkfYFEXrsY8t0pGE/4S2xUt80PPNPRpQtEehMIrTih7DjFh2W2U9DNPQMG+bNkIAexHIL8qYJLKUEREJp5ENfXBGRI425vue6InYZy+/QtnZ4yrV3E9tU0uZK6+EdcVP0ig==; 5:0N2BbYD0pMOYOdTEl2uQvsGTI3f7gyKF6Kv2hk4vKoaPjx2WttlUz4Zsr3n3cwP5RuuL8xqaSu03aHib2xzfD03P1H9p484ihZoh9pK9OhnThdtbZ0lFab6lyfjIceohqfkGzKNVWEAuFDtAsSGLpA==; 24:jaYEpMRv92UVQ7obrBw8alCEDXKLkcQw+MULD+Ft+lu0V3HWGT5EbQMG0xaLPFkxbDJ6vp4BsPoSV2kv2/KnrJQWj/B3Nh2e7/QUj0r72YM=; 7:c2LobNMnP7Civ52nlnmYJDnuEdnYjatSmewxvULiDsrIBu+nnlwQ8tDtMls5XSUHdRbaPf5RUnNoOFWFVRTYRXbbHcxjXeHkHnkr2ZinNV+490w3VKybMzCQGJp+sHc1jMyN5kErJU0c4ZOUPd58H9uDJrg39EVbXwF4E7SUnKimC35yivrhJscn+ifZoskI94nhotJ++lro1kKe4XbBymKrzTBJcL9PdSk5c9COBmElFgK0MVQ8Ipbij4RTavas x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR04MB1608; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:DB5PR04MB1608; BCL:0; PCL:0; RULEID:; SRVR:DB5PR04MB1608; x-forefront-prvs: 0067A8BA2A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377454003)(199003)(189002)(24454002)(13464003)(10400500002)(68736007)(11100500001)(33656002)(101416001)(106356001)(50986999)(105586002)(76176999)(9686002)(4326007)(54356999)(106116001)(3280700002)(76576001)(74316002)(3660700001)(81166006)(7696004)(7736002)(305945005)(122556002)(5002640100001)(81156014)(8936002)(66066001)(77096005)(2906002)(5001770100001)(5660300001)(2900100001)(8676002)(97736004)(86362001)(7846002)(586003)(102836003)(2501003)(189998001)(2950100001)(87936001)(3846002)(92566002)(19580395003)(6116002)(93886004)(19580405001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB1608; H:DB5PR04MB1605.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2016 09:34:21.6146 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1608 Subject: Re: [dpdk-dev] [PATCH v2 2/2] mempool:pktmbuf pool default fallback for mempool ops error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 09:34:22 -0000 Hi David, > -----Original Message----- > From: Hunt, David [mailto:david.hunt@intel.com] > Sent: Friday, September 16, 2016 2:00 PM > To: Hemant Agrawal ; olivier.matz@6wind.com > Cc: dev@dpdk.org; jerin.jacob@caviumnetworks.com > Subject: Re: [PATCH v2 2/2] mempool:pktmbuf pool default fallback for > mempool ops error >=20 > Hi Hemant, >=20 > On 15/9/2016 6:13 PM, Hemant Agrawal wrote: > > In the rte_pktmbuf_pool_create, if the default external mempool is not > > available, the implementation can default to "ring_mp_mc", which is an > > software implementation. > > > > Signed-off-by: Hemant Agrawal > > --- > > lib/librte_mbuf/rte_mbuf.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c > > index 4846b89..4adb4f5 100644 > > --- a/lib/librte_mbuf/rte_mbuf.c > > +++ b/lib/librte_mbuf/rte_mbuf.c > > @@ -176,6 +176,11 @@ rte_pktmbuf_pool_create(const char *name, > > unsigned n, > > > > rte_errno =3D rte_mempool_set_ops_byname(mp, > > RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL); > > + > > + /* on error, try falling back to the software based default pool */ > > + if (rte_errno =3D=3D -EOPNOTSUPP) > > + rte_errno =3D rte_mempool_set_ops_byname(mp, "ring_mp_mc", > NULL); >=20 > Should we log a warning message here saying that we're falling back to th= e > mp/mc handler? >=20 [Hemant]Agree. Will add it.=20 > > + > > if (rte_errno !=3D 0) { > > RTE_LOG(ERR, MBUF, "error setting mempool handler\n"); > > return NULL;