Re: [dpdk-dev] [PATCH v5 3/3] net/tap: add queues when attaching from secondary process

[Raslan Darawsheh <rasland@mellanox.com>]

Just sent a new Version with the commit log reworded as mentioned. 

Kindest regards,
Raslan Darawsheh

> -----Original Message-----
> From: Wiles, Keith <keith.wiles@intel.com>
> Sent: Wednesday, October 10, 2018 3:48 PM
> To: Raslan Darawsheh <rasland@mellanox.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org; Shahaf
> Shuler <shahafs@mellanox.com>; Ori Kam <orika@mellanox.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [PATCH v5 3/3] net/tap: add queues when attaching from
> secondary process
> 
> 
> 
> > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh <rasland@mellanox.com>
> wrote:
> >
> > In the case the device is created by the primary process, the
> > secondary must request some file descriptors to attach the queues.
> > The file descriptors are shared via IPC Unix socket.
> >
> > Thanks to the IPC synchronization, the secondary process is now able
> > to do Rx/Tx on a TAP created by the primary process.
> >
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > ---
> >    v2:
> >       - translate file descriptors via IPC API
> >       - add documentation
> >    v3:
> >       - rabse the commit
> >       - use private static array for fd's to be local for each process
> >
> >    v4:
> >       - removed TODO and FIXME tags
> >       - used strlcpy instead of strcpy
> >
> >    v5: rebase the commit on top of Alejandro Lucero patch for secondary
> >        process private pointer.
> >
> >
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> >
> hes.dpdk.org%2Fpatch%2F46185%2F&amp;data=02%7C01%7Crasland%40me
> llanox.
> >
> com%7Ccfacb17302174d9f4d4608d62eae9952%7Ca652971c7d2e4d9ba6a4d14
> 9256f4
> >
> 61b%7C0%7C0%7C636747724769870635&amp;sdata=ascg78Cv3PhUY1blcdUi
> QHh1mmJ
> > JZ2rD5pFUnoEzH9Q%3D&amp;reserved=0
> >
> Maybe the patch title could be better,
> 
> net/tap: allow secondary process to access primary TAP device queues
> 
> Maybe we can just have the title changed at apply time and not require a
> new patch.
> 
> Regards,
> Keith