From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0081.outbound.protection.outlook.com [104.47.0.81]) by dpdk.org (Postfix) with ESMTP id 84EFB2C15 for ; Tue, 2 Oct 2018 12:50:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c3rivFtGxzLDJQ7J82ds+eCsmbBBrKDm/KnABsHBQME=; b=SzUxp58U9HMzh05UCxFIcBoBbRjngS4jaLZceOJdui7xvHm+UBOXr372QXHEITh6GN1Rv1VaSghwky9qcXoYhZ36G3cGYF1uQyEZLtzuZ4Wb4+H+zvsWunbo+UPIomUxGTWQtmV+73oYeA2tjCprNOI+9LWJFphAFJwitA4ex/g= Received: from DB5PR05MB1254.eurprd05.prod.outlook.com (10.162.157.140) by DB5PR05MB1653.eurprd05.prod.outlook.com (10.165.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.25; Tue, 2 Oct 2018 10:50:56 +0000 Received: from DB5PR05MB1254.eurprd05.prod.outlook.com ([fe80::3516:b329:5c35:51a5]) by DB5PR05MB1254.eurprd05.prod.outlook.com ([fe80::3516:b329:5c35:51a5%2]) with mapi id 15.20.1185.024; Tue, 2 Oct 2018 10:50:55 +0000 From: Raslan Darawsheh To: Thomas Monjalon CC: "dev@dpdk.org" , "keith.wiles@intel.com" , Shahaf Shuler , Ori Kam Thread-Topic: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process Thread-Index: AQHUWjt1TJ8DCxvOHUeF0NxWtMS8XqULxG8AgAAAUgA= Date: Tue, 2 Oct 2018 10:50:55 +0000 Message-ID: References: <1538047196-13789-2-git-send-email-rasland@mellanox.com> <1538476438-20891-1-git-send-email-rasland@mellanox.com> <1538476438-20891-2-git-send-email-rasland@mellanox.com> <2772955.aHLSG1IVkg@xps> In-Reply-To: <2772955.aHLSG1IVkg@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [82.213.2.186] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR05MB1653; 6:eDGKouLdwKVGrd2liS0hJ0aphVZnoX7LX9hD1X5detNrD8dSrhASHB4YXgiSH7tYf3ikIleq6ShRaEEt5X/YM2oe43YQP/caGgQhiWyG0xGBK0IgMyebPHQeyqyXOJF/F7VLGI92SOWm1MW1YEeGKp4dz/bt2yGEclQCOWmHup+JWSPoxwEfjYxpAeKFoaWNIzr3YhwwUK9YBtPtNbRXJENmA+PuhYNuD3cufYjgIo8KkBgVSh4RIhV1sLhDJEIQVMuy+Xt8dsj0fqp21M69YquoCTy628Y2PrwB5rRyix6KTMi1lu5xjT2k76k+2eU34yIhBfa4IaVpDmXuoX5qOR1ySjThfDssaIl7XgipzdjYa5bTEGnLlEOw/jO34lvByQQLjpbPhGVJf3fDFadXLvJa7Uk2x1gqV4mmJPavI6oengleWdLKC/JUQAextU/w36YbeM7z194E2+gsexTKgA==; 5:JkQFoU3zrLrpZh6/kLjCt72fdwkmHBHMmLCL48Eg4Fm7+mLf0hnaYL+V+hkGzbkMtcdvdD19ho9LVZYRm6kQWCI2rJ/IVZybqAplWsYBQp2UEleo9VQ9AeP4w0rWDpXP3l1pral4YAyzbvZKOSaKmGjpufFGtn5K5dTKVTs3ZWU=; 7:6PTfDy/ijUtpTNymSi01Jjw6skEnA7Lhvq8L2pqrNaQKbgBhg700s/AEsN7TT4fo/yh4u67H4R4GesUAB9w6SW/Nu8Lcva8w2Rx1gZ8cl5ybCEmGWNWjUNBk8F7tMelQIBb832adPqBD6g5qQr1KXnLqNlamvP8Q1aA61Wwp1pUA3JbVb9hRnS05k0IZHSPWloP6BGVy406KFFyknpcMksdTdPAR1fd2hZXrj3O9Wsxv6W1cXAniHkya/sLPyXEr x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: c0c63978-30f7-43a0-4e75-08d62854ee32 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB5PR05MB1653; x-ms-traffictypediagnostic: DB5PR05MB1653: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149066)(150057)(6041310)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:DB5PR05MB1653; BCL:0; PCL:0; RULEID:; SRVR:DB5PR05MB1653; x-forefront-prvs: 0813C68E65 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(396003)(346002)(376002)(136003)(13464003)(199004)(189003)(53936002)(8676002)(7736002)(8936002)(256004)(3846002)(6116002)(14444005)(33656002)(81156014)(81166006)(5024004)(316002)(186003)(68736007)(55016002)(7696005)(76176011)(6436002)(93886005)(107886003)(99286004)(2906002)(229853002)(54906003)(14454004)(86362001)(9686003)(106356001)(74316002)(71190400001)(6916009)(2900100001)(71200400001)(102836004)(6506007)(26005)(478600001)(6246003)(53546011)(476003)(11346002)(5250100002)(486006)(97736004)(305945005)(25786009)(66066001)(4326008)(446003)(105586002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1653; H:DB5PR05MB1254.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ckSqhQoukmN/vQ2u39b4euKdT+dqYJIA+fqDSepFFL0pymAl5aGSFE/0VnUeoi3mSA0lLEUQ9DtxbjH6Q4lWnLWF1foS8Tf6GboQcXaOIoJxpQyv3YEBghEuyw/jMC4fGnjJG/K6le/0DXguU7F0PVa8SIEE4ecepzoA6/6NzgeEjpSZgkUkvj7lBEyNOo1RRE4pWRd5tZGXhLfPPyKmgYGqznyn5hFMXLdx/fjQbfb5gZhYVQ0a0aBbbmtRVsaj0rcZcu0kxQNeHsKtQ+ddGoMii0JbedTc/YDuEheNMB5di+71/G5EVMKtkpjjBuPL/Bo4z3U/JgQuLLoZwh+Nh1/pY7d0m725wwCUr4HWWXY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0c63978-30f7-43a0-4e75-08d62854ee32 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2018 10:50:55.7021 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1653 Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 10:50:57 -0000 It should be as of per device so we should do it for each port alone since = several ports can have different queues. Moreover, if the port that has the registration was closed or unplugged we'= ll not be able to sync qeues for other ports.=20 Kindest regards, Raslan Darawsheh -----Original Message----- From: Thomas Monjalon =20 Sent: Tuesday, October 2, 2018 1:41 PM To: Raslan Darawsheh Cc: dev@dpdk.org; keith.wiles@intel.com; Shahaf Shuler ; Ori Kam Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching f= rom secondary process 02/10/2018 12:34, Raslan Darawsheh: > @@ -2056,6 +2179,13 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > TAP_LOG(NOTICE, "Initializing pmd_tap for %s as %s", > name, tap_name); > =20 > + /* Register IPC feed callback */ > + ret =3D rte_mp_action_register(TAP_MP_KEY, tap_mp_sync_queues); > + if (ret < 0 && rte_errno !=3D EEXIST) { > + TAP_LOG(ERR, "%s: Failed to register IPC callback: %s", > + tuntap_name, strerror(rte_errno)); > + goto leave; > + } > ret =3D eth_dev_tap_create(dev, tap_name, remote_iface, &user_mac= , > ETH_TUNTAP_TYPE_TAP); Is it an issue registering tap_mp_sync_queues at each tap probing? Should we do it only once?