From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10049.outbound.protection.outlook.com [40.107.1.49]) by dpdk.org (Postfix) with ESMTP id EABC81B6C8 for ; Wed, 10 Oct 2018 16:40:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RLD9+u+ZjMszMHuP9Hn728VA/LDuZdX4it0miWe4OY0=; b=TL23PgAeaCIOWpqlgyaR3PhUAP83TF1fqICYBoF8F759gDehBx8vtzaFuD/OFzSQfld4cBRkun41G30GWwdEWLqmIMWylduZI13R+vwEbG5bvqJ2XV/BMmx9x7j9dW2bVly5GzQEOtxrd08h9pg9aFQvvTX7ykYAGh5uXoxq/Gw= Received: from DB5PR05MB1254.eurprd05.prod.outlook.com (10.162.157.140) by DB5PR05MB1381.eurprd05.prod.outlook.com (10.162.157.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.23; Wed, 10 Oct 2018 14:40:29 +0000 Received: from DB5PR05MB1254.eurprd05.prod.outlook.com ([fe80::3516:b329:5c35:51a5]) by DB5PR05MB1254.eurprd05.prod.outlook.com ([fe80::3516:b329:5c35:51a5%2]) with mapi id 15.20.1207.029; Wed, 10 Oct 2018 14:40:29 +0000 From: Raslan Darawsheh To: Thomas Monjalon , "Wiles, Keith" CC: "dev@dpdk.org" , Shahaf Shuler , Ori Kam , "Yigit, Ferruh" Thread-Topic: [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Thread-Index: AQHUYGdUWBGuC/wah0mdbLiKhXyFa6UY5EUA//+gKoCAAAjwEA== Date: Wed, 10 Oct 2018 14:40:29 +0000 Message-ID: References: <1539154988-20652-1-git-send-email-rasland@mellanox.com> <1A466485-DCE8-40ED-9DDB-E66A0DB2B4A0@intel.com> <7239433.uTLSZrmg9m@xps> In-Reply-To: <7239433.uTLSZrmg9m@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [82.213.2.186] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR05MB1381; 6:PENBaKReo1Yp3t6PIWCtvwjqXFNEV3eb49FNNSiufdx+S2mK9o3VtIClanH3RWFVwOJGuOnZb6LPE+VZsCo5p3os9d+vBTvi9QmUfBzVtpQjD6ctYOT10EZXMk+uhWfP5fIWvpm2uo4XbvvBXI1rfybw7m9nURqvFHN6+bGrxfDm8UZ4hVMB5WTHRJikIaStROe8HF+2rb66jrEscitlzVoNS+uOLam1Oj05u0Jg31mLXnXSoia80Xxnh8RU3vrkieYFv8bbAKqgcYVw6iV4VqZ9JGjBsj96/bClwIS3x16EmYZLJQJildRuhmSans5eGfzfZO3myf+QcZdi+7D0b8IoT2aZuiVOg8hefiexnggKIiboI8v/1QlZhBJG+jvs96ay/7ny+iAmf9Y1O3sdXlVc/WnVIkRQ65/P+S6AxD/fdZ4AA9GawbAu1Kxg2fJWN95mNEr9gYZPbQlOhxyvvA==; 5:AIGyexg9SKwfjNRVBNJUR2wOQz6q20OJO8GWYSXnU6u4hZtyV+omqiIdb67Xc8qw4l7ETB6LLKHEYhpRSHafbYcEQFbEL6jFWv9oSt8Hd1MNsuk/HjgJA8x3kPleUNUb4C+/Ngvaaw2lmxTNkGnGlmb7jwMwhRl/D9RLQwv06iA=; 7:njzbrLdtbYv6wlt8O2PLhpXRSMgfzmO5o5wFmcnWhRZ3Y1o4foJVHp4brpvLGpyck5vYm6t7s4Y7e6RTlxgdjQWNW3MNEPE4137qEOHWB5Ef/ZxrJoHA/l9ue+TmquHICcFkT+LjMtUgPUZQndCMQNo6P5XJU76WjxJPYdk+e893pGIgUjoafUjI+HfEIwJ52yDzEJU5+/p5sGGSqifwIF63sRe7kAkmDJpb5jYDuY4sI4BP5ILRHViZ1Ulp91FC x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: abbff8f2-dbe7-478d-2591-08d62ebe535e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB5PR05MB1381; x-ms-traffictypediagnostic: DB5PR05MB1381: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051); SRVR:DB5PR05MB1381; BCL:0; PCL:0; RULEID:; SRVR:DB5PR05MB1381; x-forefront-prvs: 08213D42D3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(39860400002)(346002)(136003)(199004)(189003)(13464003)(446003)(478600001)(99286004)(4326008)(76176011)(2900100001)(68736007)(53546011)(256004)(6246003)(9686003)(6506007)(7736002)(53936002)(5250100002)(74316002)(6436002)(110136005)(54906003)(26005)(476003)(7696005)(25786009)(11346002)(97736004)(186003)(486006)(102836004)(305945005)(229853002)(55016002)(5660300001)(66066001)(8676002)(105586002)(86362001)(106356001)(81166006)(8936002)(2906002)(14454004)(3846002)(6116002)(316002)(71200400001)(71190400001)(33656002)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1381; H:DB5PR05MB1254.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 3qSxehN6wRmaP97HKrz08YTyoAwLVYpKWG5zG1UkY7kQaz5oQ/LEN5TUjw60m9UBG8TpZK5OwOcUPMn8KG9wGTT7NLdXNfhRvvDlcpNpZFtewlqlUrYIMMYpnV1RJzxhaAYH/VtYQqHuUP3JwnnZJ4u23FKc62bciH3H2gawFMZMj8bo6enm4ER/QXT07wcoKTjbgtNyj2QUgtfsCNGjcH2R4IiA/qzFbc0UNAgsz7AX6kF+su2gJszalseEYEQ/UBTRSVo36xHEUlDvxKlxtvOoFj21JRVtkTOAo0oRYW2Zvei3Jijrn1/b+RckRg8WThyBbtQRZmedFmD9nLIJgEQaDu6wVMOPD0OGLAZHP9U= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: abbff8f2-dbe7-478d-2591-08d62ebe535e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2018 14:40:29.5485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1381 Subject: Re: [dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 14:40:31 -0000 Hi, Just sent a new version with the commit log reworded to answer the "why" qu= estion you mentioned. Thx for your reviews. Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, October 10, 2018 5:08 PM > To: Wiles, Keith ; Raslan Darawsheh > > Cc: dev@dpdk.org; Shahaf Shuler ; Ori Kam > ; Yigit, Ferruh > Subject: Re: [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queu= es > structures >=20 > 10/10/2018 14:50, Wiles, Keith: > > > > > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh > wrote: > > > > > > Signed-off-by: Raslan Darawsheh > > > > This title for the patch is the what we did not why we did it, should t= hat be > changed? To me it does not convey the reason or we would need to add a > more complete comment body text to explain why we wanted the change. It > is a bit of nit picking. >=20 > I think the question "why" must be answered in the body. >=20 >=20