From: Raslan Darawsheh <rasland@mellanox.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
David Marchand <david.marchand@6wind.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
"Xueming(Steven) Li" <xuemingl@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets
Date: Mon, 17 Sep 2018 14:18:56 +0000 [thread overview]
Message-ID: <DB5PR05MB1254F59674C324CD75EE4FA1C21E0@DB5PR05MB1254.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180914063509.GA8298@jerin>
Hi David,
Thx for this feedback I'll be sending a new version with your suggestion.
Kindest regards,
Raslan Darawsheh
-----Original Message-----
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Sent: Friday, September 14, 2018 9:35 AM
To: David Marchand <david.marchand@6wind.com>
Cc: Raslan Darawsheh <rasland@mellanox.com>; Wu, Jingjing <jingjing.wu@intel.com>; Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org; Shahaf Shuler <shahafs@mellanox.com>; Xueming(Steven) Li <xuemingl@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets
-----Original Message-----
> Date: Thu, 13 Sep 2018 18:43:02 +0200
> From: David Marchand <david.marchand@6wind.com>
> To: Raslan Darawsheh <rasland@mellanox.com>
> Cc: "Wu, Jingjing" <jingjing.wu@intel.com>, Thomas Monjalon
> <thomas@monjalon.net>, dev@dpdk.org, Shahaf Shuler
> <shahafs@mellanox.com>, xuemingl@mellanox.com
> Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic
> function to dump packets
>
>
> On Wed, Sep 12, 2018 at 10:06 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
> > use the generic function to dump packets for several forwarding
> > engines.
>
> Rather than patching some engines, how about putting this in rx/tx callbacks ?
+1 to have zero performance impact on forward engines.
> A bit like something I sent earlier ?
>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> hes.dpdk.org%2Fpatch%2F44465%2F&data=02%7C01%7Crasland%40mellanox.
> com%7C9bbd72a1f31b4555b0be08d61a0c4402%7Ca652971c7d2e4d9ba6a4d149256f4
> 61b%7C0%7C0%7C636725037336863883&sdata=bWeN5Rsi0vrX5oPZYI5%2FChCZ4
> VogpRAiY6doOkT0Q8s%3D&reserved=0
>
>
> --
> David Marchand
next prev parent reply other threads:[~2018-09-17 14:18 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 8:06 [dpdk-dev] [PATCH 1/2] app/testpmd: add a generic way for dumping packets Raslan Darawsheh
2018-09-12 8:06 ` [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets Raslan Darawsheh
2018-09-13 16:43 ` David Marchand
2018-09-14 6:35 ` Jerin Jacob
2018-09-17 14:18 ` Raslan Darawsheh [this message]
2018-09-24 12:49 ` [dpdk-dev] [PATCH v2 1/3] app/testpmd: move dumping packets to a separate function Raslan Darawsheh
2018-09-24 12:49 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: add packet dump callback functions Raslan Darawsheh
2018-09-24 12:49 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: set packet dump based on verbosity level Raslan Darawsheh
2018-10-02 13:35 ` [dpdk-dev] [PATCH v2 1/3] app/testpmd: move dumping packets to a separate function Iremonger, Bernard
2018-10-03 15:11 ` Raslan Darawsheh
2018-10-03 15:16 ` [dpdk-dev] [PATCH v3 " Raslan Darawsheh
2018-10-03 15:16 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: add packet dump callback functions Raslan Darawsheh
2018-10-03 15:16 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: set packet dump based on verbosity level Raslan Darawsheh
2018-10-04 14:43 ` [dpdk-dev] [PATCH v3 1/3] app/testpmd: move dumping packets to a separate function Iremonger, Bernard
2018-10-07 7:38 ` Raslan Darawsheh
2018-10-07 7:38 ` [dpdk-dev] [PATCH v4 " Raslan Darawsheh
2018-10-07 7:38 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: add packet dump callback functions Raslan Darawsheh
2018-10-08 10:03 ` Iremonger, Bernard
2018-10-11 14:58 ` Ferruh Yigit
2018-10-16 10:11 ` Raslan Darawsheh
2018-10-07 7:38 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: set packet dump based on verbosity level Raslan Darawsheh
2018-10-08 10:04 ` Iremonger, Bernard
2018-10-11 15:00 ` Ferruh Yigit
2018-10-11 15:24 ` Iremonger, Bernard
2018-10-11 15:52 ` Ferruh Yigit
2018-10-11 16:39 ` Iremonger, Bernard
2018-10-17 12:34 ` Ferruh Yigit
2018-10-08 10:01 ` [dpdk-dev] [PATCH v4 1/3] app/testpmd: move dumping packets to a separate function Iremonger, Bernard
2018-10-11 14:56 ` Ferruh Yigit
2018-10-16 10:10 ` Raslan Darawsheh
2018-10-16 13:11 ` Ferruh Yigit
2018-10-17 7:27 ` [dpdk-dev] [PATCH v5 " Raslan Darawsheh
2018-10-17 7:27 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: add packet dump callback functions Raslan Darawsheh
2018-10-17 7:27 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: set packet dump based on verbosity level Raslan Darawsheh
2018-10-17 12:27 ` [dpdk-dev] [PATCH v5 1/3] app/testpmd: move dumping packets to a separate function Ferruh Yigit
2018-10-17 12:59 ` Iremonger, Bernard
2018-10-17 15:22 ` Raslan Darawsheh
2018-10-17 15:22 ` [dpdk-dev] [PATCH v6 " Raslan Darawsheh
2018-10-17 15:22 ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: add packet dump callback functions Raslan Darawsheh
2018-10-17 15:22 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: set packet dump based on verbosity level Raslan Darawsheh
2018-10-17 16:24 ` Iremonger, Bernard
2018-10-17 16:33 ` Ferruh Yigit
2018-10-18 8:19 ` Raslan Darawsheh
2018-10-18 8:33 ` Ferruh Yigit
2018-10-18 8:47 ` Raslan Darawsheh
2018-10-17 16:22 ` [dpdk-dev] [PATCH v6 1/3] app/testpmd: move dumping packets to a separate function Ferruh Yigit
2018-09-12 15:00 ` [dpdk-dev] [PATCH 1/2] app/testpmd: add a generic way for dumping packets Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB5PR05MB1254F59674C324CD75EE4FA1C21E0@DB5PR05MB1254.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jingjing.wu@intel.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).