From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00042.outbound.protection.outlook.com [40.107.0.42]) by dpdk.org (Postfix) with ESMTP id 23C253576 for ; Sun, 7 Oct 2018 09:38:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YB7MW64zUuHDTEYfT/nHQjgj8btQHhnCWxmuAFxCHoY=; b=Xdgs0lBjA3mZhy+ndLd9+JDhjWbVL7By8N0YXbH/WvUnBfyu035vl/Gh8jIAN52J5Zylz9pjphS4FeR1DlU9W1AazdoIeNB+MMcaw6+QP2Gad/y/tI0td6x8FMnj3m4tUxTrgb59ADwCO9ge3uSW/ibuVsWbRmUSOGpK/q7KM1I= Received: from DB5PR05MB1254.eurprd05.prod.outlook.com (10.162.157.140) by DB5PR05MB1672.eurprd05.prod.outlook.com (10.165.6.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.27; Sun, 7 Oct 2018 07:38:02 +0000 Received: from DB5PR05MB1254.eurprd05.prod.outlook.com ([fe80::3516:b329:5c35:51a5]) by DB5PR05MB1254.eurprd05.prod.outlook.com ([fe80::3516:b329:5c35:51a5%2]) with mapi id 15.20.1185.029; Sun, 7 Oct 2018 07:38:00 +0000 From: Raslan Darawsheh To: "Iremonger, Bernard" , "Wu, Jingjing" CC: Thomas Monjalon , "dev@dpdk.org" , Shahaf Shuler , "Xueming(Steven) Li" , Ori Kam , "jerin.jacob@caviumnetworks.com" , "david.marchand@6wind.com" Thread-Topic: [PATCH v3 1/3] app/testpmd: move dumping packets to a separate function Thread-Index: AQHUWywKMlgiKGQWGkOrESVwI6ptdqUPKwOAgAQ/5eA= Date: Sun, 7 Oct 2018 07:38:00 +0000 Message-ID: References: <1537793304-27883-1-git-send-email-rasland@mellanox.com> <1538579773-23054-1-git-send-email-rasland@mellanox.com> <8CEF83825BEC744B83065625E567D7C260D0CAFD@IRSMSX107.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D0CAFD@IRSMSX107.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [82.213.2.186] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR05MB1672; 6:b9k9siwfPUEAOdszghrxb/0eMURrSMqcKceTcpYBR/NkyF7/yxizU83uTNJMz+PY19VVsj5T0NYNgkmP+GRB+l9RTSAhGqhR7JqfMRVQqqXYHNenhDuvv1Zv/ge1bKKC5IhI+KZuSwSaF2H5odMfQCW0EdYnlmC/fszl4ZLvYhKbCQvXbOb8tzUGzDr4J/wlD9KiOvYIp/2TJWeYfDg4mAodLt/i8eTE5WDKu9UgvbSivLeu7hV6hw6KkRvHaRI3FISftv6k6ftNwqVOScfK/gSbZXugLUzldBNT1nnItaqoRqRwkyMHNMS8xt+rl+94W5qPfapU7oegWPSzmXLFd/1K7e0uWRI79QlaleH/+qt1W8/tY840b7UWUxehOQKSg2yzd3MM1nVl0dXV+j9ro5VYZDdDB7PGb3wZCPAYZf4qmSmkp9DQPtIMuGjXZcdgO5yOkVwOGpwH0fcNjjrZmg==; 5:i760JMurMehC389lMBygaZNcJ315SK0xP0h6XyIH89nVLNs+pbCsZqX3+tai16ltqcQRn0bJ6E1Wd6Ig9Syn0DNvTKYKFl90sghFQJY2dRfCNlo+HpnVwDHLojBCciR+9EaZgevmVptZfA+4GbalecsD/gXCnBl1s0lwguNYFBs=; 7:rtKSzeaAF0Vp2IAG2/jHRXbBdIAaEmExfmmlQYJEZa5qLfklMYieBf2asUlf+rojRm7a++vv5gNc6J1IalB4CTZkjWUyT9M6/lv7tz5FQ+lZy5eMVgQPwnE8bE6BuTgbPV28wtQCuHAhA9B4hRG61vXHYu1PkUiUzIIB8ZXWZurStHQvd7PHqg4uG/xBAvhj+IPrhlxww8OIwU9+xiwc4l4UPhmpYDdUBpCHbZyiQFMBVEMgGuLb5ialy47LMrwd x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: dc9ecdb8-dde4-4929-3e9c-08d62c27ceb9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB5PR05MB1672; x-ms-traffictypediagnostic: DB5PR05MB1672: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051); SRVR:DB5PR05MB1672; BCL:0; PCL:0; RULEID:; SRVR:DB5PR05MB1672; x-forefront-prvs: 0818724663 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(366004)(346002)(396003)(376002)(189003)(199004)(13464003)(86362001)(478600001)(71190400001)(71200400001)(97736004)(305945005)(6436002)(5660300001)(7736002)(53936002)(316002)(68736007)(2900100001)(14454004)(66066001)(14444005)(256004)(110136005)(102836004)(26005)(8936002)(7696005)(8676002)(486006)(74316002)(5250100002)(9686003)(25786009)(446003)(54906003)(81166006)(81156014)(476003)(229853002)(2906002)(33656002)(186003)(11346002)(6506007)(99286004)(6246003)(53546011)(6116002)(4326008)(55016002)(76176011)(3846002)(106356001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1672; H:DB5PR05MB1254.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: WoMKW+dJa7tZGRCdsEPsuvS6ThPLLSjwQ74MrWk4tQ8cMv66zf74cQ0fKUPK0Szi+y4MxYOlIKKI4T6QgIGOuR+Pccqjw0duPoQKwX/t+0XwKF2XToP2xmknqGKq5w7gvbn35GOR8HmXVtKBq5BBW0eWzWnLgqfFWit4s5Y/e2QSuxUiN8rWDzYjUH/Kz4BwMtMJjVvbOyUH/5LXoNz0wWA/Qxh3pDs7LDA0JJKZObCg5ueWB3itxsMAkFc2QIMw+myyisfuaHwq34CYHBlZynPX7LxREwOXnKwD/Xfn1x/rCHb9s8Sl9ML1LILiCDR6L4JVmv8niYx0F4BcCH5FtSdONXaJPMe19s2yAldZoTg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc9ecdb8-dde4-4929-3e9c-08d62c27ceb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2018 07:38:00.1355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1672 Subject: Re: [dpdk-dev] [PATCH v3 1/3] app/testpmd: move dumping packets to a separate function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2018 07:38:06 -0000 You are right about that, I'm sending a V4 now with the fixes.=20 Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Iremonger, Bernard > Sent: Thursday, October 4, 2018 5:44 PM > To: Raslan Darawsheh ; Wu, Jingjing > > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf > Shuler ; Xueming(Steven) Li > ; Ori Kam ; > jerin.jacob@caviumnetworks.com; david.marchand@6wind.com > Subject: RE: [PATCH v3 1/3] app/testpmd: move dumping packets to a > separate function >=20 > Hi Raslan, >=20 > > -----Original Message----- > > From: Raslan Darawsheh [mailto:rasland@mellanox.com] > > Sent: Wednesday, October 3, 2018 4:16 PM > > To: Wu, Jingjing > > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf > Shuler > > ; Raslan Darawsheh ; > > Xueming(Steven) Li ; Ori Kam > > ; jerin.jacob@caviumnetworks.com; > > david.marchand@6wind.com; Iremonger, Bernard > > > > Subject: [PATCH v3 1/3] app/testpmd: move dumping packets to a > > separate function > > > > verbosity for the received/sent packets is needed in all of the > > forwarding engines so moving it to be in a separate function > > > > Signed-off-by: Raslan Darawsheh > > > > --- > > changes in v3: > > - add util.c in the mason.build file > > - restore missing check for ol_flags & PKT_RX_RSS_HASH. > > - add local variables for rte_be_to_cpu to avoid long > > lines. > > --- > > > diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c new file mode > > 100644 index 0000000..12bbe91 > > --- /dev/null > > +++ b/app/test-pmd/util.c > > @@ -0,0 +1,146 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2010-2018 Mellanox technology. > > + */ > > + > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "testpmd.h" > > + > > +static inline void > > +print_ether_addr(const char *what, struct ether_addr *eth_addr) { > > + char buf[ETHER_ADDR_FMT_SIZE]; > > + ether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr); > > + printf("%s%s", what, buf); > > +} > > + > > +static inline void > > +dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf > > *pkts[], > > + uint16_t nb_pkts, int is_rx) > > +{ > > + struct rte_mbuf *mb; > > + struct ether_hdr *eth_hdr; > > + uint16_t eth_type; > > + uint64_t ol_flags; > > + uint16_t i, packet_type; > > + uint16_t is_encapsulation; > > + char buf[256]; > > + struct rte_net_hdr_lens hdr_lens; > > + uint32_t sw_packet_type; > > + uint16_t udp_port; > > + uint32_t vx_vni; > > + > > + if (!nb_pkts) > > + return; > > + printf("port %u/queue %u: %s %u packets\n", > > + port_id, queue, > > + is_rx ? "received" : "sent", > > + (unsigned int) nb_pkts); > > + for (i =3D 0; i < nb_pkts; i++) { > > + mb =3D pkts[i]; > > + eth_hdr =3D rte_pktmbuf_mtod(mb, struct ether_hdr *); > > + eth_type =3D RTE_BE_TO_CPU_16(eth_hdr->ether_type); > > + ol_flags =3D mb->ol_flags; > > + packet_type =3D mb->packet_type; > > + is_encapsulation =3D RTE_ETH_IS_TUNNEL_PKT(packet_type); > > + > > + print_ether_addr(" src=3D", ð_hdr->s_addr); > > + print_ether_addr(" - dst=3D", ð_hdr->d_addr); > > + printf(" - type=3D0x%04x - length=3D%u - nb_segs=3D%d", > > + eth_type, (unsigned int) mb->pkt_len, > > + (int)mb->nb_segs); > > + if (ol_flags & PKT_RX_RSS_HASH) { > > + printf(" - RSS hash=3D0x%x", (unsigned int) mb- > > >hash.rss); > > + printf(" - RSS queue=3D0x%x", (unsigned int) queue); > > + } > > + if (ol_flags & PKT_RX_FDIR) { > > + printf(" - FDIR matched "); > > + if (ol_flags & PKT_RX_FDIR_ID) > > + printf("ID=3D0x%x", > > + mb->hash.fdir.hi); > > + else if (ol_flags & PKT_RX_FDIR_FLX) > > + printf("flex bytes=3D0x%08x %08x", > > + mb->hash.fdir.hi, mb->hash.fdir.lo); > > + else > > + printf("hash=3D0x%x ID=3D0x%x ", > > + mb->hash.fdir.hash, mb->hash.fdir.id); > > + } > > + if (ol_flags & PKT_RX_TIMESTAMP) > > + printf(" - timestamp %"PRIu64" ", mb->timestamp); > > + if (ol_flags & PKT_RX_VLAN_STRIPPED) > > + printf(" - VLAN tci=3D0x%x", mb->vlan_tci); > > + if (ol_flags & PKT_RX_QINQ_STRIPPED) > > + printf(" - QinQ VLAN tci=3D0x%x, VLAN tci outer=3D0x%x", > > + mb->vlan_tci, mb->vlan_tci_outer); > > + if (mb->packet_type) { > > + rte_get_ptype_name(mb->packet_type, buf, > > sizeof(buf)); > > + printf(" - hw ptype: %s", buf); > > + } > > + sw_packet_type =3D rte_net_get_ptype(mb, &hdr_lens, > > + RTE_PTYPE_ALL_MASK); > > + rte_get_ptype_name(sw_packet_type, buf, sizeof(buf)); > > + printf(" - sw ptype: %s", buf); > > + if (sw_packet_type & RTE_PTYPE_L2_MASK) > > + printf(" - l2_len=3D%d", hdr_lens.l2_len); > > + if (sw_packet_type & RTE_PTYPE_L3_MASK) >=20 > The l3 data is missing and the check for RTE_PTYPE_L4_MASK is missing. >=20 > > + printf(" - l4_len=3D%d", hdr_lens.l4_len); > > + if (sw_packet_type & RTE_PTYPE_TUNNEL_MASK) > > + printf(" - tunnel_len=3D%d", hdr_lens.tunnel_len); > > + if (sw_packet_type & RTE_PTYPE_INNER_L2_MASK) > > + printf(" - inner_l2_len=3D%d", hdr_lens.inner_l2_len); >=20 > The inner l3 data is missing and the check for RTE_PTYPE_INNER_L3_MASK is > missing >=20 > > + if (sw_packet_type & RTE_PTYPE_INNER_L4_MASK) > > + printf(" - inner_l4_len=3D%d", hdr_lens.inner_l4_len); > > + if (is_encapsulation) { > > + struct ipv4_hdr *ipv4_hdr; > > + struct ipv6_hdr *ipv6_hdr; > > + struct udp_hdr *udp_hdr; > > + uint8_t l2_len; > > + uint8_t l3_len; > > + uint8_t l4_len; > > + uint8_t l4_proto; > > + struct vxlan_hdr *vxlan_hdr; > > + > > + l2_len =3D sizeof(struct ether_hdr); > > + > > + /* Do not support ipv4 option field */ > > + if (RTE_ETH_IS_IPV4_HDR(packet_type)) { > > + l3_len =3D sizeof(struct ipv4_hdr); > > + ipv4_hdr =3D rte_pktmbuf_mtod_offset(mb, > > + struct ipv4_hdr *, > > + l2_len); > > + l4_proto =3D ipv4_hdr->next_proto_id; > > + } else { > > + l3_len =3D sizeof(struct ipv6_hdr); > > + ipv6_hdr =3D rte_pktmbuf_mtod_offset(mb, > > + struct ipv6_hdr *, > > + l2_len); > > + l4_proto =3D ipv6_hdr->proto; > > + } > > + if (l4_proto =3D=3D IPPROTO_UDP) { > > + udp_hdr =3D rte_pktmbuf_mtod_offset(mb, > > + struct udp_hdr *, > > + l2_len + l3_len); > > + l4_len =3D sizeof(struct udp_hdr); > > + vxlan_hdr =3D rte_pktmbuf_mtod_offset(mb, > > + struct vxlan_hdr *, > > + l2_len + l3_len + l4_len); > > + udp_port =3D RTE_BE_TO_CPU_16(udp_hdr- > > >dst_port); > > + vx_vni =3D rte_be_to_cpu_32(vxlan_hdr- > > >vx_vni); > > + printf(" - VXLAN packet: packet type =3D%d, " > > + "Destination UDP port =3D%d, VNI =3D %d", > > + packet_type, udp_port, vx_vni >> 8); > > + } > > + } > > + printf(" - %s queue=3D0x%x", is_rx ? "Receive" : "Send", > > + (unsigned int) queue); > > + printf("\n"); > > + rte_get_rx_ol_flag_list(mb->ol_flags, buf, sizeof(buf)); > > + printf(" ol_flags: %s\n", buf); > > + } > > +} > > -- > > 2.7.4 >=20 > Regards, >=20 > Bernard.