From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0057.outbound.protection.outlook.com [104.47.0.57]) by dpdk.org (Postfix) with ESMTP id EF4CB7CBD for ; Thu, 1 Jun 2017 16:55:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=l5y1yzLDcw1a+id7aCWbmxAafATWsi2sKRLp9pbRojE=; b=Cc/VAEK1cJp2NRPZICYlGSxiRrYGCX9zsYn+EtCZgoinp0/LFhhWc1P86NePcsINckmsSaimBgUBOF8KFr3y+BstVu5KdyFGDYyeCzdelHe/5ePxig0G1MLBzilpQy6arKn6GnPKBGAVh2KWEQFzPAJZmHFwETj/ss/0pxkpjoQ= Received: from DB6PR0501MB2757.eurprd05.prod.outlook.com (10.172.226.9) by DB6PR0501MB2760.eurprd05.prod.outlook.com (10.172.226.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9; Thu, 1 Jun 2017 14:55:55 +0000 Received: from DB6PR0501MB2757.eurprd05.prod.outlook.com ([fe80::fc38:c560:e9d4:75af]) by DB6PR0501MB2757.eurprd05.prod.outlook.com ([fe80::fc38:c560:e9d4:75af%15]) with mapi id 15.01.1124.020; Thu, 1 Jun 2017 14:55:54 +0000 From: Olga Shern To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= , "Stephen Hemminger" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 08/12] net/failsafe: support offload capabilities Thread-Index: AQHS2iHVnn96w8oZ60idfdvvYIoR3qIQFSAAgAAE7PA= Date: Thu, 1 Jun 2017 14:55:54 +0000 Message-ID: References: <20170531082309.072c873d@xeon-e3> <20170601143812.GF18840@bidouze.vm.6wind.com> In-Reply-To: <20170601143812.GF18840@bidouze.vm.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [77.127.63.200] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0501MB2760; 7:mthYfhHVAKATCEI5Hhqv6l7NZCP4CIZ0xE9ubE5p33vpdtYlgYJreXCxyMyso1aD8pREI91++k+LPAE9bjlN59HwBJgzjEcUgfgUiefzmkslA4KrUz8SHUqjAY+y03hLzRZb4Q5H6SfkcwZbejFZ5ySOAWGhk2R4Az/nBWxcEd5H2PyXQqE13hHMqC1cCatALR0iVExFAchG5s0T/GG+GWKZ+CNudDnBBuuJrQrBaqQNRSswAcN6KrYHdFRaDX+Adm7N9V3ujVy9ZrW9XoPnh3ph/YspNIWAsissEv1tzwZnXVp9fm++coBEYb3K4G2enP9BMT3q29EQ4DN7B93FAg== x-ms-traffictypediagnostic: DB6PR0501MB2760: x-ms-office365-filtering-correlation-id: dc3c350b-1ab4-4bae-5727-08d4a8fe4dd4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:DB6PR0501MB2760; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700100)(100105000095)(100000701100)(100105300095)(100000702100)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703100)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123555025)(20161123562025)(6072148)(100000704100)(100105200095)(100000705100)(100105500095); SRVR:DB6PR0501MB2760; BCL:0; PCL:0; RULEID:(100000800100)(100110000095)(100000801100)(100110300095)(100000802100)(100110100095)(100000803100)(100110400095)(100000804100)(100110200095)(100000805100)(100110500095); SRVR:DB6PR0501MB2760; x-forefront-prvs: 0325F6C77B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39850400002)(39840400002)(39450400003)(39400400002)(377454003)(24454002)(13464003)(3280700002)(3660700001)(8936002)(93886004)(66066001)(8676002)(81166006)(74316002)(5660300001)(99286003)(7736002)(55016002)(305945005)(2906002)(14454004)(6506006)(4326008)(33656002)(38730400002)(25786009)(54356999)(53546009)(229853002)(2950100002)(76176999)(50986999)(5250100002)(9686003)(53936002)(6436002)(7696004)(478600001)(189998001)(6246003)(102836003)(6116002)(3846002)(2900100001)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2760; H:DB6PR0501MB2757.eurprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2017 14:55:54.5909 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2760 Subject: Re: [dpdk-dev] [PATCH v4 08/12] net/failsafe: support offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 14:55:57 -0000 L;w > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ga=EBtan Rivet > Sent: Thursday, June 01, 2017 5:38 PM > To: Stephen Hemminger > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 08/12] net/failsafe: support offload > capabilities >=20 > On Wed, May 31, 2017 at 08:23:09AM -0700, Stephen Hemminger wrote: > > On Mon, 29 May 2017 15:42:20 +0200 > > Gaetan Rivet wrote: > > > > > Signed-off-by: Gaetan Rivet > > > Acked-by: Olga Shern > > > --- > > > doc/guides/nics/features/failsafe.ini | 6 ++ > > > drivers/net/failsafe/failsafe_ops.c | 131 > +++++++++++++++++++++++++++++++++- > > > 2 files changed, 135 insertions(+), 2 deletions(-) > > > > Once again what about case of dumb synthetic NIC combined with SR-IOV > VF? > > The VF has offloads the virtual NIC does not. > > >=20 > The rules for capabilities are a little complicated. > In the case both VF and the virtual NIC are present at launch, then the l= ogical > AND is done both their capabilities sets. > If one has additional capabilities that the user is requesting, and the f= ail-safe > recognize them (currently, all RX offloads, as TX offloads were not yet > expressed by flags), and this capability is not supported by one slave, t= hen > this offload is disabled in the configuration. >=20 > > What about late plugin. how do you program the offloads of the later > > arriving VF device. >=20 > If the VF is not present at launch, then the fail-safe reads only the set= of > capabilities from the fallback device. It does not have to do any AND-ing= of > the flags. >=20 > The consequence is that upon plugin of the VF, the latter has to respect = the > current running configuration. Probing will actually fail if some capabil= ity is not > supported (depending on PMDs), and the running configuration is not > updated as it is considered "live". >=20 > There are only two solutions to this, either: >=20 > * Complicate a lot the fail-safe design and the rules applied in > the decision made on NIC configuration. The user then has bad > surprises upon seeing that his performance have been degraded > for arcane reasons. >=20 > * Emulate in software the offloads and try to advertize as many as > possible. This is done for example in the TAP PMD for some flags, > allowing those offloads to be used with hardware NICs. > The user then has a clear view of the available offloads by comparing > both sets of capabilities. >=20 > -- > Ga=EBtan Rivet > 6WIND