DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] stats_get API: return value suggestion
@ 2017-09-04 12:22 Matan Azrad
  0 siblings, 0 replies; only message in thread
From: Matan Azrad @ 2017-09-04 12:22 UTC (permalink / raw)
  To: dev, Thomas Monjalon

Hi All

Following the next thread:
http://dpdk.org/ml/archives/dev/2017-September/074032.html

The stats_get dev ops API doesn't include return value, so PMD cannot return error
in case of failure at stats getting process time.

Since PCI devices can be removed and there is a long time between the physical removing to the
remove interrupt callback completion, the user can get invalid stats without any indication.
(think about HW counter stats)

I suggest return value for this API - ENODEV\0.

It can be also relevant to stats_reset, promiscuous_enable\disable, allmulticast_enable\disable, etc...

What do you think?

Regards
Matan Azrad

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-09-04 12:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-04 12:22 [dpdk-dev] stats_get API: return value suggestion Matan Azrad

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).