From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0049.outbound.protection.outlook.com [104.47.0.49]) by dpdk.org (Postfix) with ESMTP id 2844D37A0 for ; Mon, 4 Sep 2017 14:22:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3KOgWt/w0Nj4HTbWd9jLhqPZtclCQjo1jVE/gdSUasc=; b=Cr7yD6yhkyxeWxd/Uley3Q3+/3dtdW/IsCERkTl9+KquzFMxfsCg2OSXgrVnuXtTIL2S7CvvzVBnmAcNNNPbbfIYppdDblMieJKogSenquhCZFXwFLNjP3nnb/lEjmqNducpzKxhkwgXh7y8Ntk96nEtZLTUZ1SDoF20cubqs08= Received: from DB6PR0502MB3048.eurprd05.prod.outlook.com (10.172.250.136) by DB6PR0502MB2965.eurprd05.prod.outlook.com (10.172.246.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Mon, 4 Sep 2017 12:22:42 +0000 Received: from DB6PR0502MB3048.eurprd05.prod.outlook.com ([fe80::e938:efe9:effc:7ef8]) by DB6PR0502MB3048.eurprd05.prod.outlook.com ([fe80::e938:efe9:effc:7ef8%14]) with mapi id 15.20.0013.018; Mon, 4 Sep 2017 12:22:42 +0000 From: Matan Azrad To: "dev@dpdk.org" , Thomas Monjalon Thread-Topic: stats_get API: return value suggestion Thread-Index: AdMldfSW1VZLDU9/Qlq+ZlHYF3E1Ig== Date: Mon, 4 Sep 2017 12:22:42 +0000 Message-ID: Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0502MB2965; 6:UAoGPiOdmqce5W8NkkHqzh7nRrdHxKpLZTWRJQLbPkJ/qs9qu8Xzw7R3dCPGgvZ+BDAlwDBaCY+CehAtB9YqmgleNYUIrIPFTktdXdHiG6mUHrb9H+7TGaHsM6jqU6Oy7hd+DNs4go/F8HPoEHOBZ5NqgFowsEL0zze/q/W+iwGukqnm4BSga+NEY91d4kcMEVOwx0YrSILnOX0CgpFIdaMbEjjsERPT8ORTi1OFF7i9cprhR9SP1fdk4O1UqdwqlBTFCxXMihuMqpGWFgZUhTpyrzojPn09UFsJ8ch3KfxJvaWLgj1/2MAROM4AsqLEperQyFWzc9KK1eJgn4n88w==; 5:CWytid861P1bFYOQa2lMijoex+ToCZjXMGS5QU8pU1Wy6vSHq4Ara3Ia35KcNvC2RTxjr8KWS2/Q38rC3wsj7DRAKq6UvI3YM6HN/vMYceow7LAWPqUJBIV4+g9e45QNdCh+RtdFMgTmrceLiaovkA==; 24:nSUJ1oQZU6kM0cB823lu5eEjri/0T9Pwd8Wcn62quk/GBXBgy09OBvmEDc5bcQAAAQcno0HfxZs0mZvbfMLWUTQZIWX7jWse7vYnPsXh1os=; 7:ggVyqdR3w9fNIXu8j+GZAobb5yAItz1QRRyw4UFtZv0BZ7/C3VHcPO0hLZMyiBie/MzG7niqUucDsaZDVbMx9cg1g8GScyhA6eDRfO9KQO8+tyX0QjiROfZyzfmTzmM8Ua02jKlNi5nyYlag8b1OgKgVdkpnaWRFcQOcQxBA5y1GuTWrxr6U+ie1WpEq3d0uiuQIpd3IFxFhn15UgfhmolMhPIA23+9PlXZ+EutKNj8= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 9ca3c85a-11c1-4335-3018-08d4f38fa427 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR0502MB2965; x-ms-traffictypediagnostic: DB6PR0502MB2965: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-exchange-antispam-report-test: UriScan:(21748063052155); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0502MB2965; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0502MB2965; x-forefront-prvs: 0420213CCD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(53754006)(199003)(76104003)(189002)(7696004)(189998001)(7736002)(2900100001)(33656002)(25786009)(101416001)(4743002)(86362001)(50986999)(54356999)(2906002)(966005)(3280700002)(478600001)(3660700001)(8936002)(14454004)(81156014)(81166006)(106356001)(8676002)(105586002)(606006)(99286003)(9686003)(66066001)(790700001)(6116002)(102836003)(3846002)(53376002)(55016002)(53936002)(54896002)(5660300001)(2501003)(74316002)(5250100002)(6306002)(6636002)(6436002)(68736007)(236005)(97736004)(6506006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0502MB2965; H:DB6PR0502MB3048.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2017 12:22:42.4112 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0502MB2965 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] stats_get API: return value suggestion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 12:22:44 -0000 Hi All Following the next thread: http://dpdk.org/ml/archives/dev/2017-September/074032.html The stats_get dev ops API doesn't include return value, so PMD cannot retur= n error in case of failure at stats getting process time. Since PCI devices can be removed and there is a long time between the physi= cal removing to the remove interrupt callback completion, the user can get invalid stats withou= t any indication. (think about HW counter stats) I suggest return value for this API - ENODEV\0. It can be also relevant to stats_reset, promiscuous_enable\disable, allmult= icast_enable\disable, etc... What do you think? Regards Matan Azrad