From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <borisp@mellanox.com>
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
(mail-db5eur01on0064.outbound.protection.outlook.com [104.47.2.64])
by dpdk.org (Postfix) with ESMTP id 41C341396
for <dev@dpdk.org>; Sun, 17 Sep 2017 09:19:46 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=fZj7NR6Juj/xttsXCEtA3VikVSVAHJf0rBl+RZ2ygkY=;
b=Xggo2a93Cezjb1nF+6oiTSNkB2Vl8Rwe7ij0a6Pm0RVTRqPAXwOHhyQjdJd1ZPW2bYj94oSVWDFIWL6gMvgp+13/7lXJQRMjKBFCDin04IvSzy52PIGpM48GruhELuM+Ay7Iyvy6qBHdPYizcUWPj6hR/c7rjbuQIgeKbtTMXy4=
Received: from DB6PR05MB3176.eurprd05.prod.outlook.com (10.170.221.26) by
DB6PR05MB3158.eurprd05.prod.outlook.com (10.170.221.20) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
15.20.56.11; Sun, 17 Sep 2017 07:19:44 +0000
Received: from DB6PR05MB3176.eurprd05.prod.outlook.com
([fe80::6950:5fb1:cff1:35b7]) by DB6PR05MB3176.eurprd05.prod.outlook.com
([fe80::6950:5fb1:cff1:35b7%13]) with mapi id 15.20.0056.010; Sun, 17 Sep
2017 07:19:44 +0000
From: Boris Pismenny <borisp@mellanox.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, Akhil Goyal
<akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "declan.doherty@intel.com" <declan.doherty@intel.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
"radu.nicolau@intel.com" <radu.nicolau@intel.com>, Aviad Yehezkel
<aviadye@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>,
"sandeep.malik@nxp.com" <sandeep.malik@nxp.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Thread-Topic: [PATCH 04/11] lib/librte_net: add ESP header to generic flow
steering
Thread-Index: AQHTLUNnOy9/E+pOF0CrS2hPmJdi5qK1YfMAgANNYJA=
Date: Sun, 17 Sep 2017 07:19:44 +0000
Message-ID: <DB6PR05MB31763EB24872EC791FE3ED08B0620@DB6PR05MB3176.eurprd05.prod.outlook.com>
References: <20170914082651.26232-1-akhil.goyal@nxp.com>
<20170914082651.26232-5-akhil.goyal@nxp.com>
<b5708a38-2c25-6849-7276-df2bf7fbf73e@nxp.com>
In-Reply-To: <b5708a38-2c25-6849-7276-df2bf7fbf73e@nxp.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is )
smtp.mailfrom=borisp@mellanox.com;
x-originating-ip: [37.142.231.231]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DB6PR05MB3158;
6:/H7JCJPMk3KanM+AooaKAZMW0XwMtzt/KRt4oLsMxPtn7XA1YcIkApYfe+k3Av+moMHo0CHvSEZ2B4EvDFMvhcldqAt77cdevky52sMQSlSxegudjZ9iQ983sRDT9p89BoHvig/iHXHlmeqse3vf/UstQQpwm/O3HplkN88QgIO//MnEnRaL8kBtiJcSKuvs1dELosSuZ9EHNvUu4XTQYYTT8sVGRgl4RcHnrI3w6PymHviw5tV4UIbAjrgmtEKjFy8Ay4dHe7/RJH74/bUANMBOxFdDUyi+TSKVnv1wjnLJ44H482ZGxQs4xXCV3w9CNwGdbJmib4LSpzGNVYBlcQ==;
5:1COeyy2TvmKcJOnSZNFqr3AHTlpYKhnpI6vd3NaF7aayro37kRl5mPpeq2f8vazou+IosG6jAq6tB5iQ4HXZoPojokz3F9KWrAnPFh8fV7ympfKimgEgPjtdtjkbeb0AGZP7mcesvmym9M/vdubyMQ==;
24:VSGO1D53RWPlSfrnL2VRQsaaTCTfJ7j40mtcCSvIsB1wmAHu9BeOxJ61djA5JxsCFVj2l930s+6D4y2khoVrnMzFyV8JZHCV89Ff5IleD0A=;
7:5vJgEa9tGCu1VcwUaPx/F2Rn1Hj+bcmXjwupl3ppH+Kzp45YKGaxfO98pkJ7GcgHkPP5Pzlo332uAME2aV7E/wYi/ToX9yffuoyJWIcd6dFRTWIe3b6KYMcjb1+y5+Q13jTNUebyZniYICNZVQhW9a6pGrPE2Y0gPfYThKmHx5GwkZ8arPj+4q29hdWVoNJLq8JQVEgnoU/DtqTSGyijGS7W5lUJAiMRCimnPACFEJk=
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
x-ms-office365-filtering-correlation-id: 113d30e8-9650-40fd-8a1d-08d4fd9c78a2
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0;
RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);
SRVR:DB6PR05MB3158;
x-ms-traffictypediagnostic: DB6PR05MB3158:
x-exchange-antispam-report-test: UriScan:;
x-microsoft-antispam-prvs: <DB6PR05MB31582F95650B3187E9BEB569B0620@DB6PR05MB3158.eurprd05.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123564025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);
SRVR:DB6PR05MB3158; BCL:0; PCL:0;
RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);
SRVR:DB6PR05MB3158;
x-forefront-prvs: 0433DB2766
x-forefront-antispam-report: SFV:NSPM;
SFS:(10009020)(6009001)(39860400002)(346002)(376002)(189002)(199003)(377454003)(24454002)(229853002)(6246003)(50986999)(2906002)(106356001)(7736002)(305945005)(105586002)(54906002)(66066001)(7696004)(6116002)(3846002)(102836003)(74316002)(9686003)(3280700002)(8676002)(53936002)(81166006)(81156014)(97736004)(54356999)(101416001)(3660700001)(68736007)(55016002)(99286003)(5250100002)(6506006)(76176999)(25786009)(5660300001)(6436002)(2501003)(86362001)(8656003)(4326008)(14454004)(8936002)(2950100002)(189998001)(33656002)(478600001)(316002)(2900100001)(53546010)(41533002);
DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3158;
H:DB6PR05MB3176.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords;
MX:1; A:1; LANG:en;
received-spf: None (protection.outlook.com: mellanox.com does not designate
permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2017 07:19:44.5163 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3158
Subject: Re: [dpdk-dev] [PATCH 04/11] lib/librte_net: add ESP header to
generic flow steering
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Sep 2017 07:19:46 -0000
Hi Hemant,
> On 9/15/2017 07:51 AM, Hemant Agrawal wrote:
> Hi Boris,
>=20
> On 9/14/2017 1:56 PM, Akhil Goyal wrote:
> > From: Boris Pismenny <borisp@mellanox.com>
> >
> > The ESP header is required for IPsec crypto actions.
> >
>=20
> > Signed-off-by: Boris Pismenny <borisp@mellanox.com>
> > Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
> > ---
> > doc/api/doxy-api-index.md | 1 +
> > lib/librte_ether/rte_flow.h | 26 ++++++++++++++++++++
> > lib/librte_net/Makefile | 2 +-
> > lib/librte_net/rte_esp.h | 60
> +++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 88 insertions(+), 1 deletion(-) create mode 100644
> > lib/librte_net/rte_esp.h
> >
> > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
> > index a3d39fc..23bafbc 100644
> > --- a/doc/api/doxy-api-index.md
> > +++ b/doc/api/doxy-api-index.md
> > @@ -107,6 +107,7 @@ The public API headers are grouped by topics:
> > [LPM IPv6 route] (@ref rte_lpm6.h),
> > [ACL] (@ref rte_acl.h),
> > [EFD] (@ref rte_efd.h)
> > + [ESP] (@ref rte_esp.h)
> >
> > - **QoS**:
> > [metering] (@ref rte_meter.h),
> > diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h
> > index bba6169..ea08af6 100644
> > --- a/lib/librte_ether/rte_flow.h
> > +++ b/lib/librte_ether/rte_flow.h
> > @@ -50,6 +50,7 @@
> > #include <rte_tcp.h>
> > #include <rte_udp.h>
> > #include <rte_byteorder.h>
> > +#include <rte_esp.h>
> >
> > #ifdef __cplusplus
> > extern "C" {
> > @@ -309,6 +310,13 @@ enum rte_flow_item_type {
> > * See struct rte_flow_item_fuzzy.
> > */
> > RTE_FLOW_ITEM_TYPE_FUZZY,
> > +
> > + /**
> > + * Matches a ESP header.
> > + *
> > + * See struct rte_flow_item_esp.
> > + */
> > + RTE_FLOW_ITEM_TYPE_ESP,
> > };
>=20
> will you please also add changes for rte_flow documentation in prog_guide=
?
>=20
Sure, I'll send the patches in the next couple of days.