Re: [dpdk-dev] [PATCH v2] app/testpmd: add memory dump command

["Xueming(Steven) Li" <xuemingl@mellanox.com>]

Hi Ferruh,

Thanks for your comments, noted.

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, April 7, 2020 5:22 PM
> To: Xueming(Steven) Li <xuemingl@mellanox.com>; Wenzhuo Lu
> <wenzhuo.lu@intel.com>; Jingjing Wu <jingjing.wu@intel.com>; Bernard
> Iremonger <bernard.iremonger@intel.com>; Anatoly Burakov
> <anatoly.burakov@intel.com>; Stephen Hemminger
> <stephen@networkplumber.org>
> Cc: dev@dpdk.org; Asaf Penso <asafp@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add memory dump
> command
> 
> On 4/5/2020 3:49 AM, Xueming Li wrote:
> > Introduce new command to dump memory statistics of each socket,
> > summary, also show changes since last call.
> >
> > Usage:
> >     dump_socket_mem
> >
> > Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> 
> <...>
> 
> > @@ -9576,6 +9626,8 @@ static void cmd_dump_parsed(void *parsed_result,
> >
> >  	if (!strcmp(res->dump, "dump_physmem"))
> >  		rte_dump_physmem_layout(stdout);
> > +	else if (!strcmp(res->dump, "dump_socket_mem"))
> > +		dump_socket_mem(stdout);
> >  	else if (!strcmp(res->dump, "dump_memzone"))
> >  		rte_memzone_dump(stdout);
> >  	else if (!strcmp(res->dump, "dump_malloc")) {
> 
> This "dump_malloc" is not in the upstream, which cause a conflict while
> merging the patch, which is breaking our automated tests.
> It is OK for now, but for later please rebase your patches on latest master.
> 
> > @@ -9604,6 +9656,7 @@ static void cmd_dump_parsed(void *parsed_result,
> >  	TOKEN_STRING_INITIALIZER(struct cmd_dump_result, dump,
> >  		"dump_physmem#"
> >  		"dump_memzone#"
> > +		"dump_socket_mem#"
> >  		"dump_struct_sizes#"
> >  		"dump_ring#"
> >  		"dump_mempool#"
> > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > index 1a9879f..0942ae5 100644
> > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > @@ -539,6 +539,12 @@ Dumps the layout of all memory zones::
> >
> >     testpmd> dump_memzone
> >
> > +dump socket
> > +~~~~~~~~~~~~
> 
> Title fixed as "dump socket memory" while merging
> 
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied to dpdk-next-
> net/master, thanks.