From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D05A8A0519; Sat, 27 Jun 2020 21:25:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3540C1C01F; Sat, 27 Jun 2020 21:25:24 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061.outbound.protection.outlook.com [40.107.20.61]) by dpdk.org (Postfix) with ESMTP id 8314F1C012 for ; Sat, 27 Jun 2020 21:25:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PUdgM+hdnUZSzO9WNzx39Qee9LY3jafffXwaGID7pfg=; b=HN1E+34dUNd0S7j3BJAfr7Knn4kt3N+qQIj3xfgwkIsNRIiKVFADPHkc7cM/UE3HMR8Z0cmAnZE9PQ65LrcwMvpwYljBe/EuRZlF6d5L4Y00Am0npUQPtlDmGjJMEwKsECSd/yA5lBdadKBcY9VHkJpJ/LvErMCSbb8v3vvaWdQ= Received: from AM0P190CA0013.EURP190.PROD.OUTLOOK.COM (2603:10a6:208:190::23) by VE1PR08MB4654.eurprd08.prod.outlook.com (2603:10a6:802:a4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.23; Sat, 27 Jun 2020 19:25:19 +0000 Received: from VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:190:cafe::e2) by AM0P190CA0013.outlook.office365.com (2603:10a6:208:190::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21 via Frontend Transport; Sat, 27 Jun 2020 19:25:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT038.mail.protection.outlook.com (10.152.19.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Sat, 27 Jun 2020 19:25:19 +0000 Received: ("Tessian outbound c90b0f113c0c:v60"); Sat, 27 Jun 2020 19:25:19 +0000 X-CR-MTA-TID: 64aa7808 Received: from d05edc30dda6.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5E0836A7-B1E0-4787-8C09-8E0640C5EF09.1; Sat, 27 Jun 2020 19:25:14 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d05edc30dda6.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 27 Jun 2020 19:25:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mDZyjen45sTAooFtFlTnneITB/GMTHPl2uAHuBJFpSrCrmbhVzwyRsyNf3nOFOspkPa+Cg9IFqckf1wS+fAv+tMNj4bNrMR1beZfvvTqfVpKSSvpFKkBcLec2fn4x95h5QGRPMg7Kg2xEyyFaFMI6aP73oDgQCdmaEPHL+dNXgTP/m2XYmKob09iYzr3FANUYE+55NHUP4+WHbgA0t8AsJ7uhRO28L7Eh6ixqOLEYUniaRun85mFOxjczcoyq6xJ2iX+SjQ6Qe1AP8b0NC9o5QLAocF6zco7XIq3LHfwdHH8Jhd8FxQovFGeKizDxGphjXzE2OUUBB0NKDvkipHfTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PUdgM+hdnUZSzO9WNzx39Qee9LY3jafffXwaGID7pfg=; b=iTX/GmWwAJThSYhU+o9caWOLnBHxj+5NUtVhMpxcyO8sWQau3xl/3gZOeOM3iylZ3PNZECa1NSFBoyySBLq4vyt9uey5aem4FPSYPUBs9wBIpjbpWNewhVLYhIz16HM/t7p8tuTNbqd7l/LYh2Vcck4n5pgEgUG4lWrWyQiYxircyJp35e/HIV3nwQ6xLq8U5ULii4ZpU+di0J2UXYvgRQtADLVhqVxC/6sajpTSsaVP6l1EYGbSycdeVBN1nnUhxYvJqNK2/8bgFoZbhFdPJgHYxxg3ekaicESxibBfzWAoyv73FQGwBHU37eW8tGmRM+h1rxhjH3jGATMtmos1uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PUdgM+hdnUZSzO9WNzx39Qee9LY3jafffXwaGID7pfg=; b=HN1E+34dUNd0S7j3BJAfr7Knn4kt3N+qQIj3xfgwkIsNRIiKVFADPHkc7cM/UE3HMR8Z0cmAnZE9PQ65LrcwMvpwYljBe/EuRZlF6d5L4Y00Am0npUQPtlDmGjJMEwKsECSd/yA5lBdadKBcY9VHkJpJ/LvErMCSbb8v3vvaWdQ= Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com (2603:10a6:4:85::9) by DB7PR08MB3628.eurprd08.prod.outlook.com (2603:10a6:10:44::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20; Sat, 27 Jun 2020 19:25:10 +0000 Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::9d1d:207b:e89d:199d]) by DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::9d1d:207b:e89d:199d%10]) with mapi id 15.20.3131.026; Sat, 27 Jun 2020 19:25:10 +0000 From: Honnappa Nagarahalli To: Honnappa Nagarahalli , "dev@dpdk.org" , Ruifeng Wang , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , "igorch@amazon.com" , "thomas@monjalon.net" , "viacheslavo@mellanox.com" , "arybchenko@solarflare.com" , "bruce.richardson@intel.com" CC: nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v2] eal: adjust barriers for IO on Armv8-a Thread-Index: AQHWTLblcTIo2AreEUOwBhTonY7b+ajs1Ihw Date: Sat, 27 Jun 2020 19:25:09 +0000 Message-ID: References: <20200410164127.54229-1-gavin.hu@arm.com> <20200627191208.34520-1-honnappa.nagarahalli@arm.com> In-Reply-To: <20200627191208.34520-1-honnappa.nagarahalli@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: d90abb04-6f2e-4a93-9ba1-778e129a6ff9.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 43182b45-c478-4362-c3f1-08d81acfd450 x-ms-traffictypediagnostic: DB7PR08MB3628:|VE1PR08MB4654: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3383;OLM:3383; x-forefront-prvs: 0447DB1C71 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rnTIdBAUhXALhudHT/0r/UWptzJEFdLiLlt9q5C/yjZuTOdgfAs82dIg6QOIJpmg/qvDiV6y2465E9aTgn/rvNXBDtIQLaNOp3PqjPi8kynRxVcl534mGOt/JX4/gSgGZzDAOHm+etrguPjqYXkoJP9udcuDyhMTx4PbJ77wFw7Se7DpiNOHPA+st94yc78tO47u9Vcp2B+SrwE0nm3XHRH792NB8n1+AKfwioIeD5b/xq8rL68tqjoOakcjtyHlykx8Ibd7gQMIdfCAveI3Ql5REcLNyPoHILe3UlqQB9a2ojgXJQMAsJhyFNI9v6JUs0MeTjY/buAvlQWc83nYbyUvZrN0lvzmNs7bLoQdHU+p6GUBhBaCo0fpo+NW5cvm4Vy1DSEgxeccK5Gx8TXqqMWVBzS9IFjyrhPlM4h237qfBeya1GoTAvjz+PhH7niq X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2216.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(39850400004)(136003)(376002)(366004)(396003)(71200400001)(8936002)(7696005)(54906003)(8676002)(186003)(478600001)(966005)(316002)(33656002)(26005)(110136005)(76116006)(66476007)(66556008)(64756008)(66446008)(2906002)(52536014)(86362001)(5660300002)(6506007)(53546011)(55016002)(4326008)(9686003)(66946007)(83380400001)(921003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: UYgyD7ey/krWY2KXFjf+11QEwZca63QhYArpuwO0E9XwUYflpeD5jIUUCs3xOXAiFt5/8r385BDfsAZZlyFHPpDH0dlKGDW5oim/Bc7Od88Sag2lRvCYd+dPm9g/MCYtaIdUb5A8NLLJsFOKjqi0QyWzcl16DyyGfDoth4GbCnvkeBXDqt7+Fh/mVVpEufV9Co2BKZf5Rh+ImKLHmHabOTRnPyE6NogVkammGZtEwMk/1/fTzD3dQehrW1qvkWqiq+tUTVRowFLJD4T6K0X7l8E2G3V8lWDvDP7gHa6vuNY7jub5dEc3Us5Mz02XrtKAAXwRnbcTRtqmfG/yPpMN4XZ/hQXSHD5ZnfpIeKh5fAYOyjhf5XCPvL3vyVOsztgscSMAH7inruRdD5GJcWnO/e+zpOtlfUxvExU83jafPtjwMwjpO+5i5Yxh++PmVU3WmTAerVI/Gh6JLQWlgD7cAUf06iMjS3V+BhobcPes21c= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3628 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39850400004)(136003)(346002)(376002)(46966005)(336012)(966005)(7696005)(356005)(8676002)(82310400002)(478600001)(5660300002)(53546011)(6506007)(86362001)(33656002)(54906003)(110136005)(2906002)(8936002)(52536014)(81166007)(186003)(82740400003)(4326008)(47076004)(9686003)(316002)(83380400001)(36906005)(26005)(70586007)(70206006)(55016002)(921003); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 052d2476-f8ff-408b-f7c2-08d81acfced8 X-Forefront-PRVS: 0447DB1C71 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p1e8cDoCFjMA4wKxJ/wZWeDkh02iyZoeBPLWH9WmthksdRo8x/Rnkz3RCM2/vgQ3J8gLKMPKLQ/jFT4CpocZY8BagPVs8u/nhIeNp1rkcvELU5vtrRyckOp1RBmbLaRu0UcIOs3ODpoQRDVxFghPvIuHZ9/0MdoR4MKS7IEFy1iAzZiBVisPbzVrXqPOhHm90Ylg0V7to59v9c4NycRWpUllGDaWuEx0YtTTxUeO15v6PKIYDlZ7zbdNzyGsTiUNqxTEfXG1zho8H8Cowbhp0ZhYihclY/AN0iUwTYL5Xr5ddo/IL7GQLnaqXBPLGoNIQebQ3xhn4BDlcI52zhySOqL9kekDUzeHmar12f09AJp0UUugLWzlkjh3kKo4cHMNDn+zLEBMlp3Isukgja9rr0NqijEYrFbkTGctCZV3XdgXgIKcXcDj8HheSUF+FiFZR1EYhmpR3mE09BISiX7G7z6W0ol9dikk33w3bqJz7lgbNdPa9tCwOhZNoLZ5U377 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2020 19:25:19.4440 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 43182b45-c478-4362-c3f1-08d81acfd450 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4654 Subject: Re: [dpdk-dev] [PATCH v2] eal: adjust barriers for IO on Armv8-a X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jerin, You had a comment earlier about deprecating rte_cio_[rw]mb. Let me know if= you are ok with this patch and I can add those changes (replace references= to rte_cio_[rw]mb with rte_io_[rw]mb and a deprecation notice). Thanks, Honnappa > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Saturday, June 27, 2020 2:12 PM > To: dev@dpdk.org; Honnappa Nagarahalli ; > Ruifeng Wang ; jerinj@marvell.com; > hemant.agrawal@nxp.com; Ajit Khaparde (ajit.khaparde@broadcom.com) > ; igorch@amazon.com; > thomas@monjalon.net; viacheslavo@mellanox.com; > arybchenko@solarflare.com; bruce.richardson@intel.com > Cc: nd > Subject: [PATCH v2] eal: adjust barriers for IO on Armv8-a >=20 > Change the barrier APIs for IO to reflect that Armv8-a is other-multi-cop= y > atomicity memory model. >=20 > Armv8-a memory model has been strengthened to require other-multi-copy > atomicity. This property requires memory accesses from an observer to > become visible to all other observers simultaneously [3]. This means >=20 > a) A write arriving at an endpoint shared between multiple CPUs is > visible to all CPUs > b) A write that is visible to all CPUs is also visible to all other > observers in the shareability domain >=20 > This allows for using cheaper DMB instructions in the place of DSB for de= vices > that are visible to all CPUs (i.e. devices that DPDK caters to). >=20 > Please refer to [1], [2] and [3] for more information. >=20 > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= /?id > =3D22ec71615d824f4f11d38d0e55a88d8956b7e45f > [2] https://www.youtube.com/watch?v=3Di6DayghhA8Q > [3] https://www.cl.cam.ac.uk/~pes20/armv8-mca/ >=20 > Signed-off-by: Honnappa Nagarahalli > Tested-by: Ruifeng Wang > --- > lib/librte_eal/arm/include/rte_atomic_64.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/lib/librte_eal/arm/include/rte_atomic_64.h > b/lib/librte_eal/arm/include/rte_atomic_64.h > index 7b7099cdc..e42f69edc 100644 > --- a/lib/librte_eal/arm/include/rte_atomic_64.h > +++ b/lib/librte_eal/arm/include/rte_atomic_64.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: BSD-3-Clause > * Copyright(c) 2015 Cavium, Inc > - * Copyright(c) 2019 Arm Limited > + * Copyright(c) 2020 Arm Limited > */ >=20 > #ifndef _RTE_ATOMIC_ARM64_H_ > @@ -19,11 +19,11 @@ extern "C" { > #include > #include >=20 > -#define rte_mb() asm volatile("dsb sy" : : : "memory") > +#define rte_mb() asm volatile("dmb osh" : : : "memory") >=20 > -#define rte_wmb() asm volatile("dsb st" : : : "memory") > +#define rte_wmb() asm volatile("dmb oshst" : : : "memory") >=20 > -#define rte_rmb() asm volatile("dsb ld" : : : "memory") > +#define rte_rmb() asm volatile("dmb oshld" : : : "memory") >=20 > #define rte_smp_mb() asm volatile("dmb ish" : : : "memory") >=20 > @@ -37,9 +37,9 @@ extern "C" { >=20 > #define rte_io_rmb() rte_rmb() >=20 > -#define rte_cio_wmb() asm volatile("dmb oshst" : : : "memory") > +#define rte_cio_wmb() rte_wmb() >=20 > -#define rte_cio_rmb() asm volatile("dmb oshld" : : : "memory") > +#define rte_cio_rmb() rte_rmb() >=20 > /*------------------------ 128 bit atomic operations -------------------= ------*/ >=20 > -- > 2.17.1