From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Igor Romanov <igor.romanov@oktetlabs.ru>,
"stable@dpdk.org" <stable@dpdk.org>,
Harry van Haaren <harry.van.haaren@intel.com>, nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices
Date: Tue, 7 Jul 2020 19:33:05 +0000 [thread overview]
Message-ID: <DB6PR0802MB221656C832AC241C3B20B85498660@DB6PR0802MB2216.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1594118726-8421-1-git-send-email-arybchenko@solarflare.com>
<snip>
> Subject: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices
>
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> The service core list is populated, but not used. Incorrect lcore states are
> examined for a service.
>
> Use the populated list to iterate over service cores.
>
> Fixes: e30dd31847d2 ("service: add mechanism for quiescing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
LGTM
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> lib/librte_eal/common/rte_service.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/rte_service.c
> b/lib/librte_eal/common/rte_service.c
> index 6123a2124d..e2795f857e 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id)
> return -EINVAL;
>
> for (i = 0; i < lcore_count; i++) {
> - if (lcore_states[i].service_active_on_lcore[id])
> + if (lcore_states[ids[i]].service_active_on_lcore[id])
> return 1;
> }
>
> --
> 2.17.1
prev parent reply other threads:[~2020-07-07 19:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 14:35 [dpdk-dev] [PATCH] service: fix wrong lcore indexes Andrew Rybchenko
2020-07-04 15:06 ` Honnappa Nagarahalli
2020-07-04 15:10 ` David Marchand
2020-07-06 11:09 ` Andrew Rybchenko
2020-07-06 11:05 ` [dpdk-dev] [PATCH v2 1/2] service: fix wrong lcore indices Andrew Rybchenko
2020-07-06 11:06 ` [dpdk-dev] [PATCH v2 2/2] test/service: add test for service active on two lcores Andrew Rybchenko
2020-07-07 10:45 ` [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices Andrew Rybchenko
2020-07-07 10:45 ` [dpdk-dev] [PATCH v3 2/2] test/service: add test for service active on two lcores Andrew Rybchenko
2020-07-07 13:14 ` Van Haaren, Harry
2020-07-07 19:47 ` Honnappa Nagarahalli
2020-07-07 13:14 ` [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices Van Haaren, Harry
2020-07-07 21:56 ` Thomas Monjalon
2020-07-07 19:33 ` Honnappa Nagarahalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0802MB221656C832AC241C3B20B85498660@DB6PR0802MB2216.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=igor.romanov@oktetlabs.ru \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).