From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1A919A00BE;
	Tue,  7 Jul 2020 21:33:22 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 55A131DE4F;
	Tue,  7 Jul 2020 21:33:21 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60085.outbound.protection.outlook.com [40.107.6.85])
 by dpdk.org (Postfix) with ESMTP id 324D11BFB4;
 Tue,  7 Jul 2020 21:33:20 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; 
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6+XtB+63LrDM/o5KW7NyTbUyh9Q8jWYsioQrS/ZS2c0=;
 b=ZoQ4yCy/Mn/Ouvwo5OHpzzCs1Ylde+xrkqwzffSJ7GYEOSAiJG6gq49HQXIx7SO8WqyRdOZitSQAj0jAP0vsr9Qi8yLqi74Ag9fBdca0EwHuy5c+J4CXS/miJuEoU8N3Q6a3TDw7Gu4hb+FFz2EOW8EhX+tO8RbPiT1mSPiuNMQ=
Received: from MRXP264CA0040.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::28)
 by VI1PR08MB5502.eurprd08.prod.outlook.com (2603:10a6:803:12f::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.29; Tue, 7 Jul
 2020 19:33:18 +0000
Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:500:14:cafe::37) by MRXP264CA0040.outlook.office365.com
 (2603:10a6:500:14::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21 via Frontend
 Transport; Tue, 7 Jul 2020 19:33:18 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.3153.24 via Frontend Transport; Tue, 7 Jul 2020 19:33:18 +0000
Received: ("Tessian outbound 4e683f4039d5:v62");
 Tue, 07 Jul 2020 19:33:17 +0000
X-CR-MTA-TID: 64aa7808
Received: from dffa14652a92.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4C56BFE5-AB6C-4809-8C90-2D9139775663.1; 
 Tue, 07 Jul 2020 19:33:12 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dffa14652a92.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 07 Jul 2020 19:33:12 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fbGZjLcEVaBA/C1RlSLGsWIJIwyHP2Pt6VGvtQjhTQyHHg8qYBQQJSLJYM4U25hZFLa6ZA7tYOwIMzLCApNvMieC0TGLaM3zRyDGAjBviPxuviiCKxBi4yFxG1892fErCD0X9eVN6v+Qx7iIPL03zPN7s5DKAu7FRCfocNpjGHIOxE/MxDKXfkypRnR7eXSXTe2NO7eQPHgc3ecMZClioLWrNRK4mn9h246yWgoJLIPM6Iuos8mjtTDIU6wk52MVvwj14CcKtsUsG6v0S4AukaVufenGfsC+QY4jXAAME0hF9anyZewT5nS6XbT0riCGmatJjxvkmcc90gXXZ8acGQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6+XtB+63LrDM/o5KW7NyTbUyh9Q8jWYsioQrS/ZS2c0=;
 b=Vxd8Goh81r/e1QditITEySNpV1weny5NtWeINeM2UaJ7gw8Ec4JxlcZV0wvM4oIwv33Sh3XIUzwFlpofbHuazsV4/suW6rNFwepUMVKpK2JynWzt9M6KA2s6+HWqzVU58CML5KtHEHIRVcwKrb8gz+Nz8S+9SejaDrhjfBgIlk3pnkuG2I+sJVcOdeSeefY9r4lwc4nE2uT3k6rBf9d/H5eRpaAr5Yu+ft8O6Q4HjyjTDQk37Ws5tAZ5xHnKCzXAvNEUk+8FVMiRFiMq/RKkc9vxKZN14QGwbPdS/UVRJhDPtHRRXudmUYzF52Llw6TLrGgDoDoUri6padTehM5U5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; 
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6+XtB+63LrDM/o5KW7NyTbUyh9Q8jWYsioQrS/ZS2c0=;
 b=ZoQ4yCy/Mn/Ouvwo5OHpzzCs1Ylde+xrkqwzffSJ7GYEOSAiJG6gq49HQXIx7SO8WqyRdOZitSQAj0jAP0vsr9Qi8yLqi74Ag9fBdca0EwHuy5c+J4CXS/miJuEoU8N3Q6a3TDw7Gu4hb+FFz2EOW8EhX+tO8RbPiT1mSPiuNMQ=
Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com (2603:10a6:4:85::9)
 by DB6PR0801MB1734.eurprd08.prod.outlook.com (2603:10a6:4:31::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Tue, 7 Jul
 2020 19:33:10 +0000
Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com
 ([fe80::9d1d:207b:e89d:199d]) by DB6PR0802MB2216.eurprd08.prod.outlook.com
 ([fe80::9d1d:207b:e89d:199d%10]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020
 19:33:05 +0000
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: Igor Romanov <igor.romanov@oktetlabs.ru>, "stable@dpdk.org"
 <stable@dpdk.org>, Harry van Haaren <harry.van.haaren@intel.com>, nd
 <nd@arm.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, nd
 <nd@arm.com>
Thread-Topic: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices
Thread-Index: AQHWVEvPC7X1sWlfz0KyBFTM4K5SCaj8gekw
Date: Tue, 7 Jul 2020 19:33:05 +0000
Message-ID: <DB6PR0802MB221656C832AC241C3B20B85498660@DB6PR0802MB2216.eurprd08.prod.outlook.com>
References: <1593873347-13686-1-git-send-email-arybchenko@solarflare.com>
 <1594118726-8421-1-git-send-email-arybchenko@solarflare.com>
In-Reply-To: <1594118726-8421-1-git-send-email-arybchenko@solarflare.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ts-tracking-id: 16c086bf-7816-4e0b-a4f6-a787e9843b05.0
x-checkrecipientchecked: true
Authentication-Results-Original: solarflare.com; dkim=none (message not
 signed) header.d=none;solarflare.com; dmarc=none action=none
 header.from=arm.com;
x-originating-ip: [70.112.90.121]
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: c22ac56c-ea92-438b-8254-08d822ac99c4
x-ms-traffictypediagnostic: DB6PR0801MB1734:|VI1PR08MB5502:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <VI1PR08MB55024140C9F7418FE98B755E98660@VI1PR08MB5502.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:5236;OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: p6f9HD9GRdRDVbF8Rp5R7Um6J5D5+LPMHQ5UOKHZZz/M0Uk1A2nPIjxD3xIk4k4+OQtGQ1KyzJqsNS29VSzFO+N6uB8wWAA0CxZfu+KeHKN85BozH5BwqkZGUIhPmn7YGhzMoOPBLIABDiuJqYfkptk67hKSo0A1YW79D2j8NDQPUPnWL3YzRjZoCxtx7DMrD9vUA6pfJuxT2XyvmHI0JDeQ5DBmy4ejtX3eUI8rtoXrbge7AJhJYPizlMIudnX2B9dhpCYmOJd1vI2N2ofggnndWZ+fRFxmdXNDYBxAfDdeEBKSLekqtPZGz5dUppoUAGzJljkWMo74SHcGlfHnRA==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en;
 SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2216.eurprd08.prod.outlook.com;
 PTR:; CAT:NONE; SFTY:;
 SFS:(4636009)(39860400002)(366004)(396003)(376002)(136003)(346002)(66476007)(66556008)(6506007)(186003)(66946007)(52536014)(8936002)(316002)(478600001)(110136005)(8676002)(54906003)(83380400001)(86362001)(66446008)(7696005)(9686003)(55016002)(64756008)(71200400001)(2906002)(76116006)(26005)(4326008)(5660300002)(33656002);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata: yhBLJKLiex0kdZDQnz0Dq91Z/I7Dm55iCzn/hWNOBP3qr0hKf3Ig03Y4nxf38EdVx0jjre60l13dQI8I5FhynDio/TAGNKcpRBjboVc8BxFZHNdHpzyFSFFrij1hwd/xV65qw1DkXaG4MlP6sjKsX8Kvzdc+yM0EDSqV9JTK5Y0RnDVbgHITuYHTad13k55iTlbmDqjs54Ysi32WFbP8ZpxwpuXnYnSZuRZBnLMxGSNfoToD8dbemDe4dYwZWl+x6GZLQnhidxxoQZ0o3OVjkQsmndW8GLWPq+3fut+6oFcmaoIq4KVIXzRKbOjSjRqNfEDCA42Z/JDzrSuNQMiQKp4ajYufO8N4UGMESerNHvWZiwjfb8uGcfXhsmwmPH8+X0+9Gbzi2M0Djn1OTDbd+oXJ1XC3ygZz1Sguoa84+HqcqmQnTfpQ4M+pSPeUPpjGkKmT36UGsOPwNBuLLlJvYBtzmcdVts9I/UU2UgNC2GQb3dwdrdaF3T8wCF8JZr6y
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1734
Original-Authentication-Results: solarflare.com; dkim=none (message not signed)
 header.d=none; solarflare.com;
 dmarc=none action=none header.from=arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;
 IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;
 PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:;
 SFS:(4636009)(346002)(376002)(136003)(396003)(39860400002)(46966005)(36906005)(81166007)(316002)(82740400003)(356005)(450100002)(54906003)(47076004)(110136005)(4326008)(70206006)(70586007)(5660300002)(7696005)(86362001)(2906002)(186003)(336012)(6506007)(52536014)(33656002)(26005)(82310400002)(478600001)(55016002)(9686003)(83380400001)(8676002)(8936002);
 DIR:OUT; SFP:1101; 
X-MS-Office365-Filtering-Correlation-Id-Prvs: 38c8d509-2bda-4c8d-bb85-08d822ac9202
X-Forefront-PRVS: 0457F11EAF
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: W+EZCVWXzdYV9rH/QsQo88kkdWXNo98kxkKQzyr8B7H+cgT94PSgRfic4sdhj7aLoEzQ4SclpMOjwPJxEafTA9K2m4QD8x2mtbK+jW74Aqk1Wa0Wn/RXE3EFoCIVoJ8APz/2jX7r5uTF2+a/kjyDND67HsmhRp7IMAQQrCkzSMwYuQIaodG00xeRcIYyABvyqskvBn4kXEmjtvgeeTlayNqmHSCMrVQDCArcwbSVkmhfLubaSb7Hs7+fJdqScIBdcj8360hl82IKfCP6ME44752QMq+d4GovEJGjXUb/sPRUeyEOFrb/6R2952D0/ynpR+LcdiaTTUZp4pdAfGkwgfed0c6+3lEwE+TdPGzCQ3tfYEdwcAtCHvGmVlczeNB4c1Xnh24ip1MGJzOMHvwyQg==
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2020 19:33:18.0954 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c22ac56c-ea92-438b-8254-08d822ac99c4
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];
 Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5502
Subject: Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

<snip>

> Subject: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices
>=20
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>=20
> The service core list is populated, but not used. Incorrect lcore states =
are
> examined for a service.
>=20
> Use the populated list to iterate over service cores.
>=20
> Fixes: e30dd31847d2 ("service: add mechanism for quiescing")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

LGTM
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> ---
>  lib/librte_eal/common/rte_service.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/lib/librte_eal/common/rte_service.c
> b/lib/librte_eal/common/rte_service.c
> index 6123a2124d..e2795f857e 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id)
>  		return -EINVAL;
>=20
>  	for (i =3D 0; i < lcore_count; i++) {
> -		if (lcore_states[i].service_active_on_lcore[id])
> +		if (lcore_states[ids[i]].service_active_on_lcore[id])
>  			return 1;
>  	}
>=20
> --
> 2.17.1