From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> To: Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: Igor Romanov <igor.romanov@oktetlabs.ru>, Harry van Haaren <harry.van.haaren@intel.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, nd <nd@arm.com>, nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH v3 2/2] test/service: add test for service active on two lcores Date: Tue, 7 Jul 2020 19:47:39 +0000 Message-ID: <DB6PR0802MB2216819ED25A3142BC22BE6A98660@DB6PR0802MB2216.eurprd08.prod.outlook.com> (raw) In-Reply-To: <1594118726-8421-2-git-send-email-arybchenko@solarflare.com> > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Andrew Rybchenko > Sent: Tuesday, July 7, 2020 5:45 AM > To: dev@dpdk.org > Cc: Igor Romanov <igor.romanov@oktetlabs.ru>; Harry van Haaren > <harry.van.haaren@intel.com> > Subject: [dpdk-dev] [PATCH v3 2/2] test/service: add test for service active on > two lcores > > From: Igor Romanov <igor.romanov@oktetlabs.ru> > > The test checks that the service may be active API works when there are two > cores: a non-service lcore and a service one. > > The API notes to take care when checking the status of a running service, but > the test setup allows for a safe usage in that case. > > Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > --- > v3: > - skip the test if number of cores is insufficient > > app/test/test_service_cores.c | 54 +++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c index > 981e212130..4f003ed1af 100644 > --- a/app/test/test_service_cores.c > +++ b/app/test/test_service_cores.c > @@ -910,6 +910,59 @@ service_may_be_active(void) > return unregister_all(); > } > > +/* check service may be active when service is running on a second > +lcore */ static int > +service_active_two_cores(void) > +{ > + if (!rte_lcore_is_enabled(0) || !rte_lcore_is_enabled(1) || > + !rte_lcore_is_enabled(2)) > + return TEST_SKIPPED; > + > + const uint32_t sid = 0; > + int i; > + > + uint32_t lcore = rte_get_next_lcore(/* start core */ -1, > + /* skip master */ 1, > + /* wrap */ 0); > + uint32_t slcore = rte_get_next_lcore(/* start core */ lcore, > + /* skip master */ 1, > + /* wrap */ 0); > + > + /* start the service on the second available lcore */ > + TEST_ASSERT_EQUAL(0, rte_service_runstate_set(sid, 1), > + "Starting valid service failed"); > + TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore), > + "Add service core failed when not in use before"); > + TEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(sid, slcore, 1), > + "Enabling valid service on valid core failed"); > + TEST_ASSERT_EQUAL(0, rte_service_lcore_start(slcore), > + "Service core start after add failed"); > + > + /* ensures core really is running the service function */ > + TEST_ASSERT_EQUAL(1, service_lcore_running_check(), > + "Service core expected to poll service but it didn't"); > + > + /* ensures that service may be active reports running state */ > + TEST_ASSERT_EQUAL(1, rte_service_may_be_active(sid), > + "Service may be active did not report running state"); > + > + /* stop the service */ > + TEST_ASSERT_EQUAL(0, rte_service_runstate_set(sid, 0), > + "Error: Service stop returned non-zero"); > + > + /* give the service 100ms to stop running */ > + for (i = 0; i < 100; i++) { > + if (!rte_service_may_be_active(sid)) > + break; > + rte_delay_ms(SERVICE_DELAY); > + } > + > + TEST_ASSERT_EQUAL(0, rte_service_may_be_active(sid), > + "Error: Service not stopped after 100ms"); > + > + return unregister_all(); > +} > + > static struct unit_test_suite service_tests = { > .suite_name = "service core test suite", > .setup = testsuite_setup, > @@ -931,6 +984,7 @@ static struct unit_test_suite service_tests = { > TEST_CASE_ST(dummy_register, NULL, > service_app_lcore_mt_safe), > TEST_CASE_ST(dummy_register, NULL, > service_app_lcore_mt_unsafe), > TEST_CASE_ST(dummy_register, NULL, service_may_be_active), > + TEST_CASE_ST(dummy_register, NULL, > service_active_two_cores), > TEST_CASES_END() /**< NULL terminate unit test array */ > } > }; > -- > 2.17.1
next prev parent reply other threads:[~2020-07-07 19:47 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-04 14:35 [dpdk-dev] [PATCH] service: fix wrong lcore indexes Andrew Rybchenko 2020-07-04 15:06 ` Honnappa Nagarahalli 2020-07-04 15:10 ` David Marchand 2020-07-06 11:09 ` Andrew Rybchenko 2020-07-06 11:05 ` [dpdk-dev] [PATCH v2 1/2] service: fix wrong lcore indices Andrew Rybchenko 2020-07-06 11:06 ` [dpdk-dev] [PATCH v2 2/2] test/service: add test for service active on two lcores Andrew Rybchenko 2020-07-07 10:45 ` [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices Andrew Rybchenko 2020-07-07 10:45 ` [dpdk-dev] [PATCH v3 2/2] test/service: add test for service active on two lcores Andrew Rybchenko 2020-07-07 13:14 ` Van Haaren, Harry 2020-07-07 19:47 ` Honnappa Nagarahalli [this message] 2020-07-07 13:14 ` [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices Van Haaren, Harry 2020-07-07 21:56 ` Thomas Monjalon 2020-07-07 19:33 ` Honnappa Nagarahalli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB6PR0802MB2216819ED25A3142BC22BE6A98660@DB6PR0802MB2216.eurprd08.prod.outlook.com \ --to=honnappa.nagarahalli@arm.com \ --cc=arybchenko@solarflare.com \ --cc=dev@dpdk.org \ --cc=harry.van.haaren@intel.com \ --cc=igor.romanov@oktetlabs.ru \ --cc=nd@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git