From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B198A053D; Tue, 4 Aug 2020 01:16:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD562F64; Tue, 4 Aug 2020 01:16:50 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2046.outbound.protection.outlook.com [40.107.22.46]) by dpdk.org (Postfix) with ESMTP id AEE1F255 for ; Tue, 4 Aug 2020 01:16:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EBVmCLorrznFYxdI02yrzttepjaeztySjrC/OT3SJYY=; b=cbp5jpWUZGTM3pm9hZrMXnYb3EDqg+v0d0g6EaVJWI8PUcffrYDAGV74tiy2G6gOJeiOVgnfjB+NtbDSygcuW7WBrMF68aGKI4DCEvxHZlKC7nJDsysPBch1yPpBRyeobO1uuNVnoc7/rSDWZYxWCt1WIUQ4niBuTngNXLhQS9M= Received: from MR2P264CA0072.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::36) by AM5PR0801MB1875.eurprd08.prod.outlook.com (2603:10a6:203:43::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.20; Mon, 3 Aug 2020 23:16:48 +0000 Received: from VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:31:cafe::7) by MR2P264CA0072.outlook.office365.com (2603:10a6:500:31::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Mon, 3 Aug 2020 23:16:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT036.mail.protection.outlook.com (10.152.19.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Mon, 3 Aug 2020 23:16:47 +0000 Received: ("Tessian outbound 55d887bbc0e0:v63"); Mon, 03 Aug 2020 23:16:47 +0000 X-CR-MTA-TID: 64aa7808 Received: from 018e041e7ea2.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 61280668-C530-46DA-9465-4FF141C0C5C5.1; Mon, 03 Aug 2020 23:16:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 018e041e7ea2.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 03 Aug 2020 23:16:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=grCSNZv+CGFF6DR1IsZYI7D3GIBs92iV9Acy4PuSxLvh+uD7x46oHsRdi9fjuNisF2Ozj9cEe3RUONlcSk2nVcKHc+Yu9v3SZDfEB4Vymqhd+msfNMFzO0yRQ+t68E4ltO6EmNm0wa/kBVOMhfrcXWMjdM7BnkSRMpLTYv9VNS138+4CmXJ4VuU4ue5h60u1g5TtUpSZZ6bhrKx0GJz8QiysZvI8XBRt7MAj+RoTj6X1m9haxrH7JZisT8cp+eDy+m7BlpfhZLlGz00ybQvCztoHX1gbQqTBWa0abkCCJ8yG0kSw5Nw2jVkrA7Ju9M3CLOtaPcGg4CZ0cv4LWPHbyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EBVmCLorrznFYxdI02yrzttepjaeztySjrC/OT3SJYY=; b=CYwgGu8Q30xUKqmpkrouWr4EJhV8D18rpATpb+/nD6uNDllAJFNl1pWxHxhV2O6IbvftjN0iFZ2WgXV8s8bvS3+inN/2G0RCuQudmZ81gDFRQ0soMrf2zn2p9bUUh0zGd+rXoWABrE0qBRcmDHfEqFz2o3eP/50oE4BsXuf6n9MzD0wqrKVpFOzFKllaVITNgY/wN07S0QoBYyLq3j4eeqHcX9ZL7QkS8t8ATPXzL6CGafQIkOIzcMEqa5ebUE5IfWd9hwFKLzkrxtgmD9NCRLL8L664CbxeNhc5N9fAW1xVNAvL6RShJIpShfPQIgJyInLXiZ3chqnGimy2Okp2NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EBVmCLorrznFYxdI02yrzttepjaeztySjrC/OT3SJYY=; b=cbp5jpWUZGTM3pm9hZrMXnYb3EDqg+v0d0g6EaVJWI8PUcffrYDAGV74tiy2G6gOJeiOVgnfjB+NtbDSygcuW7WBrMF68aGKI4DCEvxHZlKC7nJDsysPBch1yPpBRyeobO1uuNVnoc7/rSDWZYxWCt1WIUQ4niBuTngNXLhQS9M= Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com (2603:10a6:4:85::9) by DB7PR08MB3786.eurprd08.prod.outlook.com (2603:10a6:10:79::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17; Mon, 3 Aug 2020 23:16:40 +0000 Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::9d1d:207b:e89d:199d]) by DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::9d1d:207b:e89d:199d%10]) with mapi id 15.20.3239.021; Mon, 3 Aug 2020 23:16:40 +0000 From: Honnappa Nagarahalli To: Sarosh Arif , "erik.g.carrillo@intel.com" , "rsanford@akamai.com" CC: "dev@dpdk.org" , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH] doc: announce API change in timer Thread-Index: AQHWaYheCI+4ZokFAk+DUZ/W4BGL76knAx8g Date: Mon, 3 Aug 2020 23:16:40 +0000 Message-ID: References: <20200803112059.23328-1-sarosh.arif@emumba.com> In-Reply-To: <20200803112059.23328-1-sarosh.arif@emumba.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 602d3a4d-c0dd-40fd-bc10-20aaac13a4c4.0 x-checkrecipientchecked: true Authentication-Results-Original: emumba.com; dkim=none (message not signed) header.d=none;emumba.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f209f00f-dfb2-48f2-be5e-08d838034bbf x-ms-traffictypediagnostic: DB7PR08MB3786:|AM5PR0801MB1875: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zEduw7zJ/H3CtQCkIg+TXvOI8CH9pCc6NeSOSJLeiFF7bs1Uz4oJiKqnuOy+XiYxT2ZSbImcmoPhy+rHumO/GOlWhtLor5I4J6w2dhHgbVgsd++4G6mvm7kJCV/FGdp3X38T6tEmclw36YsLPIPyrbIl+tZz4Lzob+1bJsAUjKMY5zdgW/ChzC6W9tItmlfvmToqUwDnS6RsHd64A4Zj2VZFYM81tpUtin3cY/T/02GpRIGfD/K1mThE5Nc8qMhC/UzxRQPh3sOeqfkyJht0E80FSz6y5h71+gCEl9KfziVCuG2aikEOrZjv/Tz4g6328TJZ2Hzfh+sTHY0WDvNtsQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2216.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(376002)(39860400002)(136003)(396003)(71200400001)(7696005)(110136005)(54906003)(86362001)(316002)(52536014)(186003)(33656002)(5660300002)(6506007)(8936002)(66946007)(8676002)(55016002)(66446008)(64756008)(66556008)(66476007)(478600001)(83380400001)(26005)(76116006)(4326008)(9686003)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: JskclyEGDBWiLvmuMWO3vxt0VJWVlH9Z1LJnnvQVEm/cWnhOImzsLbyF6bIrO8/Z610qf7tSvPxZevz4HXwQWDa6GPLKHEq3dTk2yJ2x2aeYTkqfJH+h6L1ETJDkFofYTpKNnVhNJeG5xxrGNqB6DA1RlQN1eLWOi7zs+BEq9efzstvSu2RRkRIYTasLON0V2vCii8eSF1jhCrhrXxY+ilbg0rzkEX5aS0sjO7oaMmIiJl2akDvXKmwYxufaNvi5h1k4aVXKQvB8P+gjBiborgw9+7QXRwIFQ9HuGwbm/tJ1WWZu/UdnHvCzgt40g9i9rpFq7hdkbGWnG5+3sxcN+58laKJig/c3l5SpZGQFc5bHBgi3TlPeq5LvdZKqMPjZrS3JVReFKlsV5M8+SPLjLd/3QJijqstVRp01S1Wa4BwpNYywtcw70Sfrh3LqL+aPPIHW82zq0Ae8WjWAMlT5dTIcop9CJQjoJU7Hyy4zSfTBHDkIPmJn3wN/7FYXLtBkxyuQcv+lxiwzfWwl2xzff8sTmEL2DWvv4BLerd8pfp9K/RHaVMOZHcBq6iae3C2EPjR883HhlnZybu4SMvRM4pytHiZ9vD98GypfIb4pbwhPlqVfJ6e6TtKNJwPqsmE/DU9UMOzhrMB/y7LIXCv2+g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3786 Original-Authentication-Results: emumba.com; dkim=none (message not signed) header.d=none;emumba.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 03b8175a-a23c-46d1-55d0-08d83803473f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5DVFg9taefCUCtnjb3+ZEE/9YsJBejLGFlER3tWGrDmXiyA2WnXU1i8wb5MGiAjM3A+ttdEsIexOlN8ShuP61FhxYKASgOA5hwgDy4XfYqZ9Y3W2LAxfwyqxjydeCC5mLa2dxyVSKt7NVKC4/DCniuEpGCw0fwsAz5wnt2NI4rx2DTWWHSv/kC2LehOgn6ZGmctjZJfUSlMrjgOwHynux0xXvH75bFXa6ZQm06abm1rFf9sYMVypTqkOCSNEPVUXOPnBnH+xjIqTqeg0gD+InPaT2nGP+Lo10IZj+c4ZZfULIQamnaIkMsRKZPrFDbsuWHTb/QTUTFhajQGYcDwg53ObCt9u2GQu/tT8IAInMxtIsSEeMicwgSI3/9/ZdF60MhV22tL/4lNIVlQe+00E0w== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(39860400002)(396003)(136003)(46966005)(26005)(186003)(54906003)(336012)(2906002)(33656002)(70206006)(52536014)(86362001)(55016002)(8936002)(4326008)(82310400002)(47076004)(82740400003)(356005)(81166007)(9686003)(70586007)(110136005)(478600001)(316002)(7696005)(36906005)(8676002)(5660300002)(6506007)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2020 23:16:47.8730 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f209f00f-dfb2-48f2-be5e-08d838034bbf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1875 Subject: Re: [dpdk-dev] [PATCH] doc: announce API change in timer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > If the user tries to reset/stop some other timer in it's callback functio= n, which Is there any use case for this? Why not just say document that the user is = not allowed to reset some other timer in the call back function? How does t= he user get access to some other timer in the call back function? Not sure if this was discussed earlier, I might have missed. > is also about to expire, using rte_timer_reset_sync/rte_timer_stop_sync t= he > application goes into an infinite loop. This happens because > rte_timer_reset_sync/rte_timer_stop_sync loop until the timer resets/stop= s > and there is check inside timer_set_config_state which prevents a running > timer from being reset/stopped by not it's own timer_cb. Therefore > timer_set_config_state returns -1 due to which rte_timer_reset returns -1= and > rte_timer_reset_sync goes into an infinite loop >=20 > To to prevent this rte_timer_reset_sync and rte_timer_stop_sync should ha= ve > int return types, so that -1 can be returned if the above condition occur= s >=20 > Signed-off-by: Sarosh Arif > --- > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index ea4cfa7a4..ed93a707d 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -151,3 +151,9 @@ Deprecation Notices > Python 2 support will be completely removed in 20.11. > In 20.08, explicit deprecation warnings will be displayed when running > scripts with Python 2. > + > +* timer: Since timer can get stuck in an infinite loop if the > +application tries to > + reset/stop some other timer in it's callback function, which is also > +about to > + expire. The function ``rte_timer_stop_sync`` and > +``rte_timer_stop_sync`` will > + have a int return type in order to return with -1 in when this > +condition > + occures. > -- > 2.17.1