* Re: [dpdk-dev] [PATCH] eal: change the log level for test assert macro
2020-07-15 20:20 ` [dpdk-dev] [PATCH] eal: change the log level for test assert macro Honnappa Nagarahalli
@ 2020-07-16 13:00 ` Aaron Conole
2020-07-16 18:40 ` Honnappa Nagarahalli
2020-07-16 15:06 ` David Marchand
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Aaron Conole @ 2020-07-16 13:00 UTC (permalink / raw)
To: Honnappa Nagarahalli; +Cc: dev, david.marchand, l.wojciechow, nd
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> writes:
> Change the log level for RTE_TEST_ASSERT macro to error to help
> log errors while running test cases.
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
Is the default to always have ERROR log level on? If so:
Acked-by: Aaron Conole <aconole@redhat.com>
:-)
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] eal: change the log level for test assert macro
2020-07-16 13:00 ` Aaron Conole
@ 2020-07-16 18:40 ` Honnappa Nagarahalli
0 siblings, 0 replies; 8+ messages in thread
From: Honnappa Nagarahalli @ 2020-07-16 18:40 UTC (permalink / raw)
To: Aaron Conole
Cc: dev, david.marchand, l.wojciechow, nd, Honnappa Nagarahalli, nd
<snip>
> Subject: Re: [PATCH] eal: change the log level for test assert macro
>
> Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> writes:
>
> > Change the log level for RTE_TEST_ASSERT macro to error to help log
> > errors while running test cases.
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > ---
>
> Is the default to always have ERROR log level on? If so:
It is on currently
>
> Acked-by: Aaron Conole <aconole@redhat.com>
>
> :-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: change the log level for test assert macro
2020-07-15 20:20 ` [dpdk-dev] [PATCH] eal: change the log level for test assert macro Honnappa Nagarahalli
2020-07-16 13:00 ` Aaron Conole
@ 2020-07-16 15:06 ` David Marchand
2020-07-16 18:41 ` Honnappa Nagarahalli
2020-07-16 15:16 ` Lukasz Wojciechowski
2020-07-16 18:39 ` [dpdk-dev] [PATCH v2] " Honnappa Nagarahalli
3 siblings, 1 reply; 8+ messages in thread
From: David Marchand @ 2020-07-16 15:06 UTC (permalink / raw)
To: Thomas Monjalon, Yigit, Ferruh, Jerin Jacob Kollanukkaran,
Hemant Agrawal, Nipun Gupta, Pavan Nikhilesh
Cc: dev, Lukasz Wojciechowski, Aaron Conole, nd, Honnappa Nagarahalli
On Wed, Jul 15, 2020 at 10:20 PM Honnappa Nagarahalli
<honnappa.nagarahalli@arm.com> wrote:
>
> Change the log level for RTE_TEST_ASSERT macro to error to help
> log errors while running test cases.
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> lib/librte_eal/include/rte_test.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/include/rte_test.h b/lib/librte_eal/include/rte_test.h
> index 89e47f47a..62c8f165a 100644
> --- a/lib/librte_eal/include/rte_test.h
> +++ b/lib/librte_eal/include/rte_test.h
> @@ -18,7 +18,7 @@
>
> #define RTE_TEST_ASSERT(cond, msg, ...) do { \
> if (!(cond)) { \
> - RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
> + RTE_LOG(ERR, EAL, "Test assert %s line %d failed: " \
> msg "\n", __func__, __LINE__, ##__VA_ARGS__); \
> RTE_TEST_TRACE_FAILURE(__FILE__, __LINE__, __func__); \
> return -1; \
> --
> 2.17.1
>
I proposed it, so I can't disagree :-)
RTE_TEST_ASSERT* are used in eventdev driver selftests.
I don't see why more output in error cases would be detrimental.
Any objection?
Thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] eal: change the log level for test assert macro
2020-07-16 15:06 ` David Marchand
@ 2020-07-16 18:41 ` Honnappa Nagarahalli
0 siblings, 0 replies; 8+ messages in thread
From: Honnappa Nagarahalli @ 2020-07-16 18:41 UTC (permalink / raw)
To: David Marchand, thomas, Yigit, Ferruh, jerinj, hemant.agrawal,
Nipun.gupta@nxp.com, Pavan Nikhilesh
Cc: dev, Lukasz Wojciechowski, Aaron Conole, nd, Honnappa Nagarahalli, nd
<snip>
> Subject: Re: [PATCH] eal: change the log level for test assert macro
>
> On Wed, Jul 15, 2020 at 10:20 PM Honnappa Nagarahalli
> <honnappa.nagarahalli@arm.com> wrote:
> >
> > Change the log level for RTE_TEST_ASSERT macro to error to help log
> > errors while running test cases.
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > ---
> > lib/librte_eal/include/rte_test.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/include/rte_test.h
> > b/lib/librte_eal/include/rte_test.h
> > index 89e47f47a..62c8f165a 100644
> > --- a/lib/librte_eal/include/rte_test.h
> > +++ b/lib/librte_eal/include/rte_test.h
> > @@ -18,7 +18,7 @@
> >
> > #define RTE_TEST_ASSERT(cond, msg, ...) do { \
> > if (!(cond)) { \
> > - RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
> > + RTE_LOG(ERR, EAL, "Test assert %s line %d failed: " \
> > msg "\n", __func__, __LINE__, ##__VA_ARGS__); \
> > RTE_TEST_TRACE_FAILURE(__FILE__, __LINE__, __func__); \
> > return -1; \
> > --
> > 2.17.1
> >
>
> I proposed it, so I can't disagree :-)
Forgot to add you to suggested-by. Fixed it in v2 😊
>
> RTE_TEST_ASSERT* are used in eventdev driver selftests.
> I don't see why more output in error cases would be detrimental.
> Any objection?
>
> Thanks.
>
> --
> David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: change the log level for test assert macro
2020-07-15 20:20 ` [dpdk-dev] [PATCH] eal: change the log level for test assert macro Honnappa Nagarahalli
2020-07-16 13:00 ` Aaron Conole
2020-07-16 15:06 ` David Marchand
@ 2020-07-16 15:16 ` Lukasz Wojciechowski
2020-07-16 18:39 ` [dpdk-dev] [PATCH v2] " Honnappa Nagarahalli
3 siblings, 0 replies; 8+ messages in thread
From: Lukasz Wojciechowski @ 2020-07-16 15:16 UTC (permalink / raw)
To: Honnappa Nagarahalli, dev, david.marchand, aconole; +Cc: nd
W dniu 15.07.2020 o 22:20, Honnappa Nagarahalli pisze:
> Change the log level for RTE_TEST_ASSERT macro to error to help
> log errors while running test cases.
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> lib/librte_eal/include/rte_test.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/include/rte_test.h b/lib/librte_eal/include/rte_test.h
> index 89e47f47a..62c8f165a 100644
> --- a/lib/librte_eal/include/rte_test.h
> +++ b/lib/librte_eal/include/rte_test.h
> @@ -18,7 +18,7 @@
>
> #define RTE_TEST_ASSERT(cond, msg, ...) do { \
> if (!(cond)) { \
> - RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
> + RTE_LOG(ERR, EAL, "Test assert %s line %d failed: " \
> msg "\n", __func__, __LINE__, ##__VA_ARGS__); \
> RTE_TEST_TRACE_FAILURE(__FILE__, __LINE__, __func__); \
> return -1; \
Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
--
Lukasz Wojciechowski
Principal Software Engineer
Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciechow@partner.samsung.com
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH v2] eal: change the log level for test assert macro
2020-07-15 20:20 ` [dpdk-dev] [PATCH] eal: change the log level for test assert macro Honnappa Nagarahalli
` (2 preceding siblings ...)
2020-07-16 15:16 ` Lukasz Wojciechowski
@ 2020-07-16 18:39 ` Honnappa Nagarahalli
2020-07-17 8:54 ` David Marchand
3 siblings, 1 reply; 8+ messages in thread
From: Honnappa Nagarahalli @ 2020-07-16 18:39 UTC (permalink / raw)
To: dev, honnappa.nagarahalli, david.marchand, l.wojciechow, aconole; +Cc: nd
Change the log level for RTE_TEST_ASSERT macro to error to help
log errors while running test cases.
Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Aaron Conole <aconole@redhat.com>
Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
---
v2 - Added the suggested-by tag
lib/librte_eal/include/rte_test.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/include/rte_test.h b/lib/librte_eal/include/rte_test.h
index 89e47f47a..62c8f165a 100644
--- a/lib/librte_eal/include/rte_test.h
+++ b/lib/librte_eal/include/rte_test.h
@@ -18,7 +18,7 @@
#define RTE_TEST_ASSERT(cond, msg, ...) do { \
if (!(cond)) { \
- RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ RTE_LOG(ERR, EAL, "Test assert %s line %d failed: " \
msg "\n", __func__, __LINE__, ##__VA_ARGS__); \
RTE_TEST_TRACE_FAILURE(__FILE__, __LINE__, __func__); \
return -1; \
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v2] eal: change the log level for test assert macro
2020-07-16 18:39 ` [dpdk-dev] [PATCH v2] " Honnappa Nagarahalli
@ 2020-07-17 8:54 ` David Marchand
0 siblings, 0 replies; 8+ messages in thread
From: David Marchand @ 2020-07-17 8:54 UTC (permalink / raw)
To: Honnappa Nagarahalli
Cc: dev, Lukasz Wojciechowski, Aaron Conole, nd,
Jerin Jacob Kollanukkaran, Hemant Agrawal, Nipun Gupta,
Pavan Nikhilesh
On Thu, Jul 16, 2020 at 8:39 PM Honnappa Nagarahalli
<honnappa.nagarahalli@arm.com> wrote:
>
> Change the log level for RTE_TEST_ASSERT macro to error to help
> log errors while running test cases.
>
> Suggested-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Acked-by: Aaron Conole <aconole@redhat.com>
> Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
We need this patch for the CI.
The change looks safe to me, so I went and applied it without waiting
for feedback from eventdev guys.
Thanks Honnappa.
--
David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread