From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAC8AA0555; Wed, 19 Feb 2020 06:58:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8D961BF78; Wed, 19 Feb 2020 06:58:07 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2097.outbound.protection.outlook.com [40.107.21.97]) by dpdk.org (Postfix) with ESMTP id 33FC51B13C for ; Wed, 19 Feb 2020 06:58:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F65hFJeskr6KoHSPwwDCGwX5mHDG23gYWcPlSGZIo5+mY5aES57A6d1J6vHNnwcLhoq3bd+bd0TzEEgTWXBPUleXU/UFj1fLJ1AmjTAHhqXsKSSvFDN66MGiU3KPpSkxOezDGB5uNeZWLouh1t6SGDuIQFya7OpMoA9Ww9qa4CCJP/qo6uWMBBIGHsxYL8JSmwrz3VSTHv5aiIHGDwIqdrAb2dyT5UAriCKLbgH+l676btS/muqslWyQi3CKrN7QnxzlsaQOtKAe8sjTZ6Ta3KgiqZiK3pVHu1nhZDgoX3vKPSTAqK/yjwXJtmTF+SOHo2GV/d4MZ/Nf4L2JyuPQWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sokZB4c3bKi6DB/DhSyunBlZ2xE4AdqUA5r13LXqSLA=; b=jfwHB9Fw9kTlXSUXC6qcgUK3LpH49qCBt8bOA+JvfJX2qoRO88peHym3H0YnnTLwDyxeRzymypa9/dlUPy8f5gp+VbvM2eXRs7oEiFIGr781B1nEXCmFjh6hAwmUtDWmFLJEDVj2uEUPZ0Lub1xWQYfu5+VsIkbuZrxSoqPh2/XMIM636vyjqNkUVWhmrWNemg5Wpk1YPBl76X4iglE40iWmKuDeGqsOFNvAJui+oFTQ4G5RrImnC1qsSL2TjuZrwfdXY+PSCDNBwPXQ3O8pZGDOKRsv8DALTZFKQatYB3xgwTU6j2s3Ok33fRbxcd7hkTASM1fuI/WTMVnG5QkGyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom.co.il; dmarc=pass action=none header.from=silicom.co.il; dkim=pass header.d=silicom.co.il; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sokZB4c3bKi6DB/DhSyunBlZ2xE4AdqUA5r13LXqSLA=; b=kKsugRrCesJxYtsR0hyg2zNTIMFaaaxSAxH4q1XUaVLyxPdCbbuStqeJQiW6xtgX8QQ/ZPcR92Rhg75v/3VQv4fcYea5qLMVwrVl9H1TpQlyU1RAubx0+B0wQX5bjJBjKXZjYCksECjYyhTITWE4drqf5hl3BEOWFABCJ45cZwI= Received: from DB7PR04MB5196.eurprd04.prod.outlook.com (20.176.234.140) by DB7PR04MB4425.eurprd04.prod.outlook.com (52.135.140.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Wed, 19 Feb 2020 05:58:04 +0000 Received: from DB7PR04MB5196.eurprd04.prod.outlook.com ([fe80::a400:f6b9:34b1:ed]) by DB7PR04MB5196.eurprd04.prod.outlook.com ([fe80::a400:f6b9:34b1:ed%5]) with mapi id 15.20.2729.032; Wed, 19 Feb 2020 05:58:03 +0000 From: Xiaojun Liu To: "Wang, Xiao W" CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Fornal, Jakub" , "Keller, Jacob E" , Jeff Zheng , Eyal Cohen Thread-Topic: [PATCH v2 0/7] support switch management Thread-Index: AQHVsAigriNscwtQbUeBgjjdweYzFKf0qTOggAA4zbCAIUVWkIAEOYeLgAfnJ1M= Date: Wed, 19 Feb 2020 05:58:02 +0000 Message-ID: References: <1576057875-7677-1-git-send-email-xiaojun.liu@silicom.co.il> , , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiaojun.liu@silicom.co.il; x-originating-ip: [96.8.121.220] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 72ba16b5-3dea-487b-91e7-08d7b500aeab x-ms-traffictypediagnostic: DB7PR04MB4425: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0318501FAE x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39850400004)(346002)(366004)(376002)(396003)(136003)(189003)(199004)(76116006)(107886003)(44832011)(19627405001)(478600001)(91956017)(966005)(52536014)(64756008)(5660300002)(4326008)(54906003)(66556008)(81156014)(66476007)(81166006)(66946007)(66446008)(71200400001)(8936002)(6506007)(86362001)(8676002)(316002)(186003)(9686003)(55016002)(2906002)(53546011)(33656002)(26005)(7696005)(6916009)(21314003); DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR04MB4425; H:DB7PR04MB5196.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: silicom.co.il does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +3Vp6tpibjiGl6pcGO/Li+i8aJNAn19HqL3nj3rUcDE4Xxf1W/+JvKMvXnSgcFCu99Y4oKmcM1mqaQPZKehWoi9WBtigHKtR5gs8I9Lz5OieKwJiQHYMBtcfVmuDjoHuhfVbmLOIY41m0jZtzaynp7HmY+PX8X1qKCfN9oV9PsKy3yYL82SuOc/0ZpOs9k3WtInzMh7BnxuhGUm+e/UzVQKC2PfIUdWQkj+21sylmG9FkKNr15mu9oXRLcJIiRZVgMDnW65lVu209kYkJb2qNXrA7CjUuNdOZOYh06QSw8DTLdY0WIOh2oOTsjyKNSfeqFSICltx5FBBW64wKL2E1HyFODoOTtUh1bB7/a7KpCEdSIjywypt/XJEElyJOSwW5fHsfFdj/ojiC9ZI8AhmlRh2KKcy+tpc5AFN4W3iWj+WS+I9PwljW1K/mHGg5i7GBoAl/aijsKzWVqrwVVeeOpBPNexRHmrXRPAy6w0ynMd15CU60H68UU74qTXz74Rzsp2zzd70xjgINloKeNxWXpzdBNRTJeDtgUZ7uBvLTd7JX+zgu/nVfkRsNew5BqUU x-ms-exchange-antispam-messagedata: bzRspujqgOVu5HzVLpmlw5YgkcemqcBoww/rLt3lTz6i+eeMrfN0NpAR/GadPUkcaZ0jj1EUOZ8hceJzErolOQUncqNKw3n6NcUYdAPrvy46EKxQi9+GOoI5rtT24K8v2nm99eAT0JLGLXnnZeRC0A== MIME-Version: 1.0 X-OriginatorOrg: silicom.co.il X-MS-Exchange-CrossTenant-Network-Message-Id: 72ba16b5-3dea-487b-91e7-08d7b500aeab X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2020 05:58:03.0062 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZYUzSV1LjugKTb2/dZe0diGbzOE9tFQcRA007I4BmLPD2Uabnf2NboHZAy21dGVQWtz+0Qn8yW8u5WV2rqyLXc8n7NT3BrpTGLIuIzCpg5w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4425 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 0/7] support switch management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiao, I have already finished the fixing. Thank you for your helping so much. I still have some questions. 1. Shall I generate the patch based on old patches ? 2. I used checkpatches.sh+check-git-log.sh+test-build.sh to check the pa= tch, is that enough ? 3. May I send the patch to you first ? So you can help checking it befor= e I submit. Best regards, Xiaojun ________________________________ From: dev on behalf of Xiaojun Liu Sent: Friday, February 14, 2020 10:46 AM To: Wang, Xiao W Cc: dev@dpdk.org ; Zhang, Qi Z ; Kwan, = Ngai-mint ; Fornal, Jakub ; Keller, Jacob E ; Jeff Zheng ; Eyal Cohen Subject: Re: [dpdk-dev] [PATCH v2 0/7] support switch management hi Xiao, Thanks for your comments! I will fix them ASAP. Best regards, Xiaojun ________________________________ From: Wang, Xiao W Sent: Tuesday, February 11, 2020 6:31 PM To: Xiaojun Liu Cc: dev@dpdk.org ; Zhang, Qi Z ; Kwan, = Ngai-mint ; Fornal, Jakub ; Keller, Jacob E ; Jeff Zheng ; Eyal Cohen Subject: RE: [PATCH v2 0/7] support switch management Since this is a big code change, so just some general comments/suggestions = for your next version patch set: - please clean up comments like "XXX" in the code. - It's better to define MACRO for all register addrs and bit shift, please = try to avoid magic number (e.g. in the serdes part). - There're threads created for handling events and timers, we'd better use = pthread_join() to recycle them in fm10k_sm_detach(). - set "tapstop" and "shiftwidth" to 8 in vimrc, then recheck the macros and= keep them aligned. - There're some "printf" for debugging, please use dpdk logging API instead= . Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Tuesday, January 21, 2020 2:15 PM > To: Wang, Xiao W > Cc: dev@dpdk.org; Zhang, Qi Z ; Kwan, Ngai-mint > ; jakub.fornal@intel.co; Keller, Jacob E > ; Jeff Zheng ; Eyal > Cohen > Subject: RE: [PATCH v2 0/7] support switch management > > Hi Xiao, > > Thank you! I will update the commit log and prepare a document to describ= e > the design and implementation. > > Best regards, > Xiaojun > > -----Original Message----- > From: Wang, Xiao W [mailto:xiao.w.wang@intel.com] > Sent: Tuesday, January 21, 2020 10:53 AM > To: Xiaojun Liu > Cc: dev@dpdk.org; Zhang, Qi Z; Kwan, Ngai-mint; jakub.fornal@intel.co; > Keller, Jacob E > Subject: RE: [PATCH v2 0/7] support switch management > > Hi Xiaojun, > > Could you please help to improve the commit logs of all the 7 patches? Th= ey > look very similar, and info like below is not very helpful for reviewer, = since > we already know which file you are adding. > "To support switch management, add the following files: > Add fm10k/switch/fm10k_debug.h(define log Macros). > Add fm10k/switch/fm10k_regs.h(define all the registers)." > > Please talk more about the design and implementation details in the commi= t > log. Refer to history patches if you need a sample. > > Also please help to address the compile error reported by automation in l= ink > http://patches.dpdk.org/patch/63742/: > "ci/Intel-compilation fail Compilation issues" > > I would look deeper into your change, and you can address above comments > simultaneously. > > Best Regards, > Xiao > > > -----Original Message----- > > From: Xiaojun Liu > > Sent: Wednesday, December 11, 2019 5:52 PM > > To: Wang, Xiao W ; Zhang, Qi Z > > ; Kwan, Ngai-mint ; > > jakub.fornal@intel.co; Keller, Jacob E > > Cc: dev@dpdk.org; Xiaojun Liu > > Subject: [PATCH v2 0/7] support switch management > > > > To avoid configuration for both kernel driver > > and userspace SDK outside DPDK, we add switch > > management in FM10K DPDK PMD driver. > > To enable switch management, you need add > > CONFIG_RTE_FM10K_MANAGEMENT=3Dy in > > config/common_linux when building. > > > > > > Xiaojun Liu (7): > > net/fm10k: add i2c sbus registers definition > > net/fm10k: add some modules of port > > net/fm10k: add config ffu statistics support > > net/fm10k: add flow and switch management > > net/fm10k: add switch initialization > > net/fm10k: add mirror and filter ctrl > > net/fm10k: add dpdk port mapping > > > > drivers/net/fm10k/Makefile | 22 + > > drivers/net/fm10k/fm10k_ethdev.c | 580 +++++- > > drivers/net/fm10k/switch/fm10k_config.c | 855 ++++++++ > > drivers/net/fm10k/switch/fm10k_config.h | 171 ++ > > drivers/net/fm10k/switch/fm10k_debug.h | 19 + > > drivers/net/fm10k/switch/fm10k_ext_port.c | 841 ++++++++ > > drivers/net/fm10k/switch/fm10k_ext_port.h | 136 ++ > > drivers/net/fm10k/switch/fm10k_ffu.c | 1209 +++++++++++ > > drivers/net/fm10k/switch/fm10k_ffu.h | 31 + > > drivers/net/fm10k/switch/fm10k_flow.c | 872 ++++++++ > > drivers/net/fm10k/switch/fm10k_flow.h | 26 + > > drivers/net/fm10k/switch/fm10k_i2c.c | 310 +++ > > drivers/net/fm10k/switch/fm10k_i2c.h | 54 + > > drivers/net/fm10k/switch/fm10k_regs.h | 2202 > ++++++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_sbus.c | 292 +++ > > drivers/net/fm10k/switch/fm10k_sbus.h | 40 + > > drivers/net/fm10k/switch/fm10k_serdes.c | 1886 +++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_serdes.h | 32 + > > drivers/net/fm10k/switch/fm10k_sm.c | 182 ++ > > drivers/net/fm10k/switch/fm10k_sm.h | 78 + > > drivers/net/fm10k/switch/fm10k_spico_code.c | 2966 > > +++++++++++++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_spico_code.h | 21 + > > drivers/net/fm10k/switch/fm10k_stats.c | 1242 +++++++++++ > > drivers/net/fm10k/switch/fm10k_stats.h | 257 +++ > > drivers/net/fm10k/switch/fm10k_switch.c | 2562 > > +++++++++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_switch.h | 336 +++ > > 26 files changed, 17188 insertions(+), 34 deletions(-) > > create mode 100644 drivers/net/fm10k/switch/fm10k_config.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_config.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_debug.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_ext_port.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_ext_port.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_ffu.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_ffu.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_flow.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_flow.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_regs.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_serdes.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_serdes.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_sm.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_sm.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_spico_code.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_spico_code.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_stats.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_stats.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_switch.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_switch.h > > > > -- > > 1.8.3.1