DPDK patches and discussions
 help / color / mirror / Atom feed
From: Xiaojun Liu <xiaojun.liu@silicom.co.il>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Kwan, Ngai-mint" <ngai-mint.kwan@intel.com>,
	"Fornal, Jakub" <jakub.fornal@intel.com>,
	"Keller, Jacob E" <jacob.e.keller@intel.com>,
	Jeff Zheng <jeff.zheng@silicom.co.il>,
	Eyal Cohen <eyalc@silicom.co.il>
Subject: Re: [dpdk-dev] [PATCH v2 0/7] support switch management
Date: Fri, 14 Feb 2020 02:46:06 +0000
Message-ID: <DB7PR04MB5196A5418792DFB1F96DB8B7BD150@DB7PR04MB5196.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <B7F2E978279D1D49A3034B7786DACF407B08B1C1@SHSMSX106.ccr.corp.intel.com>

hi Xiao,

Thanks for your comments! I will fix them ASAP.

Best regards,
Xiaojun
________________________________
From: Wang, Xiao W <xiao.w.wang@intel.com>
Sent: Tuesday, February 11, 2020 6:31 PM
To: Xiaojun Liu <xiaojun.liu@silicom.co.il>
Cc: dev@dpdk.org <dev@dpdk.org>; Zhang, Qi Z <qi.z.zhang@intel.com>; Kwan, Ngai-mint <ngai-mint.kwan@intel.com>; Fornal, Jakub <jakub.fornal@intel.com>; Keller, Jacob E <jacob.e.keller@intel.com>; Jeff Zheng <jeff.zheng@silicom.co.il>; Eyal Cohen <eyalc@silicom.co.il>
Subject: RE: [PATCH v2 0/7] support switch management

Since this is a big code change, so just some general comments/suggestions for your next version patch set:

- please clean up comments like "XXX" in the code.
- It's better to define MACRO for all register addrs and bit shift, please try to avoid magic number (e.g. in the serdes part).
- There're threads created for handling events and timers, we'd better use pthread_join() to recycle them in fm10k_sm_detach().
- set "tapstop" and "shiftwidth" to 8 in vimrc, then recheck the macros and keep them aligned.
- There're some "printf" for debugging, please use dpdk logging API instead.

Best Regards,
Xiao

> -----Original Message-----
> From: Xiaojun Liu <xiaojun.liu@silicom.co.il>
> Sent: Tuesday, January 21, 2020 2:15 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Kwan, Ngai-mint
> <ngai-mint.kwan@intel.com>; jakub.fornal@intel.co; Keller, Jacob E
> <jacob.e.keller@intel.com>; Jeff Zheng <jeff.zheng@silicom.co.il>; Eyal
> Cohen <eyalc@silicom.co.il>
> Subject: RE: [PATCH v2 0/7] support switch management
>
> Hi Xiao,
>
> Thank you! I will update the commit log and prepare a document to describe
> the design and implementation.
>
> Best regards,
> Xiaojun
>
> -----Original Message-----
> From: Wang, Xiao W [mailto:xiao.w.wang@intel.com]
> Sent: Tuesday, January 21, 2020 10:53 AM
> To: Xiaojun Liu
> Cc: dev@dpdk.org; Zhang, Qi Z; Kwan, Ngai-mint; jakub.fornal@intel.co;
> Keller, Jacob E
> Subject: RE: [PATCH v2 0/7] support switch management
>
> Hi Xiaojun,
>
> Could you please help to improve the commit logs of all the 7 patches? They
> look very similar, and info like below is not very helpful for reviewer, since
> we already know which file you are adding.
> "To support switch management, add the following files:
> Add fm10k/switch/fm10k_debug.h(define log Macros).
> Add fm10k/switch/fm10k_regs.h(define all the registers)."
>
> Please talk more about the design and implementation details in the commit
> log. Refer to history patches if you need a sample.
>
> Also please help to address the compile error reported by automation in link
> http://patches.dpdk.org/patch/63742/:
> "ci/Intel-compilation fail    Compilation issues"
>
> I would look deeper into your change, and you can address above comments
> simultaneously.
>
> Best Regards,
> Xiao
>
> > -----Original Message-----
> > From: Xiaojun Liu <xiaojun.liu@silicom.co.il>
> > Sent: Wednesday, December 11, 2019 5:52 PM
> > To: Wang, Xiao W <xiao.w.wang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Kwan, Ngai-mint <ngai-mint.kwan@intel.com>;
> > jakub.fornal@intel.co; Keller, Jacob E <jacob.e.keller@intel.com>
> > Cc: dev@dpdk.org; Xiaojun Liu <xiaojun.liu@silicom.co.il>
> > Subject: [PATCH v2 0/7] support switch management
> >
> > To avoid configuration for both kernel driver
> > and userspace SDK outside DPDK, we add switch
> > management in FM10K DPDK PMD driver.
> > To enable switch management, you need add
> > CONFIG_RTE_FM10K_MANAGEMENT=y in
> > config/common_linux when building.
> >
> >
> > Xiaojun Liu (7):
> >   net/fm10k: add i2c sbus registers definition
> >   net/fm10k: add some modules of port
> >   net/fm10k: add config ffu statistics support
> >   net/fm10k: add flow and switch management
> >   net/fm10k: add switch initialization
> >   net/fm10k: add mirror and filter ctrl
> >   net/fm10k: add dpdk port mapping
> >
> >  drivers/net/fm10k/Makefile                  |   22 +
> >  drivers/net/fm10k/fm10k_ethdev.c            |  580 +++++-
> >  drivers/net/fm10k/switch/fm10k_config.c     |  855 ++++++++
> >  drivers/net/fm10k/switch/fm10k_config.h     |  171 ++
> >  drivers/net/fm10k/switch/fm10k_debug.h      |   19 +
> >  drivers/net/fm10k/switch/fm10k_ext_port.c   |  841 ++++++++
> >  drivers/net/fm10k/switch/fm10k_ext_port.h   |  136 ++
> >  drivers/net/fm10k/switch/fm10k_ffu.c        | 1209 +++++++++++
> >  drivers/net/fm10k/switch/fm10k_ffu.h        |   31 +
> >  drivers/net/fm10k/switch/fm10k_flow.c       |  872 ++++++++
> >  drivers/net/fm10k/switch/fm10k_flow.h       |   26 +
> >  drivers/net/fm10k/switch/fm10k_i2c.c        |  310 +++
> >  drivers/net/fm10k/switch/fm10k_i2c.h        |   54 +
> >  drivers/net/fm10k/switch/fm10k_regs.h       | 2202
> ++++++++++++++++++++
> >  drivers/net/fm10k/switch/fm10k_sbus.c       |  292 +++
> >  drivers/net/fm10k/switch/fm10k_sbus.h       |   40 +
> >  drivers/net/fm10k/switch/fm10k_serdes.c     | 1886 +++++++++++++++++
> >  drivers/net/fm10k/switch/fm10k_serdes.h     |   32 +
> >  drivers/net/fm10k/switch/fm10k_sm.c         |  182 ++
> >  drivers/net/fm10k/switch/fm10k_sm.h         |   78 +
> >  drivers/net/fm10k/switch/fm10k_spico_code.c | 2966
> > +++++++++++++++++++++++++++
> >  drivers/net/fm10k/switch/fm10k_spico_code.h |   21 +
> >  drivers/net/fm10k/switch/fm10k_stats.c      | 1242 +++++++++++
> >  drivers/net/fm10k/switch/fm10k_stats.h      |  257 +++
> >  drivers/net/fm10k/switch/fm10k_switch.c     | 2562
> > +++++++++++++++++++++++
> >  drivers/net/fm10k/switch/fm10k_switch.h     |  336 +++
> >  26 files changed, 17188 insertions(+), 34 deletions(-)
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_config.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_config.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_debug.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_ext_port.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_ext_port.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_ffu.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_ffu.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_flow.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_flow.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_regs.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_serdes.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_serdes.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_sm.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_sm.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_spico_code.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_spico_code.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_stats.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_stats.h
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_switch.c
> >  create mode 100644 drivers/net/fm10k/switch/fm10k_switch.h
> >
> > --
> > 1.8.3.1


  reply	other threads:[~2020-02-14  2:46 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11  9:51 Xiaojun Liu
2019-12-11  9:52 ` [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition Xiaojun Liu
2019-12-11 15:48   ` Jerin Jacob
2019-12-12  9:35     ` Xiaojun Liu
2019-12-12 17:12       ` Jerin Jacob
2019-12-13  2:44         ` Xiaojun Liu
2019-12-16  4:54           ` Jerin Jacob
2020-02-20 13:59   ` [dpdk-dev] [PATCH v2 0/5] support switch management Xiaojun Liu
2020-02-20 13:59     ` [dpdk-dev] [PATCH v2 1/5] net/fm10k: add basic functions for " Xiaojun Liu
2020-02-28  8:38       ` [dpdk-dev] [PATCH v1 0/5] support fm10k " Xiaojun Liu
2020-02-28  8:38         ` [dpdk-dev] [PATCH v1 1/5] net/fm10k: add basic functions for " Xiaojun Liu
2020-03-16  6:37           ` Wang, Xiao W
2020-02-28  8:38         ` [dpdk-dev] [PATCH v1 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu
2020-03-16  6:48           ` Wang, Xiao W
2020-02-28  8:38         ` [dpdk-dev] [PATCH v1 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu
2020-03-16  7:04           ` Wang, Xiao W
2020-02-28  8:38         ` [dpdk-dev] [PATCH v1 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu
2020-02-28  8:38         ` [dpdk-dev] [PATCH v1 5/5] net/fm10k: add switch management support Xiaojun Liu
2020-03-16  7:34           ` Wang, Xiao W
2020-03-20  6:58           ` [dpdk-dev] [PATCH v3 0/5] support fm10k switch management Xiaojun Liu
2020-03-20  6:58             ` [dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for " Xiaojun Liu
2020-04-02  8:41               ` Wang, Xiao W
2020-04-08  3:25                 ` Xiaojun Liu
2020-03-20  6:58             ` [dpdk-dev] [PATCH v3 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu
2020-03-20  6:58             ` [dpdk-dev] [PATCH v3 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu
2020-03-20  6:58             ` [dpdk-dev] [PATCH v3 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu
2020-04-02  8:55               ` Wang, Xiao W
2020-04-09  6:24                 ` Xiaojun Liu
2020-03-20  6:58             ` [dpdk-dev] [PATCH v3 5/5] net/fm10k: add switch management support Xiaojun Liu
2020-04-02  9:12               ` Wang, Xiao W
2020-04-09  6:32                 ` Xiaojun Liu
2020-02-20 13:59     ` [dpdk-dev] [PATCH v2 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu
2020-02-20 13:59     ` [dpdk-dev] [PATCH v2 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu
2020-02-20 13:59     ` [dpdk-dev] [PATCH v2 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu
2020-02-20 13:59     ` [dpdk-dev] [PATCH v2 5/5] net/fm10k: add switch management support Xiaojun Liu
2020-02-25 11:28       ` Wang, Xiao W
2020-02-25 12:56         ` Xiaojun Liu
2020-03-05  1:23         ` Xiaojun Liu
2019-12-11  9:52 ` [dpdk-dev] [PATCH v2 2/7] net/fm10k: add some modules of port Xiaojun Liu
2019-12-11  9:52 ` [dpdk-dev] [PATCH v2 3/7] net/fm10k: add config ffu statistics support Xiaojun Liu
2019-12-11  9:52 ` [dpdk-dev] [PATCH v2 4/7] net/fm10k: add flow and switch management Xiaojun Liu
2019-12-11  9:52 ` [dpdk-dev] [PATCH v2 5/7] net/fm10k: add switch initialization Xiaojun Liu
2019-12-11  9:52 ` [dpdk-dev] [PATCH v2 6/7] net/fm10k: add mirror and filter ctrl Xiaojun Liu
2019-12-11  9:52 ` [dpdk-dev] [PATCH v2 7/7] net/fm10k: add dpdk port mapping Xiaojun Liu
2020-01-21  2:53 ` [dpdk-dev] [PATCH v2 0/7] support switch management Wang, Xiao W
2020-01-21  6:15   ` Xiaojun Liu
2020-02-11 10:31     ` Wang, Xiao W
2020-02-14  2:46       ` Xiaojun Liu [this message]
     [not found]       ` <ORIGINAL-RELEASE-1581835643311863404-DB7PR04MB5196A5418792DFB1F96DB8B7BD150@DB7PR04MB5196.eurprd04.prod.outlook.com>
2020-02-19  5:58         ` Xiaojun Liu
2020-02-19 10:56           ` Wang, Xiao W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR04MB5196A5418792DFB1F96DB8B7BD150@DB7PR04MB5196.eurprd04.prod.outlook.com \
    --to=xiaojun.liu@silicom.co.il \
    --cc=dev@dpdk.org \
    --cc=eyalc@silicom.co.il \
    --cc=jacob.e.keller@intel.com \
    --cc=jakub.fornal@intel.com \
    --cc=jeff.zheng@silicom.co.il \
    --cc=ngai-mint.kwan@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git