From: Shahaf Shuler <shahafs@mellanox.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload
Date: Mon, 30 Jul 2018 09:50:24 +0000 [thread overview]
Message-ID: <DB7PR05MB44260316C76508C96B4D9B0AC32F0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180730093555.GA22823@jerin>
Monday, July 30, 2018 12:36 PM, Jerin Jacob:
> > Subject: RE: [dpdk-dev] [PATCH] examples: remove Rx checksum offload
> >
> >
> > Hi Jerin,
>
> Hi Konstantin,
>
> >
> > >
> > > As of now, application does not check PKT_RX_*_CKSUM_* flags per
> > > packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or
> not.
> > >
> > > Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save
> a
> > > few cycles if possible.
> >
> > Personally, I'd move in other direction: keep RX checksum offload and
> > add checks inside sample apps to handle (drop) packets with invalid
> checksum.
>
> OK. Till someones add the DROP logic in application, Can we take this patch?
> Because there is no point in enabling DEV_RX_OFFLOAD_CHECKSUM without
> DROP or any meaning full action in application.
I agree w/ Constantine.
If the l3fwd application targets to simulate vrouter which do IP forwarding validating the checksum is part of the required logic.
The patch should not remove it rather add check on the mbuf checksum fields and drop the mbuf accordingly.
>
>
> > Konstantin
> >
> > >
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
> > > examples/ip_fragmentation/main.c | 3 +--
> > > examples/ip_reassembly/main.c | 3 +--
> > > examples/ipsec-secgw/ipsec-secgw.c | 3 +--
> > > examples/l3fwd-acl/main.c | 3 +--
> > > examples/l3fwd-power/main.c | 4 ++--
> > > examples/l3fwd-vf/main.c | 3 +--
> > > examples/l3fwd/main.c | 3 +--
> > > examples/load_balancer/init.c | 3 +--
> > > examples/multi_process/symmetric_mp/main.c | 3 +--
> > > examples/performance-thread/l3fwd-thread/main.c | 3 +--
> > > examples/qos_meter/main.c | 3 +--
> > > 11 files changed, 12 insertions(+), 22 deletions(-)
> > >
> > > diff --git a/examples/ip_fragmentation/main.c
> > > b/examples/ip_fragmentation/main.c
> > > index 5306d7672..7cbd5dc10 100644
> > > --- a/examples/ip_fragmentation/main.c
> > > +++ b/examples/ip_fragmentation/main.c
> > > @@ -140,8 +140,7 @@ static struct rte_eth_conf port_conf = {
> > > .rxmode = {
> > > .max_rx_pkt_len = JUMBO_FRAME_MAX_SIZE,
> > > .split_hdr_size = 0,
> > > - .offloads = (DEV_RX_OFFLOAD_CHECKSUM |
> > > - DEV_RX_OFFLOAD_JUMBO_FRAME |
> > > + .offloads = (DEV_RX_OFFLOAD_JUMBO_FRAME |
> > > DEV_RX_OFFLOAD_CRC_STRIP),
> > > },
> > > .txmode = {
> > > diff --git a/examples/ip_reassembly/main.c
> > > b/examples/ip_reassembly/main.c index b830f67a5..7acc6b7b5 100644
> > > --- a/examples/ip_reassembly/main.c
> > > +++ b/examples/ip_reassembly/main.c
> > > @@ -164,8 +164,7 @@ static struct rte_eth_conf port_conf = {
> > > .mq_mode = ETH_MQ_RX_RSS,
> > > .max_rx_pkt_len = JUMBO_FRAME_MAX_SIZE,
> > > .split_hdr_size = 0,
> > > - .offloads = (DEV_RX_OFFLOAD_CHECKSUM |
> > > - DEV_RX_OFFLOAD_JUMBO_FRAME |
> > > + .offloads = (DEV_RX_OFFLOAD_JUMBO_FRAME |
> > > DEV_RX_OFFLOAD_CRC_STRIP),
> > > },
> > > .rx_adv_conf = {
> > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c
> > > b/examples/ipsec-secgw/ipsec-secgw.c
> > > index b45b87bde..63eef1f26 100644
> > > --- a/examples/ipsec-secgw/ipsec-secgw.c
> > > +++ b/examples/ipsec-secgw/ipsec-secgw.c
> > > @@ -197,8 +197,7 @@ static struct rte_eth_conf port_conf = {
> > > .mq_mode = ETH_MQ_RX_RSS,
> > > .max_rx_pkt_len = ETHER_MAX_LEN,
> > > .split_hdr_size = 0,
> > > - .offloads = DEV_RX_OFFLOAD_CHECKSUM |
> > > - DEV_RX_OFFLOAD_CRC_STRIP,
> > > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > > },
> > > .rx_adv_conf = {
> > > .rss_conf = {
> > > diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
> > > index 7c063a8d0..c66b5b462 100644
> > > --- a/examples/l3fwd-acl/main.c
> > > +++ b/examples/l3fwd-acl/main.c
> > > @@ -127,8 +127,7 @@ static struct rte_eth_conf port_conf = {
> > > .mq_mode = ETH_MQ_RX_RSS,
> > > .max_rx_pkt_len = ETHER_MAX_LEN,
> > > .split_hdr_size = 0,
> > > - .offloads = (DEV_RX_OFFLOAD_CRC_STRIP |
> > > - DEV_RX_OFFLOAD_CHECKSUM),
> > > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > > },
> > > .rx_adv_conf = {
> > > .rss_conf = {
> > > diff --git a/examples/l3fwd-power/main.c
> > > b/examples/l3fwd-power/main.c index d15cd520e..b00a8ec45 100644
> > > --- a/examples/l3fwd-power/main.c
> > > +++ b/examples/l3fwd-power/main.c
> > > @@ -180,8 +180,8 @@ static struct rte_eth_conf port_conf = {
> > > .mq_mode = ETH_MQ_RX_RSS,
> > > .max_rx_pkt_len = ETHER_MAX_LEN,
> > > .split_hdr_size = 0,
> > > - .offloads = (DEV_RX_OFFLOAD_CRC_STRIP |
> > > - DEV_RX_OFFLOAD_CHECKSUM),
> > > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > > +
> > > },
> > > .rx_adv_conf = {
> > > .rss_conf = {
> > > diff --git a/examples/l3fwd-vf/main.c b/examples/l3fwd-vf/main.c
> > > index 5edd91a78..2a10e9d76 100644
> > > --- a/examples/l3fwd-vf/main.c
> > > +++ b/examples/l3fwd-vf/main.c
> > > @@ -161,8 +161,7 @@ static struct rte_eth_conf port_conf = {
> > > .mq_mode = ETH_MQ_RX_RSS,
> > > .max_rx_pkt_len = ETHER_MAX_LEN,
> > > .split_hdr_size = 0,
> > > - .offloads = (DEV_RX_OFFLOAD_CRC_STRIP |
> > > - DEV_RX_OFFLOAD_CHECKSUM),
> > > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > > },
> > > .rx_adv_conf = {
> > > .rss_conf = {
> > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index
> > > ab019b9e4..d4a79b23f 100644
> > > --- a/examples/l3fwd/main.c
> > > +++ b/examples/l3fwd/main.c
> > > @@ -120,8 +120,7 @@ static struct rte_eth_conf port_conf = {
> > > .mq_mode = ETH_MQ_RX_RSS,
> > > .max_rx_pkt_len = ETHER_MAX_LEN,
> > > .split_hdr_size = 0,
> > > - .offloads = (DEV_RX_OFFLOAD_CRC_STRIP |
> > > - DEV_RX_OFFLOAD_CHECKSUM),
> > > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > > },
> > > .rx_adv_conf = {
> > > .rss_conf = {
> > > diff --git a/examples/load_balancer/init.c
> > > b/examples/load_balancer/init.c index f2045f235..14ea1e9d8 100644
> > > --- a/examples/load_balancer/init.c
> > > +++ b/examples/load_balancer/init.c
> > > @@ -45,8 +45,7 @@ static struct rte_eth_conf port_conf = {
> > > .rxmode = {
> > > .mq_mode = ETH_MQ_RX_RSS,
> > > .split_hdr_size = 0,
> > > - .offloads = (DEV_RX_OFFLOAD_CHECKSUM |
> > > - DEV_RX_OFFLOAD_CRC_STRIP),
> > > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > > },
> > > .rx_adv_conf = {
> > > .rss_conf = {
> > > diff --git a/examples/multi_process/symmetric_mp/main.c
> > > b/examples/multi_process/symmetric_mp/main.c
> > > index c6c6a537f..2735a68c5 100644
> > > --- a/examples/multi_process/symmetric_mp/main.c
> > > +++ b/examples/multi_process/symmetric_mp/main.c
> > > @@ -178,8 +178,7 @@ smp_port_init(uint16_t port, struct rte_mempool
> *mbuf_pool,
> > > .rxmode = {
> > > .mq_mode = ETH_MQ_RX_RSS,
> > > .split_hdr_size = 0,
> > > - .offloads = (DEV_RX_OFFLOAD_CHECKSUM |
> > > - DEV_RX_OFFLOAD_CRC_STRIP),
> > > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > > },
> > > .rx_adv_conf = {
> > > .rss_conf = { diff --git
> > > a/examples/performance-thread/l3fwd-thread/main.c
> > > b/examples/performance-thread/l3fwd-thread/main.c
> > > index 5392fcea8..5f4a470b4 100644
> > > --- a/examples/performance-thread/l3fwd-thread/main.c
> > > +++ b/examples/performance-thread/l3fwd-thread/main.c
> > > @@ -306,8 +306,7 @@ static struct rte_eth_conf port_conf = {
> > > .mq_mode = ETH_MQ_RX_RSS,
> > > .max_rx_pkt_len = ETHER_MAX_LEN,
> > > .split_hdr_size = 0,
> > > - .offloads = (DEV_RX_OFFLOAD_CHECKSUM |
> > > - DEV_RX_OFFLOAD_CRC_STRIP),
> > > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > > },
> > > .rx_adv_conf = {
> > > .rss_conf = {
> > > diff --git a/examples/qos_meter/main.c b/examples/qos_meter/main.c
> > > index 5cf4e9dfa..a29032b04 100644
> > > --- a/examples/qos_meter/main.c
> > > +++ b/examples/qos_meter/main.c
> > > @@ -56,8 +56,7 @@ static struct rte_eth_conf port_conf = {
> > > .mq_mode = ETH_MQ_RX_RSS,
> > > .max_rx_pkt_len = ETHER_MAX_LEN,
> > > .split_hdr_size = 0,
> > > - .offloads = (DEV_RX_OFFLOAD_CHECKSUM |
> > > - DEV_RX_OFFLOAD_CRC_STRIP),
> > > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > > },
> > > .rx_adv_conf = {
> > > .rss_conf = {
> > > --
> > > 2.18.0
> >
next prev parent reply other threads:[~2018-07-30 9:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 12:44 Jerin Jacob
2018-07-30 9:27 ` Ananyev, Konstantin
2018-07-30 9:35 ` Jerin Jacob
2018-07-30 9:50 ` Shahaf Shuler [this message]
2018-07-30 9:50 ` Thomas Monjalon
2018-07-30 11:00 ` Ananyev, Konstantin
2018-07-30 11:18 ` Jerin Jacob
2018-07-30 14:12 ` Ananyev, Konstantin
2018-07-30 14:40 ` Jerin Jacob
2018-07-30 15:30 ` Andrew Rybchenko
2018-08-23 12:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB44260316C76508C96B4D9B0AC32F0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).